Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-02 Thread Thomas DiModica
>No, the semantics are the same. And you're saying it yourself : >"hurd_thread_cancel kindly informs the thread that it has been >canceled". The description of pthread_cancel is "The pthread_cancel() >function shall request that thread be canceled. [...] The cancellation >processing in the target t

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-02 Thread Richard Braun
On Thu, Aug 02, 2012 at 03:13:12PM -0700, Thomas DiModica wrote: > I get what you're saying: I'm confusing the semantics of how cancellation > is HANDLED with the semantics of how it is SIGNALED. The signaling > semantics are the same. That's it. > You mean like a PTHREAD_CANCEL_GNU? It would be

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-02 Thread Richard Braun
On Wed, Aug 01, 2012 at 06:40:05PM -0700, Thomas DiModica wrote: > > > >No, the semantics are the same. The internal implementation may slightly > >differ, I haven't looked in detail. The point is how to handle > >cancellation from a cancelled thread, not how to mark a thread as being > >cancelle

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-01 Thread Thomas DiModica
>No, the semantics are the same. The internal implementation may slightly >differ, I haven't looked in detail. The point is how to handle >cancellation from a cancelled thread, not how to mark a thread as being >cancelled. The hurd_thread_cancel function merely exists because there >isn't any in

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-01 Thread Richard Braun
On Wed, Aug 01, 2012 at 08:44:20AM -0700, Thomas DiModica wrote: > Most of what I understand is from what Marcus has to say in this thread here: > http://lists.gnu.org/archive/html/hurd-devel/2002-07/msg00010.html That link explains the problem very well. It's better to keep the current calls to h

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-08-01 Thread Thomas DiModica
From: Richard Braun To: Thomas DiModica Cc: "debian-hurd@lists.debian.org" ; "bdefre...@debian.org" Sent: Tuesday, July 31, 2012 4:48 PM Subject: Re: Hurd_condition_wait in glibc libpthreads in Debian On Tue, Jul 31, 2012 at 03:16:05PM -0700, Thomas DiModica wrote: > A

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-07-31 Thread Richard Braun
On Tue, Jul 31, 2012 at 03:16:05PM -0700, Thomas DiModica wrote: > As an aside, Vicente Ara (zenton) actually wrote the pthread > hurd_condition_wait. > For the provenance of this file, see the thread: > http://lists.gnu.org/archive/html/bug-hurd/2002-11/msg00195.html My understanding is that pth

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-07-31 Thread Thomas DiModica
As an aside, Vicente Ara (zenton) actually wrote the pthread hurd_condition_wait. For the provenance of this file, see the thread: http://lists.gnu.org/archive/html/bug-hurd/2002-11/msg00195.html I'm surprised that the function wasn't added to libpthread earlier. Thomas DiModica -- To UNSUB

Re: Hurd_condition_wait in glibc libpthreads in Debian

2012-07-31 Thread Barry deFreese
Here is an updated patch that builds with Debian. Haven't tested it yet, I am working on creating a test environment. I essentially just moved the changes Thomas made into pt-cond-wait.c in libpthread in glibc. Thanks, Barry On 7/30/2012 9:45 AM, Barry deFreese wrote: > Hi folks, > > OK, I

Hurd_condition_wait in glibc libpthreads in Debian

2012-07-30 Thread Barry deFreese
Hi folks, OK, I have a patch that adds pthread_hurd_cond_wait into the libpthreads that Samuel has migrated into Debian's glibc. It builds but it isn't creating the symbol in libpthreads.so. What stupid thing am I missing? Attached is the patch. Thanks! Barry deFreese diff -pruN libpthread