Bug#678358: hurd should not define AF_LINK .....

2012-06-20 Thread Nicholas Bamber
Package: hurd Version: 20120605-2 Severity: important Dear Maintainer, *** Please consider answering these questions, where appropriate *** ... or if it does should implement the relevant functionality including making a definition of the sockaddr_dl structure available. * What led up to the

Re: Patch for libpst (for review)

2012-06-20 Thread Guillem Jover
Hi! On Wed, 2012-06-20 at 19:10:17 +0200, Svante Signell wrote: > If there is a need to build pst2dii that .cpp-file has to be patched too > (not done yet). Looks like it will be enabled if the right version > of /usr/bin/convert is found (probably from imagemagick). Not in the > build depends tho

Re: suggested fix

2012-06-20 Thread Steven Chamberlain
On 20/06/12 22:09, Nicholas Bamber wrote: > On 20/06/12 22:04, Steven Chamberlain wrote: >> This debdiff doesn't address the main point of my original mail: >> sockaddr_dl and net/if_dl.h are not (k)FreeBSD-specific, so a test for >> FreeBSD || FreeBSD_kernel would not be appropriate. You still di

Re: suggested fix

2012-06-20 Thread Nicholas Bamber
On 20/06/12 22:04, Steven Chamberlain wrote: > On 20/06/12 15:59, Nicholas Bamber wrote: >> Based upon the feedback I have received (including #debian-hurd) I am >> attaching a new debdiff. > > This debdiff doesn't address the main point of my original mail: > sockaddr_dl and net/if_dl.h are not (

Re: suggested fix

2012-06-20 Thread Steven Chamberlain
On 20/06/12 15:59, Nicholas Bamber wrote: > Based upon the feedback I have received (including #debian-hurd) I am > attaching a new debdiff. This debdiff doesn't address the main point of my original mail: sockaddr_dl and net/if_dl.h are not (k)FreeBSD-specific, so a test for FreeBSD || FreeBSD_ke

Patch for libpst (for review)

2012-06-20 Thread Svante Signell
Hi Jordi, Saw on IRC logs that you needed a patch for libpst. What about the attached patch? If there is a need to build pst2dii that .cpp-file has to be patched too (not done yet). Looks like it will be enabled if the right version of /usr/bin/convert is found (probably from imagemagick). Not in

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Cyril Roelandt
On 06/20/2012 02:37 PM, Barry deFreese wrote: Thanks but what are you doing there if you overrun the size of filename (not that they are handling it now either but PATH_MAX is fairly large). Well, it seems like this function does not return anything, so you can't use an error code. You coul

Re: suggested fix

2012-06-20 Thread Nicholas Bamber
Jamie, Based upon the feedback I have received (including #debian-hurd) I am attaching a new debdiff. Unless I get any more feedback I'll probably upload it tomorrow with a 2-day delay. diff -Nru pmacct-0.14.0/debian/changelog pmacct-0.14.0/debian/changelog --- pmacct-0.14.0/debian/changelo

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Barry deFreese
On 6/20/2012 8:13 AM, Cyril Roelandt wrote: > On 06/20/2012 05:20 AM, Barry deFreese wrote: >> Hi again, >> >> Here is a simple little patch to build pong2 (uses PATH_MAX). >> >> Let me know if this looks sane. >> > > > Why not do this : > > size = strlen(...) + 1; > filename = malloc(size); > #

Re: suggested fix

2012-06-20 Thread Steven Chamberlain
Hi Nicholas, On 20/06/12 12:53, Nicholas Bamber wrote: > Sorry I didn't notice the FTBS on hurd as I was concentrating on the > red. I guess I should have trusted the bug report title more. I only noticed on buildd.d.o that the failure was the same there. > However I am confused at what your are

Re: pong2 - PATH_MAX patch for review

2012-06-20 Thread Cyril Roelandt
On 06/20/2012 05:20 AM, Barry deFreese wrote: Hi again, Here is a simple little patch to build pong2 (uses PATH_MAX). Let me know if this looks sane. Why not do this : size = strlen(...) + 1; filename = malloc(size); #ifdef PATH_MAX if (size > PATH_MAX) handle_error(); #endif snprintf(

Re: suggested fix

2012-06-20 Thread Nicholas Bamber
On 20/06/12 12:27, Steven Chamberlain wrote: > On 20/06/12 11:56, Nicholas Bamber wrote: >> I have a proposed fix as attached. It's built, signed and ready to go. >> If you have intentions to fix it yourself please reply and do so >> promptly. I'll run my fix past a few people for feedback but aft