Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Holger Levsen
On Thu, Jun 02, 2016 at 06:19:58AM +0200, Andreas Tille wrote: > Without checking: After Building you get a *.changes file. run lintian on it to check, lintian will complain if the syntax is wrong… lintian $changes_file -- cheers, Holger signature.asc Description: Digital signature

Re: make gosa packages php7 compliant

2016-06-02 Thread Wolfgang Schweer
On Wed, Jun 01, 2016 at 11:51:57PM +0200, Wolfgang Schweer wrote: > On Wed, Jun 01, 2016 at 07:27:15PM +0200, Wolfgang Schweer wrote: > > On Wed, Jun 01, 2016 at 03:13:45PM +0200, Wolfgang Schweer wrote: > > > On Wed, Jun 01, 2016 at 11:00:28AM +, Mike Gabriel wrote: > > > > I have just uploade

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Mike Gabriel
Hi Dominik, On Do 02 Jun 2016 01:26:30 CEST, Dominik George wrote: Hi, one more question: Is the „Closes:“ line in changelog syntactically correct to close all the bugs? -nik Are you sure that all those bugs can be closed? Have you tested your version regarding all those reported iss

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Dominik George
Hi, > Are you sure that all those bugs can be closed? Have you tested your > version regarding all those reported issues you are closing? If yes. > Then... > > Personally, I like to name what I close. I.e. give a short description > how an issue was fixed. If I don't know how it was fixed but tha

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Mike Gabriel
Hi Nik, On Do 02 Jun 2016 01:20:00 CEST, Andreas Tille wrote: Hi Dominik, On Thu, Jun 02, 2016 at 12:44:18AM +0200, Dominik George wrote: newest version is in collab-maint, issues seem to be resolved. Please test, and, if satisfied, feel free to upload ;). Very good. Unfortunately I can

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Mike Gabriel
On Do 02 Jun 2016 21:13:14 CEST, Dominik George wrote: Hi, Are you sure that all those bugs can be closed? Have you tested your version regarding all those reported issues you are closing? If yes. Then... Personally, I like to name what I close. I.e. give a short description how an issue was

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Dominik George
Hi, > As a training task, please do this: > >o remove the above quoted placeholder white-list block >o run debuild -uc -us -S -Zxz and let lintian provide you > with files not mentioned anymore in debian/copyright >o go over the debian/copyright.in and merge information from >

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Dominik George
Hi, > Ack. Please give a short reason in debian/changelog for closing those > bugs, then: e.g. > >- Using VNC as backend is discouraged nowadays and xrdpxorg (or > what's its name) supercedes that VNC backend. Thus closing bug related > to VNC as xrdp backend. (Closes: #1, #2, #3, #4...). Do

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Mike Gabriel
Hi Nik, On Do 02 Jun 2016 23:02:09 CEST, Dominik George wrote: Hi, Ack. Please give a short reason in debian/changelog for closing those bugs, then: e.g. - Using VNC as backend is discouraged nowadays and xrdpxorg (or what's its name) supercedes that VNC backend. Thus closing bug related

gosa: fix-constructors.sh script

2016-06-02 Thread Wolfgang Schweer
At least the class xml should be excluded: --- gosa/debian/fix-constructors.sh 2016-06-02 23:29:51.160689208 +0200 +++ fix-constructors.sh 2016-06-02 23:32:20.422050137 +0200 @@ -15,7 +15,9 @@ sed -i "s/function ${class} *(/function __construct(/" ${split[1]} find * -type f | egrep "\.

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Dominik George
Hi, > Ack. Please give a short reason in debian/changelog for closing those > bugs, then: e.g. > >- Using VNC as backend is discouraged nowadays and xrdpxorg (or > what's its name) supercedes that VNC backend. Thus closing bug related > to VNC as xrdp backend. (Closes: #1, #2, #3, #4...). I

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Mike Gabriel
Hi Nik, On Do 02 Jun 2016 23:53:48 CEST, Dominik George wrote: Hi, Ack. Please give a short reason in debian/changelog for closing those bugs, then: e.g. - Using VNC as backend is discouraged nowadays and xrdpxorg (or what's its name) supercedes that VNC backend. Thus closing bug related

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Dominik George
Hi Mike, > I made some cosmetic changes under debian/changelog and re-fixed the > year-author-syntax in debian/copyright's Copyright: fields. OK. I skipped that as DEP-5 says that the Copyright: fields may well be an exact copy of the copyright notice in the source files. > Apart from that: Upl

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Andreas Tille
On Thu, Jun 02, 2016 at 11:02:09PM +0200, Dominik George wrote: > > There are some notes from Andreas and you in the changelog. I think they are > irrelevant for the public. Can I drop them? Drop whatever you think is irrelevant that I might have injected Andreas. -- http://fam-tille.de

Re: Bug#719624: Upgrading xrdp

2016-06-02 Thread Andreas Tille
On Fri, Jun 03, 2016 at 01:25:41AM +0200, Dominik George wrote: > > Apart from that: Uploaded!!! As the package will go through the NEW > > queue, let's see what the ftp-masters say. > > Thanks a lot for the help and the final upload! Thanks to you both! > Meanwhile, I have started work on guac