Re: Roadmap for the 1.15.x series

On Sat, 2009-08-22 at 10:19:09 +0200, Tollef Fog Heen wrote: > ]] Guillem Jover > > | * Extend conffile support, merge back ucf: > | > | - Store conffiles at install time. > | <http://wiki.debian.org/Teams/Dpkg/Proposals/ConffileDatabase> > | - Support regi

Re: [PATCH] move quote_filename into help.c, and remove static scope, as it will also

Hi! On Tue, 2008-03-04 at 18:54:03 +0100, Sean Finney wrote: > From: Sean Finney > > --- > src/archives.c | 58 > > src/help.c | 57 +++ > src/main.h |1 + > 3 files cha

Re: [PATCH] move quote_filename into help.c, and remove static scope, as it will also

Hi! On Wed, 2009-09-23 at 11:53:16 +0200, sean finney wrote: > On Sat, Sep 19, 2009 at 05:00:15PM +0200, Guillem Jover wrote: > > > -quote_filename(char *buf, int size, char *s) > > > +char* quote_filename(char *buf, int size, char *s) > > > Could you move this

Re: Bug#546680: man-db: start-stop-daemon: Unable to alter IO priority to mask 24583 (Operation not permitted)

Hi! On Thu, 2009-09-24 at 13:27:52 +0100, Colin Watson wrote: > On Tue, Sep 15, 2009 at 11:05:16AM +1000, Daniel Pittman wrote: > > G'day. I don't know if this is correctly a man-db bug, or a dpkg bug: > > > > Since man-db has started using start-stop-daemon in the daily and weekly > > cron.d sc

Re: md5sum'ing a string buffer: questions regarding buffer code

Hi! On Thu, 2009-09-24 at 09:11:24 +0200, sean finney wrote: > previously, i had this function to create the md5sum of a filename: > > /* calculate the md5sum of the contents of the null-terminated string input > * putting the result in output, which will be allocated with memory to > * store

Re: coding conventions?

On Tue, 2009-09-08 at 21:49:11 +0200, Raphael Hertzog wrote: > On Tue, 08 Sep 2009, Mikhail Gusarov wrote: > > Is there written code conventions for dpkg? If no, then which style to > > copy in new code? > > > > I'm rewriting dpkg-divert in C, so "adjust according to code around" > > isn't really

Re: xz support in dpkg (was Re: dpkg plans for the squeeze cycle)

Hi! On Tue, 2009-09-22 at 01:40:20 -0500, Jonathan Nieder wrote: > LZMA decompressors can use large amounts of memory when processing > archives built with a large dictionary size. Running out of memory > can have bad effects, so the decompressor takes an argument > representing maximum memory us

Re: Error building man pages

Hi! On Sat, 2009-09-26 at 19:04:28 +0200, Helge Kreutzmann wrote: > during my routine check for strings to update, I encountered that the > man pages are currently not buildable (at least on stable): > > in the autoreconf step I see: > man/Makefile.am:3: PO4A_V_$(V: non-POSIX variable name > man/

Re: [PATCH] debian/copyright: Update path to MD5 code

Hi! On Tue, 2009-09-29 at 19:54:38 -0500, Jonathan Nieder wrote: > I wrote: > > Just noticed debian/copyright still refers to lib/md5.c. Here's a patch > > to fix it. > > but I forgot to attach this patch. Sorry about that. Thanks, pushed. regards, guillem -- To UNSUBSCRIBE, email to debia

Re: [PATCH] Use FIBMAP to sort .list files before scanning

Hi Morten! On Sat, 2009-09-05 at 01:34:50 +0200, Morten Hustveit wrote: > When running dpkg from a cold cache on a system where /var/lib/dpkg/info/ lies > on a harddisk, a lot of time is spent waiting for seeks between (typically) > thousands of files. This patch ensures that the package iterator

Re: [PATCH 2/6] move copyfileperms to non-static file_copyfileperms

Hi! Same for this one, comments on the minor modifications follow. On Mon, 2009-09-28 at 23:34:29 +0200, Sean Finney wrote: > this functionality is also needed by the conffile handling code to ensure > that the merge output is stored in a file with the same permissions as > the original conffile,

Re: [PATCH] Use FIBMAP to sort .list files before scanning

On Mon, 2009-10-05 at 11:56:25 +, Florian Weimer wrote: > * Guillem Jover: > > On kFreeBSD there's FIOGETLBA, but it seems to only be implemented for > > the cd9660 file system, so not of much use. Also AFAIU from taking a > > look at Linux, FIBMAP is being phased out

Re: [PATCH 1/6] move quote_filename into lib/dpkg/path.{c,h} as path_quote_filename

Hi! I've pushed this with few minor modifications. I thought it would be less work for both of you, and it was just nit picking stuff. Commmenting anyway for reference. On Mon, 2009-09-28 at 23:34:28 +0200, Sean Finney wrote: > From: Sean Finney > > this function will be useful for other parts

Re: xz support in dpkg (was Re: dpkg plans for the squeeze cycle)

Hi! On Wed, 2009-09-30 at 19:19:01 -0500, Jonathan Nieder wrote: > Guillem Jover wrote: > > I guess a better question is, how much benefit a bigger dictionary size > > would give us? > Good question. Fedora people have been recently considering a similar > question (the

Re: Bug#274747: dependency on dpkg-dev is not required for provides

Hi! On Mon, 2009-10-12 at 10:54:07 +0200, Aurelien Jarno wrote: > On Sat, Oct 10, 2009 at 08:43:16PM -0700, Josh Triplett wrote: > > Package: type-handling > > Version: 0.2.23 > > Severity: normal > > > > This issue has just become somewhat more commonplace: > > gnome-desktop-environment now uses

Re: [PATCH] Pass -I$(top_builddir) to libcompat as it uses config.h

Hi! On Wed, 2009-10-14 at 03:36:20 +0700, Mikhail Gusarov wrote: > --- > lib/compat/Makefile.am |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/compat/Makefile.am b/lib/compat/Makefile.am > index 4debfa2..a312ef3 100644 > --- a/lib/compat/Makefile.am > +++ b/

Re: lib/compat/vsnprintf.c is non-C99 like

Hi! On Wed, 2009-10-14 at 04:05:47 +0700, Mikhail Gusarov wrote: > Looks like lib/compat/vsnprintf.c is no longer useful, as it is non-C99, > and varbuf.c breaks if the implementation from lib/compat is used. Right, should be fixed now 37c754ec3d45a121aeffc9c03dba8b97b1780f40 in master. thanks,

Re: [PATCH] Refactor: make a separate function to add files

Hi! Some comments about format from the other patch apply here as well. On Sat, 2009-08-29 at 19:59:20 -0400, David Benjamin wrote: > Here's the second refactoring patch mentioned in "dpkg list-file performance". > > === > Refactor: make a separate function to add files > > Added private functi

Re: [PATCH] Refactor: split off emptying a package's file info

Hi! Some comments on the changes I made when applying it. On Sat, 2009-08-29 at 19:57:24 -0400, David Benjamin wrote: > Here's the first refactoring patch mentioned in "dpkg list-file performance". > > === > Refactor: split off emptying a package's file info > > Put it into a separate function

Re: xz-utils in sid?

Hi! On Fri, 2009-10-16 at 10:50:02 -0500, Jonathan Nieder wrote: > I had been planning to wait to upload xz-utils to sid until dpkg gets liblzma > support in experimental, but I didn’t know how long it would take then. > Probably it’s best to just bite the bullet and request a sponsor today. I do

Re: [PATCH 0/2] Rewrite of dpkg-divert to C patch series v2

On Sat, 2009-10-17 at 01:40:02 +0700, Mikhail Gusarov wrote: > Twas brillig at 02:36:43 14.10.2009 UTC+07 when dotted...@dottedmag.net did > gyre and gimble: > > *ping* > > Any comments, ACKs, NACKs? Sure, started reviewing the other day but postponed as it was taking too long. It's coming. re

Re: [PATCH 2/2] Reimplement dpkg-divert in C

Hi! For recurring issues I've commented on the first occurence only. And I've stopped reviewing in detail at some point as major parts of the code need to be rewritten anyway. On Wed, 2009-10-14 at 02:36:45 +0700, Mikhail Gusarov wrote: > Also remove dpkg-divert.pl and switch testsuite to > test

Re: [PATCH 2/2] Reimplement dpkg-divert in C

On Sat, 2009-10-17 at 14:58:55 +0700, Mikhail Gusarov wrote: > Twas brillig at 02:05:47 17.10.2009 UTC+02 when guil...@debian.org did gyre > and gimble: > GJ> Instead of inverting the list after the fact, just add to its tail > GJ> instead. OTOH I don't think this should be needed at all. > > I

Accepted dpkg 1.15.4.1 (source all amd64)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Mon, 19 Oct 2009 15:15:17 +0200 Source: dpkg Binary: dpkg dpkg-dev dselect Architecture: source amd64 all Version: 1.15.4.1 Distribution: unstable Urgency: medium Maintainer: Dpkg Developers Changed-By: Guillem Jover Description

Re: Roadmap for the 1.15.x series

Hi! On Mon, 2009-09-07 at 16:38:53 +0200, Guillem Jover wrote: > Will probably add the items from this thread to the TODO list or a > wiki page. Coalesced the items from the mailing list into: <http://wiki.debian.org/Teams/Dpkg/RoadMap> regards, guillem -- To UNSUBSCRIBE, ema

Re: [PATCH 1/6] Update promptconfaction() to also require package name

Hi! On Wed, 2009-10-14 at 21:23:04 +0200, Sean Finney wrote: > In order to provide an interface into the conffiles DB API, it's required > to know the package name that owns the conffile. Since this is a static > function and the package name is available in all places that the function > is used,

Re: [PATCH 2/6] Add doxygen comments for promptconfaction

Hi! Cleaned up the doxygen file I had around and infrastructure changes needed and pushed those. Also pushed this patch with slight changes, thanks! On Wed, 2009-10-14 at 21:23:05 +0200, Sean Finney wrote: > diff --git a/src/configure.c b/src/configure.c > index 1aa8b6a..d01a856 100644 > --- a/s

Re: [PATCH 2/2] Fix build when po4a is not available

Hi! On Sun, 2009-10-25 at 15:40:16 +0200, Felipe Contreras wrote: > diff --git a/Makefile.am b/Makefile.am > index 8fe8726..aaa7d85 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -4,6 +4,10 @@ if WITH_DSELECT >MAYBE_DSELECT = dselect > endif > > +if WITH_PO4A > + MAYBE_MAN = man > +en

Re: [PATCH v2 01/13] libdpkg: fix misspelling of __attribute__((const))

Hi! On Sat, 2009-10-24 at 17:32:56 -0500, Jonathan Nieder wrote: > gcc does not recognize __attribute__((constant)). > > Signed-off-by: Jonathan Nieder Nice catch. Pushed, thanks! regards, guillem -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of "unsubscrib

Re: Informative addendum to policy clarifying dpkg/maintainer script interface

Hi! On Wed, 2009-10-21 at 20:01:00 -0500, Manoj Srivastava wrote: > On Wed, Oct 21 2009, Frank Küster wrote: > > Thank you, that looks very useful. What I'm missing, however, is any > > reference to debconf's config script. Isn't that called by dpkg, too? > > Hmm. There are three diffe

Re: [PATCH] dpkg.1: fix a small typo

Hi! On Sat, 2009-10-24 at 17:21:49 -0500, Jonathan Nieder wrote: > Extra “be” in “can be also be”. > > Signed-off-by: Jonathan Nieder > Here’s a small patch for the dpkg manual, fixing a typo I noticed > while looking at the relationship between dpkg and dpkg-deb. The > translations should pro

Re: [PATCH 0/2] Fixes for Fedora

Hi! On Sun, 2009-10-25 at 15:40:14 +0200, Felipe Contreras wrote: > Currently dpkg doesn't build on Fedora, and these patches fix that. > > I sent these a long time ago to Guillem but it looks like they fell > through the cracks. Yeah, had them around but had forgotten about them, sorry. > Feli

Re: [PATCH 1/2] Fix build when selinux pkg-config is not available

Hi! On Sun, 2009-10-25 at 22:40:26 +0100, Tollef Fog Heen wrote: > ]] Felipe Contreras > > | -if test "x$with_selinux" = "xstatic"; then > | - dpkg_selinux_libs="-Wl,-Bstatic "$(pkg-config --static > --libs libselinux)" -Wl,-Bdynamic" > | +if test $(pkg

Re: [PATCH 6/6] implement 'm' option for conffile merging during conflict resolution

Hi! On Tue, 2009-09-29 at 12:17:02 +0200, Raphael Hertzog wrote: > On Tue, 29 Sep 2009, sean finney wrote: > > > P: pristine conffile of currently installed package > > > N: conffile of the new package to be installed > > > I: installed conffile > > > B: base conffile (last version successfully in

Re: [PATCH 3/6] Conffile database handling functions

Hi! Some of the comments from Jonathan's review apply, I'll reply to his mail instead. On Wed, 2009-10-14 at 21:23:06 +0200, Sean Finney wrote: > The layout pattern for the conffile database is: > > /conffiles/// > > Where: > > * is the standard dpkg administrative dir (i.e. /var/lib/d

Re: [PATCH 3/6] Conffile database handling functions

Hi! On Sun, 2009-10-25 at 16:46:04 -0500, Jonathan Nieder wrote: > Sean Finney wrote: > > --- /dev/null > > +++ b/src/conffiledb.c > > @@ -0,0 +1,218 @@ > [...] > > +char* > > I think the asterisk and space should be swapped here. Right. There's other trialing spaces around. > > +conffiledb_pa

Re: [PATCH] dpkg: do not activate triggers for unchanged conffiles

Hi! On Sat, 2009-11-07 at 17:06:09 -0600, Jonathan Nieder wrote: > Currently, dpkg lets interested packages know when saving a > backup (.dpkg-dist file) for an updated conffile that is not > going to used. > > This is, strictly speaking, harmless, since file triggers were > never a guarantee tha

License audit on dpkg source tree

ain to avoid a warning, but I've just removed it instead, so it becomes trivial regardless). Frank Lichtenheld Pierre Habouzit (8ad47fe: trivial, adding a 'z' to a format string). Guillem Jover So I guess getting permission from Frank and myself and reverting 6e1eb71ebf

Next upload 2009-11-15 (dpkg 1.15.5)

Hi! We've accumulated lots of changes (git describe currently says 271), including bug fixes and few new features, so it's time for a new release. There's some polishing pending, but nothing major. So let's target next sunday. regards, guillem -- To UNSUBSCRIBE, email to debian-dpkg-requ...@l

Re: Typo in statcmd.c?

Hi Christian! On Sat, 2009-11-14 at 08:15:58 +0100, Christian Perrier wrote: > static void > printversion(const struct cmdinfo *cip, const char *value) > { [...] > m_output(stdout, _(" } > The translatable string "". > > I don't dorrect this myself as I have no complete clue this to be an

Accepted dpkg 1.15.5 (source all amd64)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Tue, 17 Nov 2009 10:17:57 +0100 Source: dpkg Binary: dpkg dpkg-dev dselect Architecture: source amd64 all Version: 1.15.5 Distribution: unstable Urgency: low Maintainer: Dpkg Developers Changed-By: Guillem Jover Description: dpkg

Accepted dpkg 1.15.5.1 (source all amd64)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Tue, 17 Nov 2009 16:42:00 +0100 Source: dpkg Binary: dpkg dpkg-dev dselect Architecture: source amd64 all Version: 1.15.5.1 Distribution: unstable Urgency: low Maintainer: Dpkg Developers Changed-By: Guillem Jover Description

Re: [PATCH 3/6] Conffile database handling functions

Hi! Some of this was addressed by comments from Jonathan, specially the db atomicity issues, but commenting anyway. On Mon, 2009-11-09 at 23:26:27 +0100, sean finney wrote: > On Fri, Nov 06, 2009 at 08:48:43AM +0100, Guillem Jover wrote: > > > +/** > > > +

Re: [PATCH 2/2] Reimplement dpkg-divert in C

Hi! On Tue, 2009-10-20 at 15:00:31 +0700, Mikhail Gusarov wrote: > Twas brillig at 02:05:47 17.10.2009 UTC+02 when guil...@debian.org did gyre > and gimble: > > >> +varbufaddstr(ret, "any "); > >> + > >> +varbufaddstr(ret, "diversion of "); > >> +varbufaddstr(

Re: [PATCH 2/2] Reimplement dpkg-divert in C

Hi! On Thu, 2009-10-22 at 11:29:04 +0200, Goswin von Brederlow wrote: > Mikhail Gusarov writes: > > Is --list supposed to be only human-readable? Then we can change output > > format a bit to make it more localizable (12 similar strings like "local > > diversion of %s to %s by %s", "diversion of

Re: dpkg (>= 1.15.5) fails on make check

Hi! On Tue, 2009-11-17 at 13:09:51 -0600, Yuri Vasilevski wrote: > At gentoo we are having problems with dpkg (>= 1.15.5) versions due to > the changes introduced in the pure perl version comparison code. BTW, now that you are handling the new release, you might want to drop some stuff from your

Accepted dpkg 1.15.5.3 (source all amd64)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Fri, 27 Nov 2009 19:23:36 +0100 Source: dpkg Binary: dpkg dpkg-dev dselect Architecture: source amd64 all Version: 1.15.5.3 Distribution: unstable Urgency: low Maintainer: Dpkg Developers Changed-By: Guillem Jover Description

Re: [PATCH 3/6] Conffile database handling functions

Hi! On Fri, 2009-11-06 at 03:26:23 -0600, Jonathan Nieder wrote: > Changes from Sean’s original: > > * new PROCSAVESTATUS flag for libdpkg subproc library, to support > fork()/exec()-ing diff. Forgot to mention at the time, but already had some changes around similar in spirit, which I clea

Accepted dpkg 1.15.5.5 (source all amd64)

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Format: 1.8 Date: Tue, 22 Dec 2009 09:49:49 +0100 Source: dpkg Binary: dpkg dpkg-dev dselect Architecture: source amd64 all Version: 1.15.5.5 Distribution: unstable Urgency: low Maintainer: Dpkg Developers Changed-By: Guillem Jover Description

Re: dpkg feature implementation

Hi! On Tue, 2010-01-05 at 18:59:40 +0530, dE . wrote: > On Tue, Jan 5, 2010 at 6:32 PM, Raphael Hertzog wrote: > > You super-package is a called an APT repository on a DVDROM. Using those > > DVD is easy ("apt-cdrom add" and you're done). > > > > DVD are generated so that they contain all depende

Re: [PATCH v2 3/4] dpkg: change pass_admindir to a bool

Hi! On Sat, 2009-10-24 at 18:40:14 -0500, Jonathan Nieder wrote: > This is just for clarity. Noticed while preparing to add a > similar pass_memlimit option. > diff --git a/src/main.c b/src/main.c > index 78c34c3..ff09fa0 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -546,7 +546,7 @@ void ex

Re: [PATCH v2 02/13] libdpkg: Reduce scope of combuf[] in compress_cat

Hi! On Sat, 2009-10-24 at 17:38:57 -0500, Jonathan Nieder wrote: > Move the definition of combuf[] closer to its actual usage. This > should make it easier to factor out repeated code and saves some > stack space in cases where there is no command line argument to > compute. I just merged this w

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

Hi! On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: > If only C had templates! Without function templates, macros > like these two will have to do. > > This patch refactors the callers for zlib and libbz2 library > functions to share some code, in preparation for some small > change

Re: [PATCH v2 04/13] libdpkg: fix redundant compression error messages

Hi! On Sat, 2009-10-24 at 17:41:48 -0500, Jonathan Nieder wrote: > Avoid ohshite() except where errno is useful. This should avoid > confusing error messages like > > data: internal gzip error: read: stream error: Success > > While we're at it, drop the number of bytes read and written fr

Re: [PATCH v2 03/13] libdpkg: factor out common gzip, bzip2 code

On Sat, 2009-10-24 at 17:41:02 -0500, Jonathan Nieder wrote: > If only C had templates! Without function templates, macros > like these two will have to do. > > This patch refactors the callers for zlib and libbz2 library > functions to share some code, in preparation for some small > changes tha

Re: [PATCH v2 05/13] libdpkg: fix compress_cat to read/write to arbitrary fds

Hi! On Sat, 2009-10-24 at 17:42:52 -0500, Jonathan Nieder wrote: > The compress_cat() code had a hidden assumption that fd_in is 0 > and fd_out is 1. This is a bug waiting to happen. But luckily, > all callers do use those values, so it is harmless. > diff --git a/lib/dpkg/compression.c b/lib/d

Re: [PATCH v2 06/13] libdpkg: report read errors during (de)compression

Hi! On Sat, 2009-10-24 at 17:44:25 -0500, Jonathan Nieder wrote: > Instead of using the error handling code, failed reads are being > treated as end of file. This applies only when using zlib and > libbz2. In practice it probably has not caused problems > because I/O errors are rare, and often t

Re: [PATCH v2 07/13] libdpkg: compression: do not handle EINTR

Hi! On Sat, 2009-10-24 at 17:45:03 -0500, Jonathan Nieder wrote: > The current callers for the compression code do not install signal > handlers, so there is no occasion to test the EINTR handling. > Perhaps for this reason, since commit 7bf6e0 (add support for using > libz, 2000-12-09) when the c

Re: [PATCH v2 08/13] libdpkg: check for write errors during decompression

Hi! On Sat, 2009-10-24 at 17:46:16 -0500, Jonathan Nieder wrote: > An unnoticed write error is unlikely to cause major problems, > since the process on the other end still has a chance to notice > the mangled stream. But it is worth fixing, especially because > the writing end can give a better e

Re: [PATCH v2 09/13] libdpkg: factor out function to execute compressors

Hi! On Sat, 2009-10-24 at 17:47:01 -0500, Jonathan Nieder wrote: > gzip, bzip2, and lzma use the same command-line syntax. Factor > out a compress_cmd() function that can be used to invoke any one > of these commands. > diff --git a/lib/dpkg/compression.c b/lib/dpkg/compression.c > index f901867

Re: [PATCH v2 10/13] libdpkg: reorder internal fd_fd_filter() function arguments

Hi! On Sat, 2009-10-24 at 17:47:39 -0500, Jonathan Nieder wrote: > Put the compression options string last so it can be replaced with > printf-style format string. I applied thie one but not for the reason you wanted to use it, but to be able to pass the command arguments to it. thanks, guillem

Re: [PATCH v2 11/13] libdpkg: simplify code to calculate compression options

Hi! On Sat, 2009-10-24 at 17:48:18 -0500, Jonathan Nieder wrote: > Rather than making the reader track down the meaning of indices > into a fixed-size buffer as it is modified, calculate the > compression options all at once. > diff --git a/lib/dpkg/compression.c b/lib/dpkg/compression.c > index

Re: [PATCH v2 12/13] libdpkg: compression: move each format's code into its own function

Hi! On Sat, 2009-10-24 at 17:48:59 -0500, Jonathan Nieder wrote: > Add compress_gzip, decompress_gzip, etc functions with code from > compress_cat and decompress_cat. Instead of > > switch (type) { > case compress_type_gzip: > #ifdef WITH_ZLIB > /* decompress usin

Re: [PATCH v2 13/13] libdpkg: compression: check for output errors closing files

Hi! On Sat, 2009-10-24 at 17:49:49 -0500, Jonathan Nieder wrote: > A gzclose call has the same potential for errors as a write, > since the compressor needs to flush its buffers before closing > its output file. The same applies to BZ2_bzclose, but > unfortunately libbz2's gzio-style API does not

Re: [PATCH v2 2/2] libdpkg: compress_lzma(): decrease default compression level

Hi! On Sat, 2009-10-24 at 18:05:47 -0500, Jonathan Nieder wrote: > Set the default compression level low enough to produce packages > that require no more than 10 MiB of memory to decompress, by > using the lzma command's default compression level. > Signed-off-by: Jonathan Nieder > --- > lib/d

Re: [PATCH v2 1/2] libdpkg: let backends decide default compression level

Hi! On Sat, 2009-10-24 at 18:05:06 -0500, Jonathan Nieder wrote: > When compressing packages with gzip or bzip2, the tradeoff is > clear: a better compression ratio for a distributed package is > generally worth spending some extra time at build time. Since > better compressed packages are not mu

Re: [PATCH 2/7] Conffile database handling functions

Hi Sean! On Mon, 2009-12-14 at 08:27:32 +0100, Sean Finney wrote: > The layout pattern for the conffile database is: > > /conffiles/// While the implementation resulting from this layout seems more elegant than the previous iteration, I still think that using the layout I described in the

Re: [PATCH 6/7] Implement 'm' option for conffile merging during conflict resolution

Hi! On Mon, 2009-12-14 at 08:27:36 +0100, Sean Finney wrote: > The conflict resolution prompt has been updated with a new option for > automatic merging: > > M : attempt to automatically merge the differences > > This functions by performing a 3-way diff using the new conffile, the

Re: [PATCH 7/7] Track common ancestors of a successful conffiledb merge

Hi! On Mon, 2009-12-14 at 08:27:37 +0100, Sean Finney wrote: > When a merge is successful, store the common ancestor of the merge (the > pristine version of the conffile from the previous package version) in > a special location. While this may not have an immediate benefit, it poses > the oppurtu

Re: License audit on dpkg source tree

Hi Colin! On Thu, 2009-11-12 at 18:11:16 +0100, Guillem Jover wrote: > The remaining issues, which might need asking people around are: > * scripts/Dpkg/Vendor/Ubuntu.pm: > > Copyright © 2008 Colin Watson > > This might actually be © Canonical Ltd.? Is that the case

Re: License audit on dpkg source tree

Hi Ian! On Thu, 2009-11-12 at 18:11:16 +0100, Guillem Jover wrote: > The remaining issues, which might need asking people around are: > * lib/dpkg/utils.c: GPL-2 only > > This file started as GPL-2 only with commit a4f9322a6417e1683183ea > by Wichert Akkerman, which only in

Re: License audit on dpkg source tree

Hi Frank! On Thu, 2009-11-12 at 18:11:16 +0100, Guillem Jover wrote: > The remaining issues, which might need asking people around are: > > * lib/dpkg/showpkg.c: GPL-2 only > > Used to be GPL-2+ with all commits © by Wichert Akkerman, until > commit 6e1eb71ebffbbaca2e4bc

Removing dpkg conffile backgrounding prompt support

Hi! I'd like to know if people would strongly miss being able to background dpkg on the conffile prompt (‘Z’), instead of starting a new subshell. The latter is the default with most modern frontends (APT based). I personally find the background support annoying and confusing when one is used to

Re: [LONG] Re: "Exec format error" bugs

Hi! On Wed, 2010-01-27 at 09:15:52 +0100, Raphael Hertzog wrote: > Package: dpkg > Version: 1.15.5.6 > Severity: important > [ For debian-dpkg, see > https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/512096 for a > description of the problem, basically a configuration script is empty > /broken

Re: [PATCH v2] Fix resource leak in dpkg-deb --info

Hi! On Thu, 2010-02-18 at 03:04:47 -0600, Jonathan Nieder wrote: > “dpkg-deb -I foo.deb” leaks the file handle for the package’s > control file. Check for read errors and close the file before > it falls out of scope. > > Found by cppcheck. > > Reported-by: Raphael Geissert > Signed-off-by: Jo

Re: License audit on dpkg source tree

thanks, guillem >From 72dcd49ffb8546f35323cfc3d9ff14f2465e9ea1 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Fri, 19 Feb 2010 19:20:11 +0100 Subject: [PATCH 2/2] libdpkg: Revert license change to GPL2+ The file lib/dpkg/showpkg.c used to be GPL-2+ with all commits with copyright by Wich

Re: License audit on dpkg source tree

Hi! On Tue, 2010-02-09 at 09:29:31 +, Colin Watson wrote: > On Mon, Feb 08, 2010 at 04:13:25AM +0100, Guillem Jover wrote: > > On Thu, 2009-11-12 at 18:11:16 +0100, Guillem Jover wrote: > > > The remaining issues, which might need asking people around are: > > >

Re: Removing dpkg conffile backgrounding prompt support

Hi! On Mon, 2010-02-08 at 04:49:06 +0100, Guillem Jover wrote: > I'd like to know if people would strongly miss being able to > background dpkg on the conffile prompt (‘Z’), instead of starting a > new subshell. The latter is the default with most modern frontends > (APT based).

Re: License audit on dpkg source tree

On Fri, 2010-02-19 at 21:29:47 +, Colin Watson wrote: > I don't recall it being significant. The patch you sent is fine by me. Thanks committed. > (The same may apply to Ian's and James' contributions to this file, but > you'd have to ask them about that.) I thought about that too, but as t

Re: License audit on dpkg source tree

On Fri, 2010-02-19 at 19:47:44 +0100, Guillem Jover wrote: > Ok cool, I'll be applying tthe following patch then. This is done now. thanks, guillem -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas..

Re: [PATCH v2 2/2] libdpkg: compress_lzma(): decrease default compression level

On Tue, 2010-02-02 at 15:13:10 -0600, Jonathan Nieder wrote: > Guillem Jover wrote: > > I've not yet changed the default for the lzma compressor, but I'd like > > to set it explicitly instead of relying on the library/command, I > > guess 6 or 7 should be fine? (the

Re: [l10n:manpages] Approximate deadline?

Hi! On Tue, 2010-03-02 at 15:40:20 +0100, Omar Campagne wrote: > As part of the debian l10n spanish list, I recently took over the > maintenance of the Spanish manpages translations, which I pretend to do > for _long_ :) > > The issue is that I brought the fuzzy count down to half of what > it is

Next upload 2010-03-10 (dpkg 1.15.6)

Hi! Ok, this one has been sitting here for too long already, so let's try to target the release for the 10th, short notice but I should have sent this a week ago already, and as we are going for experimental it should be fine. Stuff I still want to get done prior to the upload: * Push the db d

Re: [PATCH] Use FIEMAP to sort .list files before scanning

Hi Morten! I applied the patch some days ago with some modifications, which is going to be part of 1.15.6 targetting experimental. Thanks for the patch! On Tue, 2009-11-03 at 16:11:46 +0100, Morten Hustveit wrote: > diff --git a/

Re: dpkg NLS language selection (patch included)

Hi! On Sat, 2009-11-21 at 04:27:38 -0600, Yuri Vasilevski wrote: > As pointed out by guillem in: > http://lists.debian.org/debian-dpkg/2009/11/msg00071.html > > Gentoo has an obsolete patch for nls support. > I changed that patch so now users can configure LINGUAS environment > variable to choose

Re: dpkg's ability to disable wide char ncurses (patch included)

Hi! On Sat, 2009-11-21 at 04:28:55 -0600, Yuri Vasilevski wrote: > As pointed out by guillem in: > http://lists.debian.org/debian-dpkg/2009/11/msg00071.html > > Gentoo has an obsolete sed substitution to disable Unicode support in > dselect. This got broken when dpkg's configure script learned ho

Re: Ubuntu dpkg 1.15.5.6ubuntu2

Hey Colin! On Thu, 2010-03-11 at 04:03:47 -, Ubuntu Merge-o-Matic wrote: > This e-mail has been sent due to an upload to Ubuntu that contains Ubuntu > changes. It contains the difference between the new version and the > previous version of the same source package in Ubuntu. > Changes: > d

Re: dpkg 1.15.6 is slow as hell

Hi! [ Colin, CCing you as I'm not sure you follow the list. ] On Fri, 12 Mar 2010 15:57:28 +, Colin Watson wrote: > I'm worried about the syncing changes though; > apparently they're *really* *really* pessimal on some systems, e.g. ext4 > with data=ordered (which considers rename() as a barri

Re: dpkg 1.15.6 is slow as hell

On Fri, 2010-03-12 at 23:04:18 +0100, Raphael Hertzog wrote: > On Fri, 12 Mar 2010, Guillem Jover wrote: > > Neither of those are good replacements, as the fsync() must be done before > > the rename(), as we want the guarantee that there's always a valid file in > >

Accepted dpkg 1.15.6 (source all amd64)

: Guillem Jover Description: dpkg - Debian package management system dpkg-dev - Debian package development tools dselect- Debian package management front-end libdpkg-dev - Debian package management static library libdpkg-perl - Dpkg perl modules Closes: 38334 60329 312206 363323 383869

Re: dpkg 1.15.6 is slow as hell

Hi! [ Got the patch few days ago, but didn't test it until today. ] On Fri, 2010-03-12 at 20:43:29 +0100, Guillem Jover wrote: > On Fri, 12 Mar 2010 15:57:28 +, Colin Watson wrote: > > I'm worried about the syncing changes though; > > apparently they're *rea

Re: dpkg 1.15.6 is slow as hell

On Sun, 2010-03-21 at 11:00:39 +, Colin Watson wrote: > On Sun, Mar 21, 2010 at 10:10:38AM +0100, Guillem Jover wrote: > > I implemented this and in my tests with linux-headers-2.6.32-4-common > > (which contains around 2500 files) on ext3 it reduced the installation > >

Accepted dpkg 1.15.6.1 (source all amd64)

: Guillem Jover Description: dpkg - Debian package management system dpkg-dev - Debian package development tools dselect- Debian package management front-end libdpkg-dev - Debian package management static library libdpkg-perl - Dpkg perl modules Closes: 570938 574097 574816 Changes

Taking over dupload under the Dpkg Developers umbrella

Hi! I recently asked Josip Rodin (and Frank Lichtenheld who never replied), whether he'd be fine with a maintainership transfer. He agreed, so this is just a notice letting the list know that I'll be folding dupload into the dpkg toolset. I'll do an initial upload fixing long-standing issues tha

Re: dpkg issue with lzma

Hi! On Sun, 2017-05-14 at 18:50:16 +0300, Igor Kozhukhov wrote: > i have often issue with my builds on SPARC similar to: > > 02:53:00.547 dpkg-deb: building package 'gcc-6-libgcj-tools' in > '../gcc-6-libgcj-tools_6.3.0-2-15_solaris-sparc.deb'. > 02:53:00.547 dpkg-deb --build debian/gcc-6-libgo

Accepted dpkg 1.18.24 (source) into unstable

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Wed, 17 May 2017 13:16:25 +0200 Source: dpkg Binary: dpkg libdpkg-dev dpkg-dev libdpkg-perl dselect Architecture: source Version: 1.18.24 Distribution: unstable Urgency: medium Maintainer: Dpkg Developers Changed-By: Guillem Jover

Re: What makes a .changes file source-only?

Hi! On Tue, 2017-05-23 at 18:17:18 +0100, Sean Whitton wrote: > (1) > > I am teaching dgit to verify whether a .changes file is source-only. > This is for a new 'push-source' subcommand. Ah, interesting question. :) IMO, in theory, a source-only .changes is primarily defined by its Architecture

Re: source-only builds and .buildinfo

Hi! [ Just a very quick reply, will go over the other mails during the week. ] On Wed, 2017-05-24 at 13:58:00 +, Ximin Luo wrote: > Also the man page for dpkg-buildpackage is out-of-date: > >6. Unless a source-only build has been requested, it runs the > buildinfo hook and calls dpkg

Hurd's fakeroot seems to break dpkg 1.18.24 testsuite

Hi! I finally got the chance to take a look at the dpkg FTBFS on Hurd (after recovering my VM! :), and it appears as if it was a fakeroot problem? Building dpkg w/o fakeroot works fine. And running the specific test w/ and w/o fakeroot shows the problem: ,--- $ apt-get source dpkg $ cd dpk

Re: What makes a .changes file source-only? [and 1 more messages]

[ Sorry for the delay, got caught in other stuff, release, real life, etc, and the thread looked like requiring some non-small blocks of time. ] Hi! On Wed, 2017-05-24 at 11:33:15 +0100, Ian Jackson wrote: > Guillem Jover writes ("Re: What makes a .changes file source-only?"):

<    5   6   7   8   9   10   11   12   13   >