Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Simon Richter
Hi, On 04.05.23 20:26, Helmut Grohne wrote: From my point of view, the ultimate goal here should be moving all files to their canonical location and thereby make aliasing effects irrelevant. Do you confirm? Yes, that would solve the problem for the current transition without any changes in

Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Timo Röhling
Hi, * Simon Richter [2023-05-05 17:59]: - it is not an error to register a diversion for an alias of an existing diversion, provided the package and target matches, this is a no-op - it is not an error to unregister a diversion for an alias of a path that has been unregistered previously, tha

Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Simon Richter
Hi, On 05.05.23 18:36, Timo Röhling wrote: - it is not an error to register a diversion for an alias of an existing diversion, provided the package and target matches, this is a no-op - it is not an error to unregister a diversion for an alias of a path that has been unregistered previously,

Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Andreas Metzler
On 2023-05-05 Simon Richter wrote: [...] > My proposal would be to put the onus on the client registering the > diversion: [...] > - packages are encouraged to register both diversions Hello, That seems to be a rather ugly user interface, ("There is dpkg-divert on Debian, but because the usrmer

[PATCH] Factor out common code for reloading database files

2023-05-05 Thread Simon Richter
--- lib/dpkg/Makefile.am| 1 + lib/dpkg/db-fsys-common.c | 84 + lib/dpkg/db-fsys-divert.c | 43 --- lib/dpkg/db-fsys-override.c | 50 +- lib/dpkg/dpkg-db.h | 13 ++ 5 files changed, 117 insertions(+)

[PATCH] Rename .gitinore -> .gitignore

2023-05-05 Thread Simon Richter
This seems to be a mistake. --- tests/dpkginst/{.gitinore => .gitignore} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/dpkginst/{.gitinore => .gitignore} (100%) diff --git a/tests/dpkginst/.gitinore b/tests/dpkginst/.gitignore similarity index 100% rename from tests/dpkginst/

[PATCH] Ignore TAGS

2023-05-05 Thread Simon Richter
This file can be optionally built, and is helpful in navigating the source tree, but should never be checked in. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index a5edb85b8..19bdd9e73 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,7 @@ .libs/

[PATCH 1/2] Make headers self-contained

2023-05-05 Thread Simon Richter
--- lib/dpkg/command.h | 2 ++ lib/dpkg/db-fsys.h | 2 ++ lib/dpkg/parsedump.h | 1 + 3 files changed, 5 insertions(+) diff --git a/lib/dpkg/command.h b/lib/dpkg/command.h index 7d2098a29..09ec92ac7 100644 --- a/lib/dpkg/command.h +++ b/lib/dpkg/command.h @@ -23,6 +23,8 @@ #include +#in

[PATCH 2/2] Mark functions in headers as inline

2023-05-05 Thread Simon Richter
--- lib/dpkg/perf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dpkg/perf.h b/lib/dpkg/perf.h index a46792a43..48e69ccde 100644 --- a/lib/dpkg/perf.h +++ b/lib/dpkg/perf.h @@ -47,7 +47,7 @@ perf_ts_sub(struct timespec *a, struct timespec *b, struct timespec *res)

[PATCH] Warn for unknown info files in packages

2023-05-05 Thread Simon Richter
Debian Policy forbids info files not mentioned in Policy, except if their names start with an underscore to flag them as non-critical. --- src/main/unpack.c | 29 + tests/t-multiarch/Makefile | 24 2 files changed, 41 insertions(+), 12

Re: [PATCH] Warn for unknown info files in packages

2023-05-05 Thread Guillem Jover
Hi! Thanks for the patches. On Sat, 2023-05-06 at 04:11:05 +0900, Simon Richter wrote: > Debian Policy forbids info files not mentioned in Policy, except if their > names start with an underscore to flag them as non-critical. I think you might be mixing up .deb ar members with entries in the con

Re: [PATCH] Rename .gitinore -> .gitignore

2023-05-05 Thread Guillem Jover
Hi! On Sat, 2023-05-06 at 04:06:02 +0900, Simon Richter wrote: > This seems to be a mistake. Queued locally, will be in my next push. Thanks, Guillem

Re: [PATCH 1/2] Make headers self-contained

2023-05-05 Thread Guillem Jover
Hi! On Sat, 2023-05-06 at 04:09:14 +0900, Simon Richter wrote: > --- > lib/dpkg/command.h | 2 ++ > lib/dpkg/db-fsys.h | 2 ++ > lib/dpkg/parsedump.h | 1 + > 3 files changed, 5 insertions(+) > diff --git a/lib/dpkg/db-fsys.h b/lib/dpkg/db-fsys.h > index cd9abefaf..3a9696aa4 100644 > --- a/l

Re: [PATCH 2/2] Mark functions in headers as inline

2023-05-05 Thread Guillem Jover
Hi! On Sat, 2023-05-06 at 04:09:15 +0900, Simon Richter wrote: > --- > lib/dpkg/perf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Queued locally, will be included in my next push. Thanks, Guillem

Re: [PATCH] Warn for unknown info files in packages

2023-05-05 Thread Alexandre Detiste
Le ven. 5 mai 2023 à 22:58, Guillem Jover a écrit : > If there's ever a need for something like this, I think that would > belong in a linter. const std::array suffixes { ".clilibs", ".conffiles", ".config", ".fortran_mod",

Re: [PATCH] Ignore TAGS

2023-05-05 Thread Guillem Jover
Hi! On Sat, 2023-05-06 at 04:07:43 +0900, Simon Richter wrote: > This file can be optionally built, and is helpful in navigating the source > tree, but should never be checked in. Hmm, I'm in general not a fan and not comfortable with adding ignore entries for local editing or development tools t

Re: Status of dpkg-shlibdeps tracking ARM object linkage ABI mismatches

2023-05-05 Thread Guillem Jover
Hi! On Wed, 2023-05-03 at 23:16:16 +0100, Wookey wrote: > On 2023-05-03 21:50 +0100, Steve McIntyre wrote: > > If we're still seeing > > issues in packages today, then maybe we might find some help from > > Wookey or Emmanuel (who should both be reading this list!). > > I am, and have noticed thi

Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Luca Boccassi
On Fri, 5 May 2023 at 17:38, Andreas Metzler wrote: > > On 2023-05-05 Simon Richter wrote: > [...] > > My proposal would be to put the onus on the client registering the > > diversion: > [...] > > - packages are encouraged to register both diversions > > Hello, > > That seems to be a rather ugly

Re: [PATCH] Warn for unknown info files in packages

2023-05-05 Thread Simon Richter
Hi, On 06.05.23 05:58, Guillem Jover wrote: Debian Policy forbids info files not mentioned in Policy, except if their names start with an underscore to flag them as non-critical. I think you might be mixing up .deb ar members with entries in the control member in the .deb? Oof, yes. -_- R

Re: DEP 17: Improve support for directory aliasing in dpkg

2023-05-05 Thread Simon Richter
Hi, On 06.05.23 07:11, Luca Boccassi wrote: - every package is forcefully canonicalized as soon as trixie is open for business You will also need to ship at least - /lib -> usr/lib (on 32 bit) - /lib64 -> usr/lib64 (on 64 bit) as a symlink either in the libc-bin package or any other Essen