Re: Review of controllib-removal branch requested

2008-01-17 Thread Raphael Hertzog
On Thu, 17 Jan 2008, Guillem Jover wrote: > > What would you suggest then ? Shall I add $substvar->set("Format", > > $changes_format) in dpkg-genchanges ? > > Sure, and also override the Format field if such substvar is present > as documented in the man page. Ok, done. > In this case I think th

[PATCH 2/2] Use new Dpkg::Checksums module

2008-01-17 Thread Frank Lichtenheld
* scripts/dpkg-genchanges.pl, scripts/dpkg-source.pl: Use new Dpkg::Checksums module. Adds new 'Checksums' field to .changes and .dsc files. Increase changes format to 1.8. --- scripts/dpkg-genchanges.pl | 43 - scripts/dpkg-source.pl | 64 +-

[PATCH 1/2] Dpkg::Checksums: New module for checksum handling in .dsc and .changes files

2008-01-17 Thread Frank Lichtenheld
--- debian/dpkg-dev.install |1 + scripts/Dpkg/Checksums.pm | 90 + scripts/Makefile.am |1 + scripts/po/POTFILES.in|1 + 4 files changed, 93 insertions(+), 0 deletions(-) create mode 100644 scripts/Dpkg/Checksums.pm diff --gi

[PATCH v2] Enhance checksum support

2008-01-17 Thread Frank Lichtenheld
This is my new version of the patch, incorporating Raphael's suggestions. Note that the feature is enabled by default now (since it doesn't break any backwards compatibility anymore). Gruesse, Frank -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble

Re: [PATCH] Integrated dpkg-parsechangelog processing into Dpkg::Changelog::parse_changelog()

2008-01-17 Thread Frank Lichtenheld
On Wed, Jan 16, 2008 at 02:11:38PM +0100, Raphael Hertzog wrote: > +The parsing itself is done by an external program (either in > +/usr/local/lib/dpkg/parsechangelog, /usr/lib/dpkg/parsechangelog > +or in $opt{libdir}). That program is named according to the format > +that it's able to parse. By d

Re: [PATCH] dpkg-genchanges: some code refactoring to simplify the code

2008-01-17 Thread Frank Lichtenheld
On Wed, Jan 16, 2008 at 02:11:40PM +0100, Raphael Hertzog wrote: > +# Scan control info of all binary packages unless > +# we have a source only upload > +my @pkg; > +push @pkg, $control->get_packages() unless is_sourceonly; That is a behavioural change, right? Up to now, dpkg-genchanges includes

Re: [PATCH] dpkg-genchanges: Enhance logic to decide if we include orig tarballs

2008-01-17 Thread Frank Lichtenheld
On Wed, Jan 16, 2008 at 02:11:39PM +0100, Raphael Hertzog wrote: > @@ -189,7 +189,11 @@ my $changelog = parse_changelog(%options); > delete $options{"since"}; > $options{"count"} = 1; > $options{"offset"} = 1; > -my $prev_changelog = parse_changelog(%options); > +my ($prev_changelog, $bad_parser

Re: [PATCH] Integrated dpkg-parsechangelog processing into Dpkg::Changelog::parse_changelog()

2008-01-17 Thread Raphael Hertzog
New patches are attached. On Thu, 17 Jan 2008, Frank Lichtenheld wrote: > Two misleading points here: > 1) $opt{libdir} is search first before the default directories, that > isn't clear from the sentence. > 2) The changelog format can also be autodetected from the changelog > file. Ok fixed: Th

Re: dpkg: error while cleaning up

2008-01-17 Thread Guillem Jover
Hi, On Mon, 2007-11-05 at 17:12:19 +0100, BRIAND, Michel M wrote: > Le lundi 05 novembre 2007 à 15:20 +0100, BRIAND, Michel M a écrit : > > I've built dpkg on Solaris, to use it as a normal user (not-root). > > I keep having some troubles with this message during installation > > of hand-made pac