Re: Preliminary review of dpkg-genbuildinfo

2015-05-19 Thread Jérémy Bobbio
Guillem Jover: > On Mon, 2015-04-27 at 15:09:36 +0200, Guillem Jover wrote: > > In any case, given this, your initial change does make sense, but I > > think it's in the wrong place. I've instead modified Dpkg::Dist::Files > > to always sort the files list, so that any other program parsing that >

Re: Preliminary review of dpkg-genbuildinfo

2015-05-19 Thread Guillem Jover
Hi! On Mon, 2015-04-27 at 15:09:36 +0200, Guillem Jover wrote: > In any case, given this, your initial change does make sense, but I > think it's in the wrong place. I've instead modified Dpkg::Dist::Files > to always sort the files list, so that any other program parsing that > file will automati

Re: Preliminary review of dpkg-genbuildinfo

2015-04-27 Thread Cyril Brulebois
Cyril Brulebois (2015-04-27): > I think you may want to additional patch scripts/Dpkg/Checksums.pm and > possibly scripts/Dpkg/Source/Package.pm; you may otherwise get a sorted > list under Files, but not under Checksums-*? The attached patch seems to work OK with tasksel and its kinda huge list

Re: Preliminary review of dpkg-genbuildinfo

2015-04-27 Thread Cyril Brulebois
Guillem Jover (2015-04-27): > Yes! Parallel builds, which I confirmed you are using from the logs, > and I guess I assumed you where not using. > > In any case, given this, your initial change does make sense, but I > think it's in the wrong place. I've instead modified Dpkg::Dist::Files > to alw

Re: Preliminary review of dpkg-genbuildinfo

2015-04-27 Thread Guillem Jover
Hi! On Mon, 2015-04-27 at 14:14:57 +0200, Jérémy Bobbio wrote: > Jérémy Bobbio: > > > > +foreach my $file (sort $dist->get_files()) { > > > > > > Why the sort, the function is supposed to preserve the same insertion > > > order. > > > > Now I think I remember what was happening. In case of paral

Re: Preliminary review of dpkg-genbuildinfo

2015-04-27 Thread Cyril Brulebois
Jérémy Bobbio (2015-04-27): > Now this happened again on vim. The order of files in the .changes is > not stable: > https://reproducible.debian.net/dbd/unstable/amd64/vim_7.4.712-1.debbindiff.html > > The full build log is available at: > https://jenkins.debian.net/job/reproducible_builder_zeta/6

Re: Preliminary review of dpkg-genbuildinfo

2015-04-27 Thread Jérémy Bobbio
Jérémy Bobbio: > > > +foreach my $file (sort $dist->get_files()) { > > > > Why the sort, the function is supposed to preserve the same insertion > > order. > > Now I think I remember what was happening. In case of parallel builds, > it might be possible that files get added to debian/files in dif