Re: Bug #583585 dpkg-maintscript-helper

2012-02-08 Thread Gianluca Ciccarelli
Hi Matthijs, Thanks for your comments. On 2012/02/08 11:00AM, Matthijs Kooijman wrote: >Hi Gianluca, > >I stumbled upon your patch trying to accomplish the same thing in my own >package (but I guess I'll just postpone my changes until >dpkg-maintscript-helper can take care of all the details for

Re: Bug #583585 dpkg-maintscript-helper

2012-02-08 Thread Matthijs Kooijman
Hi Gianluca, I stumbled upon your patch trying to accomplish the same thing in my own package (but I guess I'll just postpone my changes until dpkg-maintscript-helper can take care of all the details for me) and have some minor comments on the patch. I can't comment on the actual working of the pa

Re: Bug #583585 dpkg-maintscript-helper

2012-01-16 Thread Raphael Hertzog
Hello Gianluca, On Sun, 15 Jan 2012, Gianluca Ciccarelli wrote: > I've tried to follow the suggestions Raphael gave me in the previous > mail, and produced a new patch (indents as an 8-space-wide tab, please > tell me if I got this right). The spacing looks sane this time. > I also created an in

Re: Bug #583585 dpkg-maintscript-helper

2012-01-15 Thread Gianluca Ciccarelli
Hello folks, I've tried to follow the suggestions Raphael gave me in the previous mail, and produced a new patch (indents as an 8-space-wide tab, please tell me if I got this right). I also created an initial test within pkg-tests, that I've called t-convert-dir-to-symlink-upgrade. It doesn't cov

Re: Bug #583585 dpkg-maintscript-helper

2012-01-03 Thread Raphael Hertzog
Hi, On Tue, 03 Jan 2012, Gianluca Ciccarelli wrote: > >Good idea, what would be even better is to write immediately a > >(non-regression) test-case to ensure that the code you wrote work as > >expected and keeps doing it in the future. > > I'm trying to prepare the test case for my modifications

Re: Bug #583585 dpkg-maintscript-helper

2012-01-03 Thread Gianluca Ciccarelli
Hi, And thanks for the feedback, it's really useful. I'm working on it. In the meanwhile, I have a question: On 2011/12/29 10:26AM, Raphael Hertzog wrote: [...] >On Wed, 28 Dec 2011, Gianluca Ciccarelli wrote: >> I thought it was a good idea to share with you the patch for the >> first >> case fo

Re: Bug #583585 dpkg-maintscript-helper

2011-12-29 Thread Raphael Hertzog
Hello, On Wed, 28 Dec 2011, Gianluca Ciccarelli wrote: > I thought it was a good idea to share with you the patch for the first > case for feedback, before going on. Good idea, what would be even better is to write immediately a (non-regression) test-case to ensure that the code you wrote work as

Re: Bug #583585 dpkg-maintscript-helper

2011-12-28 Thread Gianluca Ciccarelli
On 2011/12/15 05:12PM, Raphael Hertzog wrote: [...] >> In the preinst script, "upgrade" command, I'd invoke the helper as >> above, and it will result in something like (as per Raphael's >> suggestions): >> 1) # Ensure ownership of $dir by the package >> 2) mv "$dir" "$dir".dpkg_bak >> >> In posti

Re: Bug #583585 dpkg-maintscript-helper

2011-12-15 Thread Raphael Hertzog
Hello, On Thu, 15 Dec 2011, Gianluca Ciccarelli wrote: > I've read dpkg-maintscript-helper's man page. We want some commands in > the script, invoked by the maintainer scripts always as: > dpkg-maintscript-helper \ > -- "$@" > > that executes differently according to the value of the variable

Re: Bug #583585 dpkg-maintscript-helper

2011-12-15 Thread Gianluca Ciccarelli
Hello dpkg-ers, Thanks for the comments so far, they were really useful. I start to see some light. I report on my ideas to let you know that I'm working on it, and to get some feedback, if possible. On 2011/12/07 08:05AM, Raphael Hertzog wrote: [...] >Basically you must ensure that the director

Re: Bug #583585 dpkg-maintscript-helper

2011-12-06 Thread Raphael Hertzog
Hello, On Tue, 06 Dec 2011, Gianluca Ciccarelli wrote: > >1/ replacing a directory with a symlink > > > > v1 has /foo/bar as directory > > v2 has /foo/bar as symlink > > > [...] > > Now I have a problem :) I interpret your notation as: before, we have a > directory /foo/bar; after, we have a

Re: Bug #583585 dpkg-maintscript-helper

2011-12-06 Thread Jean-Christophe Dubacq
On 06/12/2011 22:19, Gianluca Ciccarelli wrote: > Thank you Jean-Christophe, > > So let me see if I got it. We want all the files in /foo/bar to be > reachable by a symlink at the same hierarchy level of /foo/bar, named, > say, `foobar'. This link is such that, if I do `ls foobar', it returns th

Re: Bug #583585 dpkg-maintscript-helper

2011-12-06 Thread Gianluca Ciccarelli
On 2011/12/06 09:32PM, Jean-Christophe Dubacq wrote: >On 06/12/2011 21:17, Gianluca Ciccarelli wrote: >> Hello Raphael, and hello world, >> >> On 2011/12/05 12:08PM, Raphael Hertzog wrote: >> [...] >>> You have to deal with multiple cases: >>> >>> 1/ replacing a directory with a symlink >>> >>>

Re: Bug #583585 dpkg-maintscript-helper

2011-12-06 Thread Jean-Christophe Dubacq
On 06/12/2011 21:17, Gianluca Ciccarelli wrote: > Hello Raphael, and hello world, > > On 2011/12/05 12:08PM, Raphael Hertzog wrote: > [...] >> >> You have to deal with multiple cases: >> >> 1/ replacing a directory with a symlink >> >> v1 has /foo/bar as directory >> v2 has /foo/bar as symlink

Re: Bug #583585 dpkg-maintscript-helper

2011-12-06 Thread Gianluca Ciccarelli
Hello Raphael, and hello world, On 2011/12/05 12:08PM, Raphael Hertzog wrote: [...] > >You have to deal with multiple cases: > >1/ replacing a directory with a symlink > > v1 has /foo/bar as directory > v2 has /foo/bar as symlink > [...] Now I have a problem :) I interpret your notation as: b

Re: Bug #583585 dpkg-maintscript-helper

2011-12-05 Thread Raphael Hertzog
Hello, On Mon, 05 Dec 2011, Gianluca Ciccarelli wrote: > My name is Gianluca and I'm willing to contribute to the dpkg package > maintenance and (eventually) development, so I'm following Raphael > Hertzog's suggestions and looking into bugs that seem a good starting > point. Great! > I found bu

Bug #583585 dpkg-maintscript-helper

2011-12-05 Thread Gianluca Ciccarelli
Hi all, My name is Gianluca and I'm willing to contribute to the dpkg package maintenance and (eventually) development, so I'm following Raphael Hertzog's suggestions and looking into bugs that seem a good starting point. I found bug #583585, and I guessed it was a good idea to tell everyone that