Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode - PLEASE REVIEW

2014-11-11 Thread Steve McIntyre
Current patches attached here. I was totally thrown in testing by #768788 - some of my tests on installed EFI systems were failing, due to the broken GUID on the ESP. Yay! I've merged things forward and I'm ready to push these changes. Please review one last time? -- Steve McIntyre, Cambridge,

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode - PLEASE REVIEW

2014-10-01 Thread Steve McIntyre
On Thu, Oct 02, 2014 at 01:51:25AM +0100, Ben Hutchings wrote: >On Thu, 2014-10-02 at 00:29 +0100, Steve McIntyre wrote: >> From: Steve McIntyre >> Date: Thu, 2 Oct 2014 00:01:28 +0100 >> Subject: [PATCH] Recognise the new ignore_uefi flag from partman-efi >[...] >> --- a/src/system/efi.c >> +++ b

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode - PLEASE REVIEW

2014-10-01 Thread Ben Hutchings
On Thu, 2014-10-02 at 00:29 +0100, Steve McIntyre wrote: > From: Steve McIntyre > Date: Thu, 2 Oct 2014 00:01:28 +0100 > Subject: [PATCH] Recognise the new ignore_uefi flag from partman-efi [...] > --- a/src/system/efi.c > +++ b/src/system/efi.c > @@ -28,7 +28,14 @@ int di_system_is_efi(void) > {

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode - PLEASE REVIEW

2014-10-01 Thread Steve McIntyre
Hang fire - one test just failed. :-( On Thu, Oct 02, 2014 at 12:29:40AM +0100, Steve McIntyre wrote: >Control: tag -1 +patch > >On Wed, Oct 01, 2014 at 02:43:53AM +0100, Steve McIntyre wrote: >>On Mon, Sep 29, 2014 at 03:34:17PM +0100, Steve McIntyre wrote: >>>On Sun, Sep 28, 2014 at 08:46:41PM +

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode - PLEASE REVIEW

2014-10-01 Thread Steve McIntyre
Control: tag -1 +patch On Wed, Oct 01, 2014 at 02:43:53AM +0100, Steve McIntyre wrote: >On Mon, Sep 29, 2014 at 03:34:17PM +0100, Steve McIntyre wrote: >>On Sun, Sep 28, 2014 at 08:46:41PM +0100, Steve McIntyre wrote: >>>On Sun, Sep 28, 2014 at 07:50:38PM +0100, Colin Watson wrote: On Sun, Sep

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-30 Thread Steve McIntyre
On Mon, Sep 29, 2014 at 03:34:17PM +0100, Steve McIntyre wrote: >On Sun, Sep 28, 2014 at 08:46:41PM +0100, Steve McIntyre wrote: >>On Sun, Sep 28, 2014 at 07:50:38PM +0100, Colin Watson wrote: >>>On Sun, Sep 28, 2014 at 06:14:30PM +0100, Steve McIntyre wrote: That sounds better to me too, assu

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-29 Thread Steve McIntyre
On Sun, Sep 28, 2014 at 08:46:41PM +0100, Steve McIntyre wrote: >On Sun, Sep 28, 2014 at 07:50:38PM +0100, Colin Watson wrote: >>On Sun, Sep 28, 2014 at 06:14:30PM +0100, Steve McIntyre wrote: >>> That sounds better to me too, assuming we can sensibly do a question >>> at that point. Is that allowe

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Steve McIntyre
On Sun, Sep 28, 2014 at 07:50:38PM +0100, Colin Watson wrote: >On Sun, Sep 28, 2014 at 06:14:30PM +0100, Steve McIntyre wrote: >> That sounds better to me too, assuming we can sensibly do a question >> at that point. Is that allowed? I honestly don't know... :-/ > >While isinstallable scripts can t

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Colin Watson
On Sun, Sep 28, 2014 at 06:14:30PM +0100, Steve McIntyre wrote: > That sounds better to me too, assuming we can sensibly do a question > at that point. Is that allowed? I honestly don't know... :-/ While isinstallable scripts can talk to debconf, they should not ask questions, as main-menu will ru

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Ian Campbell
On Sun, 2014-09-28 at 18:14 +0100, Steve McIntyre wrote: > On Sun, Sep 28, 2014 at 06:02:12PM +0100, Ian Campbell wrote: > >I was thinking more along the lines of a yes/no question which would > >either cause partman-efi.isinstallable to fail or not. Allowing > >selection between the "wants to conv

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Steve McIntyre
On Sun, Sep 28, 2014 at 06:02:12PM +0100, Ian Campbell wrote: >On Sun, 2014-09-28 at 18:54 +0200, Wouter Verhelst wrote: >> On Sun, Sep 28, 2014 at 10:26:20AM +0100, Steve McIntyre wrote: >> > On Sun, Sep 28, 2014 at 08:48:11AM +0200, Wouter Verhelst wrote: >> > >On Sun, Sep 28, 2014 at 02:28:06AM

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Ian Campbell
On Sun, 2014-09-28 at 18:54 +0200, Wouter Verhelst wrote: > On Sun, Sep 28, 2014 at 10:26:20AM +0100, Steve McIntyre wrote: > > On Sun, Sep 28, 2014 at 08:48:11AM +0200, Wouter Verhelst wrote: > > >On Sun, Sep 28, 2014 at 02:28:06AM +0100, Steve McIntyre wrote: > > >> If the user wants to cont

Re: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Wouter Verhelst
On Sun, Sep 28, 2014 at 10:26:20AM +0100, Steve McIntyre wrote: > On Sun, Sep 28, 2014 at 08:48:11AM +0200, Wouter Verhelst wrote: > >On Sun, Sep 28, 2014 at 02:28:06AM +0100, Steve McIntyre wrote: > >> If the user wants to continue, we could even suggest blanking the > >> partition table

Re: Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Ian Campbell
On Sun, 2014-09-28 at 10:26 +0100, Steve McIntyre wrote: > On Sun, Sep 28, 2014 at 08:48:11AM +0200, Wouter Verhelst wrote: > >On Sun, Sep 28, 2014 at 02:28:06AM +0100, Steve McIntyre wrote: > >> If the user wants to continue, we could even suggest blanking the > >> partition table(s) and

Re: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-28 Thread Steve McIntyre
On Sun, Sep 28, 2014 at 08:48:11AM +0200, Wouter Verhelst wrote: >On Sun, Sep 28, 2014 at 02:28:06AM +0100, Steve McIntyre wrote: >> If the user wants to continue, we could even suggest blanking the >> partition table(s) and starting again with GPT, but I don't think >> we currently

Re: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-27 Thread Wouter Verhelst
On Sun, Sep 28, 2014 at 02:28:06AM +0100, Steve McIntyre wrote: > I'm not 100% sure that partman-efi is the right package for the bug > report, but it's as good as any. So, it's way past time to fix this > particular bug. After a fair amount of playing with systems like this > and discussing with f

Re: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-27 Thread Steve McIntyre
On Sun, Sep 28, 2014 at 02:02:53AM +0100, Steve McIntyre wrote: >Package: partman-efi >Version: 47 >Severity: important >Tags: d-i > >Ad originally described in [1], but no bug was ever filed to >match. #695048 is related, I think. Time to file a bug about this to >help track work to fix it... > >W

Bug#763127: UEFI corner case - installer booted in UEFI mode, existing system in BIOS mode

2014-09-27 Thread Steve McIntyre
Package: partman-efi Version: 47 Severity: important Tags: d-i Ad originally described in [1], but no bug was ever filed to match. #695048 is related, I think. Time to file a bug about this to help track work to fix it... We have a machine with both UEFI and BIOS-mode boot available, with an exis