Bug#868486: diffoscope often fails to detect APKs

2017-07-25 Thread Ximin Luo
Hans-Christoph Steiner: > > The APK format is a ZIP file that always includes the files > AndroidManifest.xml and classes.dex. Then it also always > has a JAR signature (i.e. META-INF/). It does not have the > JAR magic number CAFEBABE in it. > Right, I can get that much by looking it up on wi

Bug#868486: diffoscope often fails to detect APKs

2017-07-24 Thread Hans-Christoph Steiner
The APK format is a ZIP file that always includes the files AndroidManifest.xml and classes.dex. Then it also always has a JAR signature (i.e. META-INF/). It does not have the JAR magic number CAFEBABE in it.

Bug#868486: diffoscope often fails to detect APKs

2017-07-24 Thread Ximin Luo
Control: tags -1 - pending Hans-Christoph Steiner: > [..] > > I'd like a way to force the file type in diffoscope. We are calling it > from a build process, so we already know all files are going to be APKs. > Also, I tried to get this added to libfile, but upstream is not willing > to accept

Bug#868486: diffoscope often fails to detect APKs

2017-07-18 Thread Chris Lamb
tags 868486 + pending thanks Fixed in Git: https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=c14424059b7836d59da8e18c260e34dc797cb02e Thanks for providing the testcases! :) Regards, -- ,''`. : :' : Chris Lamb, Debian Project Leader `. `'` la..

Bug#868486: diffoscope often fails to detect APKs

2017-07-15 Thread Hans-Christoph Steiner
Package: diffoscope Version: 83 APKs are basically a ZIP file with a JAR signature, but not necessarily the CAFEBABE byte sequence that marks a JAR. This means that comparing APKs with diffoscope often results in a straight binary diff, which is useless. Here's one example: https://verification