Bug#859953: some improvements for /lib/cryptsetup/cryptdisks.functions

2018-06-17 Thread Guilhem Moulin
Control: tag -1 pending Hi, Thanks for the review! Refactoring cryptdisks.functions has been on our TODO list for quite a while, and we finally got around to it. All the points you mentioned are addressed, AFAICT: https://salsa.debian.org/cryptsetup-team/cryptsetup/blob/master/debian/cryp

Bug#859953: some improvements for /lib/cryptsetup/cryptdisks.functions

2017-04-09 Thread dimas
Package: cryptsetup Version: 2:1.7.3-3 hello! i've reviewed subj script and have some improvements/corrections for it 0. line 7 TABFILE=${TABFILE-"/etc/crypttab"} should be TABFILE=${TABFILE:-"/etc/crypttab"} (note the colon), see man dash - Parameter Expansion 1. lines 12-13 this seems useless,