Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-02-05 Thread Mattia Rizzolo
On Mon, Feb 05, 2018 at 02:27:50PM -0700, Sean Whitton wrote: > I would suggest that we require the user to pass/set > --build-products-dir rather than adding all the parsing code to dgit. FTR, I agree. Especially if you make it configurable instead of forcing a cli flag. -- regards,

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-02-05 Thread Sean Whitton
Hello, On Mon, Feb 05 2018, Ian Jackson wrote: > Sean Whitton writes ("Re: Bug#844125: dgit: Built-in support for >pbuilder [and 1 more messages]"): >> I haven't yet read your older mail where you came to the conclusion >> that it would be necessary for dgit to p

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-02-05 Thread Ian Jackson
Sean Whitton writes ("Re: Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]"): > I haven't yet read your older mail where you came to the conclusion that > it would be necessary for dgit to parse pbuilder's config, but we should > be really sure it

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-02-04 Thread Sean Whitton
Hello, On Mon, Jan 29 2018, Ian Jackson wrote: > Mattia Rizzolo writes ("Bug#844125: dgit: Built-in support for >pbuilder [and 1 more messages]"): >> [lots of explanation] > > Thanks, that is very helpful information. Indeed. Many thanks. >> Anyway, isn&

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Mattia Rizzolo
On Mon, Jan 29, 2018 at 02:05:07PM +, Ian Jackson wrote: > Ah. But AIUI source-only upload *must not* be accompanied by an > _amd64.buildinfo (with the same name, anyway) because that *clashes* > with the buildd's .buildinfo. dak handles them correctly whenever there is not a queue in front o

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Ian Jackson
Mattia Rizzolo writes ("Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]"): > On Mon, Jan 29, 2018 at 01:09:25PM +, Ian Jackson wrote: > > I'm not sure why anyone would use SOURCE_ONLY_CHANGES=yes so I don't > > know why and how dgit sh

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Mattia Rizzolo
On Mon, Jan 29, 2018 at 01:09:25PM +, Ian Jackson wrote: > > Obviously that doesn't include people with SOURCE_ONLY_CHANGES=yes, > > as those when doing a -b build would get a _amd64.changes with only > > .debs and a _source.changes with only source. > > I'm not sure why anyone would use SOUR

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Ian Jackson
Mattia Rizzolo writes ("Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]"): > [lots of explanation] Thanks, that is very helpful information. > Anyway, isn't this discussion kind of moot? I understood that for > reasons you're thinking of speci

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Mattia Rizzolo
On Mon, Jan 29, 2018 at 12:09:04PM +, Ian Jackson wrote: > Right. But if you're not doing a -1 upload the .orig is somewhere > else ? In that case the .orig is simply discarded after doing the build instead of being copied out of the chroot. > Right, but is the normal workflow to have the .o

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Ian Jackson
Mattia Rizzolo writes ("Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]"): > In the --build-products-dir (which pbuilder calls --buildresult) there > is going to be whatever is referenced by the *.changes files (note the > plural, if we are generating m

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Mattia Rizzolo
On Mon, Jan 29, 2018 at 11:29:25AM +, Ian Jackson wrote: > > 2. I am not sure where origs should go when --build-products-dir is > > being used. Is it pbuilder practice to put them in the build produts > > dir or in .. ? In the --build-products-dir (which pbuilder calls --buildresult) there i

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-29 Thread Ian Jackson
Ian Jackson writes ("Re: Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]"): > 1. I think many pbuilder users expect to be able to set a build > products directory. Currently there are bugs in dgit's > --build-products-dir option; probably, too many

Bug#844125: dgit: Built-in support for pbuilder [and 1 more messages]

2018-01-28 Thread Ian Jackson
Sean Whitton writes ("Bug#844125: dgit: Built-in support for pbuilder"): > I'm thinking of working on this. I think it will be straightforward. Cool. > The only possibility for complexity is if I've missed something about > how pbuilder works. Would the following work: > > 1. user runs `dgit