Bug#843000: refind: fails to install on NVMe

2020-02-17 Thread Rod Smith
On Mon, 14 Nov 2016 14:04:41 -0800 Tianon Gravi wrote: > On 4 November 2016 at 02:34, Bjørn Mork wrote: > > + /bin/efibootmgr -c -l '\EFI\refind\refind_x64.efi' -L 'rEFInd Boot > > Manager' -d /dev/nvme0n1 -p 1 > > I just tested this on a friend's machine which has NVMe and uses > rEFInd and we

Bug#843000: refind: fails to install on NVMe

2016-11-17 Thread Roderick W. Smith
On 11/14/2016 05:04 PM, Tianon Gravi wrote: > On 4 November 2016 at 02:34, Bjørn Mork wrote: >> + /bin/efibootmgr -c -l '\EFI\refind\refind_x64.efi' -L 'rEFInd Boot >> Manager' -d /dev/nvme0n1 -p 1 > > I just tested this on a friend's machine which has NVMe and uses > rEFInd and we had to change

Bug#843000: refind: fails to install on NVMe

2016-11-14 Thread Tianon Gravi
On 4 November 2016 at 02:34, Bjørn Mork wrote: > + /bin/efibootmgr -c -l '\EFI\refind\refind_x64.efi' -L 'rEFInd Boot Manager' > -d /dev/nvme0n1 -p 1 I just tested this on a friend's machine which has NVMe and uses rEFInd and we had to change the "-d" value to be "/dev/nvme0n1p1" (full path to t

Bug#843000: refind: fails to install on NVMe

2016-11-04 Thread Bjørn Mork
Rod Smith writes: > On 11/03/2016 01:29 PM, Tianon Gravi wrote: >> On 3 November 2016 at 10:28, Tianon Gravi wrote: >>> On 3 November 2016 at 10:19, Rod Smith wrote: Note, however, that I have no NVMe or similar devices on which to test. The new code does the right thing on my /dev/sd?

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Tianon Gravi
On 3 November 2016 at 11:45, Rod Smith wrote: > Oops; I cut-and-pasted the wrong stuff from my test script to the > refind-install script. I've added another commit -- e7e393 -- so that's > three commits in total Looks like that did the trick! Now getting "1" instead of "p1". ♥, - Tianon

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Rod Smith
On 11/03/2016 02:16 PM, Tianon Gravi wrote: > On 3 November 2016 at 11:03, Rod Smith wrote: >> Good question. I guess it depends on what efibootmgr wants, since that's >> where the variable is used. The efibootmgr man page implies it wants a >> number, so I've committed another change -- applying

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Tianon Gravi
On 3 November 2016 at 11:16, Tianon Gravi wrote: > PartNum=${InstallPart#$InstallDisk} > +PartNum=${InstallPart#p} Err, I meant: PartNum=${InstallPart#$InstallDisk} +PartNum=${PartNum#p} ♥, - Tianon 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Tianon Gravi
On 3 November 2016 at 11:03, Rod Smith wrote: > Good question. I guess it depends on what efibootmgr wants, since that's > where the variable is used. The efibootmgr man page implies it wants a > number, so I've committed another change -- applying both 2a6f68 and > bdf9ca from my git repository s

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Rod Smith
On 11/03/2016 01:29 PM, Tianon Gravi wrote: > On 3 November 2016 at 10:28, Tianon Gravi wrote: >> On 3 November 2016 at 10:19, Rod Smith wrote: >>> Note, however, that I have no NVMe or similar devices on which to test. >>> The new code does the right thing on my /dev/sd? devices, and I think it

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Tianon Gravi
On 3 November 2016 at 10:28, Tianon Gravi wrote: > On 3 November 2016 at 10:19, Rod Smith wrote: >> Note, however, that I have no NVMe or similar devices on which to test. >> The new code does the right thing on my /dev/sd? devices, and I think it >> SHOULD work on more exotic devices. > > I don'

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Tianon Gravi
On 3 November 2016 at 10:19, Rod Smith wrote: > Note, however, that I have no NVMe or similar devices on which to test. > The new code does the right thing on my /dev/sd? devices, and I think it > SHOULD work on more exotic devices. I don't personally have an NVMe system I can test the script as-

Bug#843000: refind: fails to install on NVMe

2016-11-03 Thread Rod Smith
Thanks for the bug report. I've fixed this upstream in commit 2a6f68: https://sourceforge.net/p/refind/code/commit_browser Note, however, that I have no NVMe or similar devices on which to test. The new code does the right thing on my /dev/sd? devices, and I think it SHOULD work on more exotic de

Bug#843000: refind: fails to install on NVMe

2016-11-02 Thread Bjørn Mork
Package: refind Version: 0.10.4-1 Severity: important -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 The refind-install script makes bogus assumptions: InstallDisk=`grep "$InstallDir" /etc/mtab | cut -d " " -f 1 | cut -c 1-8` PartNum=`grep "$InstallDir" /etc/mtab | cut -d " " -f 1 |