Bug#832941: RFS: 4pane (debian: to exclusive)

2016-12-24 Thread Paul Wise
On Sun, Dec 25, 2016 at 3:53 AM, David Hart wrote: > However will it be accepted into debian? The project is moribund: apart from a > single commit 3 years ago, it's been unmaintained for 6 years. That was > supposed to give time for a rewrite which hasn't happened. I might be a good idea for 4pa

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-12-24 Thread Sean Whitton
Hello David, On Sat, Dec 24, 2016 at 07:53:09PM +, David Hart wrote: > Many thanks for the offer. I don't mind packaging Bakefile, and it shouldn't > be > difficult to do. > > However will it be accepted into debian? The project is moribund: apart from a > single commit 3 years ago, it's bee

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-12-24 Thread David Hart
Dear Sean, >Thank you for revising your work in light of my review. We're too late >to get 4Pane into stretch, so there's no longer any time pressure on >this review process. I know. It missed the jessie freeze too ;) >So I'd like to reply regarding only the Bakefile >issue, since that's the bi

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-12-24 Thread Sean Whitton
Dear David, Thank you for revising your work in light of my review. We're too late to get 4Pane into stretch, so there's no longer any time pressure on this review process. So I'd like to reply regarding only the Bakefile issue, since that's the biggest blocker to uploading this. Once we've res

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-12-23 Thread David Hart
Dear Sean, Many thanks for your further input. >Here's another review, based on your 4pane-debian-dir repo. >Must-fixes >1. At least one of the files added by AddExtraM4Files.patch isn't accounted >for in d/copyright. //snip >9. Lots of files in .build/ are not accounted for in d/copyright. Than

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-11-24 Thread Sean Whitton
Dear David, Here's another review, based on your 4pane-debian-dir repo. Must-fixes -- 1. At least one of the files added by AddExtraM4Files.patch isn't accounted for in d/copyright. 2. Vcs-* still point to the upstream code, not your 4pane-debian-dir repo. 3. d/copyright says that only

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-11-20 Thread David Hart
Dear Sean, >1. Why do you have a folder full of patches, when you are the upstream >author of 4Pane? Have they been applied upstream, but there hasn't been >a release of 4Pane recently? Yes. They are implementing your previous suggestions. There hasn't been a recent 4Pane release and, unless nee

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-11-19 Thread Sean Whitton
Dear David, 1. Why do you have a folder full of patches, when you are the upstream author of 4Pane? Have they been applied upstream, but there hasn't been a release of 4Pane recently? DEP-3 has a patch header to indicate that they have been merged upstream, if this is indeed the case. 2. I see

Bug#832941: RFS: 4pane (debian: to exclusive)

2016-11-14 Thread David Hart
Dear Sean, >> >I'd recommend including the upstream code in the git repository, too. >> >But what you've done is fine -- thanks! >> >> I've now added that too. > >I think you misunderstood what I was suggesting. I'm certain I did ;) >You've committed the >tarball to git, but I meant adding the u