Bug#825487: [Piuparts-devel] Bug#825487: Bug#825487: Patch

2017-01-10 Thread Sean Whitton
Hello Holger, On Wed, Jan 11, 2017 at 12:40:49AM +, Holger Levsen wrote: > I've finally applied your patch to git and deployed on piuparts.d.o. > Thanks for your work on this and your patience! Thank you for your review! > In May 2016 you said that this would prevent elpa-ebib from being > t

Bug#825487: [Piuparts-devel] Bug#825487: Bug#825487: Patch

2017-01-10 Thread Holger Levsen
control: tag -1 +pending Hi Sean, On Sat, Dec 24, 2016 at 10:47:58PM +, Sean Whitton wrote: > New patch attached. I've finally applied your patch to git and deployed on piuparts.d.o. Thanks for your work on this and your patience! In May 2016 you said that this would prevent elpa-ebib from

Bug#825487: [Piuparts-devel] Bug#825487: Bug#825487: Patch

2016-12-24 Thread Sean Whitton
control: tag -1 +patch Hello Holger, Andreas, New patch attached. I'm not totally sure about the version number comparison code, because LooseVersion doesn't understand things like "~beta2". However, it gives the right answer for the versions of apt in all current Debian suites. -- Sean Whitt

Bug#825487: [Piuparts-devel] Bug#825487: Bug#825487: Patch

2016-12-02 Thread Holger Levsen
Hi Sean, thanks for your patience and for summarizing your questions. On Sat, Oct 01, 2016 at 05:00:59PM -0700, Sean Whitton wrote: > Since the questions I asked were quite fundamental to the patch, I'd > prefer to ask some feedback on them before I dive into the code again. > > 1. --allow-downg

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-10-01 Thread Sean Whitton
Hello Holger, On Sat, Sep 24, 2016 at 10:30:34AM +, Holger Levsen wrote: > it would have been easier to me (and thus probably resulted in a sooner > reply…) if you had presented those questions again, instead of making us > wade through half answered stuff… > > Huhmf :/ While I could see part

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-09-24 Thread Holger Levsen
control: retitle -1 piuparts: should use `apt-get install ./foo.deb` rather than `dpkg -i ./foo.deb && apt-get install -yf` Hi Sean, I'm sorry about the delay in getting back on this… On Sat, Jul 23, 2016 at 09:13:20AM -0700, Sean Whitton wrote: > It would be great if you were able to respond t

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-07-23 Thread Sean Whitton
Dear Holger, Andreas, It would be great if you were able to respond to my questions in the message below, so I can prepare a new version of the patch. Thanks. Sean On Fri, Jun 03, 2016 at 08:29:30AM +0900, Sean Whitton wrote: > Hello, > > Thanks for the feedback :) > > On Thu, Jun 02, 2016 at

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-06-02 Thread Sean Whitton
Hello, Thanks for the feedback :) On Thu, Jun 02, 2016 at 08:42:56AM +, Holger Levsen wrote: > On Thu, Jun 02, 2016 at 04:50:31PM +0900, Sean Whitton wrote: > > +# we need to pass --allow-downgrades because installing a > > +# deb with the same version as the version c

Bug#825487: [Piuparts-devel] Bug#825487: Bug#825487: Patch

2016-06-02 Thread Holger Levsen
control: tags -1 - patch thanks On Thu, Jun 02, 2016 at 11:02:59AM +0200, Andreas Beckmann wrote: > (or better better a test whether we have apt >= 1.2 (is that the correct > version?)) that seems sensible indeed… > disregarding the list_installed_files bits (or maybe continue using dpkg > for t

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-06-02 Thread Andreas Beckmann
Hi Sean, thanks for your patch! > +tmp_files = [os.path.join("./tmp", name) for name in tmp_files] Can't we use just an absolute path? /tmp? > +apt_get_install = ["apt-get", "-y", "--allow-downgrades"] NACK as said by Holger. Testing reinstalls this way does not seem to

Bug#825487: [Piuparts-devel] Bug#825487: Patch

2016-06-02 Thread Holger Levsen
Hi Sean, thanks for your patch! On Thu, Jun 02, 2016 at 04:50:31PM +0900, Sean Whitton wrote: > +# we need to pass --allow-downgrades because installing a > +# deb with the same version as the version currently > +# installed (i.e. reinstalling it) counts as a

Bug#825487: Patch

2016-06-02 Thread Sean Whitton
control: tag -1 +patch This seems to work! -- Sean Whitton From f83804fe15c5aea48d3e1cea78123e1fe5939ff5 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Thu, 2 Jun 2016 16:48:19 +0900 Subject: [PATCH] use apt-get install ./foo.deb --- debian/changelog | 6 -- piuparts.py | 29