On 3 November 2015 at 20:19, Felipe Sateler wrote:
> On 3 November 2015 at 18:15, Bryan Quigley
> wrote:
>>> You need to remove the -- "$@" part: it is being added twice to the
>>> resulting scripts (check debian/nvi/DEBIAN/{pre,post}* after a build):
>>>
>>> dpkg-maintscript-helper rm_conffile
On 3 November 2015 at 18:15, Bryan Quigley wrote:
>> You need to remove the -- "$@" part: it is being added twice to the
>> resulting scripts (check debian/nvi/DEBIAN/{pre,post}* after a build):
>>
>> dpkg-maintscript-helper rm_conffile /etc/init.d/nviboot 1.81.6-12 nvi
>> -- "$@" -- "$@"
>>
>
>>>
> You need to remove the -- "$@" part: it is being added twice to the
> resulting scripts (check debian/nvi/DEBIAN/{pre,post}* after a build):
>
> dpkg-maintscript-helper rm_conffile /etc/init.d/nviboot 1.81.6-12 nvi
> -- "$@" -- "$@"
>
>>> Thanks for your work!
>> Thanks for all your work reviewi
On 3 November 2015 at 17:48, Bryan Quigley wrote:
> On Mon, Nov 2, 2015 at 5:24 PM, Felipe Sateler wrote:
> ++if [ -n "$sessions_found" ] ; then
> ++echo "done."
> ++else
> ++echo "none found."
> ++fi
This is a behavior change: previously the recover
On Mon, Nov 2, 2015 at 5:24 PM, Felipe Sateler wrote:
++if [ -n "$sessions_found" ] ; then
++echo "done."
++else
++echo "none found."
++fi
>>>
>>> This is a behavior change: previously the recover script would not
>>> print any output. Maybe this should not
On 2 Nov 2015 18:58, "Bryan Quigley" wrote:
>
> Thanks for the review Felipe
>
> > Why did you preserve runlevel S? I don't think this really belongs in
> > recovery mode.
> Changed
>
> >> +;;
> >> + stop|restart|reload|force-reload)
> >
> > restart (and force-reload?) should probably re-run
On 2 November 2015 at 18:57, Bryan Quigley wrote:
> Thanks for the review Felipe
>
>> Why did you preserve runlevel S? I don't think this really belongs in
>> recovery mode.
> Changed
>
>>> +;;
>>> + stop|restart|reload|force-reload)
>>
>> restart (and force-reload?) should probably re-run th
Thanks for the review Felipe
> Why did you preserve runlevel S? I don't think this really belongs in
> recovery mode.
Changed
>> +;;
>> + stop|restart|reload|force-reload)
>
> restart (and force-reload?) should probably re-run the recovery script.
Changed.
>> +Description=To recover nvi e
Hi Bryan,
On Thu, 17 Sep 2015 11:45:25 -0400 Bryan Quigley
wrote:
> Here is a debdiff that implements a systemd unit.
>
> (This is the first unit I've written, so review definitely needed)
Thanks for the patch. I agree with your previous comment that this
should maybe be a cronjob instead of boo
Here is a debdiff that implements a systemd unit.
(This is the first unit I've written, so review definitely needed)
nvi_1.81.6-12.debdiff
Description: Binary data
10 matches
Mail list logo
