Bug#753755: Patch proposal to fix the race condition

2015-07-15 Thread Dariusz Gadomski
On Tue, Jun 30, 2015 at 10:19:08PM +0200, Guus Sliepen wrote: > Yes I did, and it doesn't work correctly yet. So I'm planning to make it > so when it tries to ifup a VLAN interface, it first tries to lock the > physical interface it wants to create a VLAN on. I haven't finished that > yet, but I'll

Bug#753755: Patch proposal to fix the race condition

2015-07-03 Thread Dariusz Gadomski
On Tue, Jun 30, 2015 at 10:19:08PM +0200, Guus Sliepen wrote: > Yes I did, and it doesn't work correctly yet. So I'm planning to make it > so when it tries to ifup a VLAN interface, it first tries to lock the > physical interface it wants to create a VLAN on. I haven't finished that > yet, but I'll

Bug#753755: Patch proposal to fix the race condition

2015-06-30 Thread Guus Sliepen
On Tue, Jun 30, 2015 at 05:49:11PM +0200, Dariusz Gadomski wrote: > On Tue, Jun 16, 2015 at 03:40:04PM +0200, Guus Sliepen wrote: > > Hm, looking at the code I don't think so, since a VLAN interface still > > runs "ip link set dev bondX up", which may mess with the > > if-pre-up.d/ifenslave script

Bug#753755: Patch proposal to fix the race condition

2015-06-30 Thread Dariusz Gadomski
Hello Guus! On Tue, Jun 16, 2015 at 03:40:04PM +0200, Guus Sliepen wrote: > Hm, looking at the code I don't think so, since a VLAN interface still > runs "ip link set dev bondX up", which may mess with the > if-pre-up.d/ifenslave script. I'll do some tests with the concurrency > branch and VLANs o

Bug#753755: Patch proposal to fix the race condition

2015-06-17 Thread Dariusz Gadomski
On Tue, Jun 16, 2015 at 03:40:04PM +0200, Guus Sliepen wrote: > But is it just ifup running in parallel, or is there also an > ifup -a running at the same time? According to my observations there is a single ifup call for each interface and additionally there is a ifup -a called from another scr

Bug#753755: Patch proposal to fix the race condition

2015-06-16 Thread Guus Sliepen
On Tue, Jun 16, 2015 at 02:29:26PM +0200, Dariusz Gadomski wrote: > The outline for this change is the way the interfaces are handled by > upstart in Ubuntu. They are all brought up in parallel by independent > processes, so there was a need for a universal mechanism to ensure the > proper order o

Bug#753755: Patch proposal to fix the race condition

2015-06-16 Thread Dariusz Gadomski
On Tue, Jun 09, 2015 at 06:27:37PM +0200, Guus Sliepen wrote: > Hi, I just adopted ifupdown from Andrew Shadura. Incidentally I'm also > the ifenslave maintainer :) Hello Guus, good luck with maintaining ifupdown :) The outline for this change is the way the interfaces are handled by upstart in U

Bug#753755: Patch proposal to fix the race condition

2015-06-09 Thread Guus Sliepen
Hi, I just adopted ifupdown from Andrew Shadura. Incidentally I'm also the ifenslave maintainer :) On Tue, Jun 09, 2015 at 04:35:00PM +0200, Dariusz Gadomski wrote: > After some discussions with Rafael and users affected by the race > condition I have prepared a patch solving the problem by intro

Bug#753755: Patch proposal to fix the race condition

2015-06-09 Thread Dariusz Gadomski
Hello Maintainers! After some discussions with Rafael and users affected by the race condition I have prepared a patch solving the problem by introducing a new stanza to the interfaces file: allow-group-X-Y where: X is the group index Y is the level in the hierarchy This stanza allows to group i