Hi,
so is the latest patch by Abou acceptable? If the logic's ok I guess the
committer could also fix up the last bunch of coding style issues.
Kind regards
Philipp Kern
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact list
On Sun, 2013-01-06 at 23:32 +0100, Bastian Blank wrote:
> On Thu, Dec 27, 2012 at 10:08:07PM +0100, Abou Al Montacir wrote:
> > + if (r == XZ_STREAM_END) {
> > + /* Eat padding. Stream never starts with zeros, and
> > padding is 32 aligned */
> > + whi
On Thu, Dec 27, 2012 at 10:08:07PM +0100, Abou Al Montacir wrote:
> + if (r == XZ_STREAM_END) {
> + /* Eat padding. Stream never starts with zeros, and
> padding is 32 aligned */
> + while ((iobuf.in_pos < iobuf.in_size) &&
> (iobuf.in[iobuf.in_
On Sun, Jan 06, 2013 at 09:40:00PM +0100, Bastian Blank wrote:
This was the wrong mail.
Bastian
--
Oblivion together does not frighten me, beloved.
-- Thalassa (in Anne Mulhall's body), "Return to Tomorrow",
stardate 4770.3.
--
To UNSUBSCRIBE, email to debi
On Sat, Dec 22, 2012 at 12:03:31AM +0100, Abou Al Montacir wrote:
> --- busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch
> 1970-01-01 01:00:00.0 +0100
> +++ busybox-1.20.0/debian/patches/fix-unxz-with-multiple-streams.patch
> 2012-12-21 19:23:12.0 +
Hi,
On Thu, Dec 27, 2012 at 10:08:07PM +0100, Abou Al Montacir wrote:
> I've fixed my patch and think that know it should really be conformant.
> I also attached some short samples to be tested. One of them only should
> fail to decode.
could somebody please review that patch and if suitable uplo
On Thu, 2012-12-27 at 08:38 -0800, Jonathan Nieder wrote:
> Abou Al Montacir wrote:
>
> > Hover, I assume we can save this extra code as soon as we don't loose
> > data.
>
> That's fine with me. All you'd need to do is error out if there is
> anything after the first stream. That would make it
Abou Al Montacir wrote:
> Hover, I assume we can save this extra code as soon as we don't loose
> data.
That's fine with me. All you'd need to do is error out if there is
anything after the first stream. That would make it a conformant
decoder and prevent silent data loss, though it would mean
On Mon, 2012-12-24 at 17:11 -0800, Jonathan Nieder wrote:
> Abou Al Montacir wrote:
> > On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
>
> >> What happens if a stream ends at a buffer boundary, followed by
> >> padding? Or if padding doesn't fit in the buffer, for that
> >> matter?
> [
Abou Al Montacir wrote:
> On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
>> What happens if a stream ends at a buffer boundary, followed by
>> padding? Or if padding doesn't fit in the buffer, for that
>> matter?
[...]
> Please find attached new debdiff with fix of above mentioned issu
On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
>
> What happens if a stream ends at a buffer boundary, followed by
> padding? Or if padding doesn't fit in the buffer, for that
> matter?
>
> Hope that helps,
Please find attached new debdiff with fix of above mentioned issues.
Cheers,
On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:
> What happens if a stream ends at a buffer boundary, followed by
> padding? Or if padding doesn't fit in the buffer, for that
> matter?
That make very low probability but could happe indeed. I will upload a
new patch which fixes this case
Abou Al Montacir wrote:
> +--- busybox-1.20.0~/archival/libarchive/decompress_unxz.c2012-12-20
> 21:51:04.0 +0100
> busybox-1.20.0/archival/libarchive/decompress_unxz.c 2012-12-20
> 21:49:11.0 +0100
> +@@ -87,7 +87,17 @@ unpack_xz_stream(transformer_aux_data_t *aux,
On Fri, 2012-12-21 at 14:34 +0100, Abou Al Montacir wrote:
> > Add stream padding as specified in the spec.
> I'll provide a new patch for eating zeros and fixing issue pointed by Michael
Please find attached new patch handling padding and fixing issue
highlighted by Michael,
Cheers,
diff -Nru b
On Fri, 2012-12-21 at 14:24 +0100, Bastian Blank wrote:
> On Fri, Dec 21, 2012 at 02:06:31PM +0100, Abou Al Montacir wrote:
> > On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:
> > > On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
> > > > Can you please test the attached pa
On Fri, 2012-12-21 at 17:13 +0400, Michael Tokarev wrote:
> 21.12.2012 17:06, Abou Al Montacir wrote:
> > On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:
> >> On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
> >>> Can you please test the attached patch
> >>
> >> How does it
On Fri, Dec 21, 2012 at 02:06:31PM +0100, Abou Al Montacir wrote:
> On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:
> > On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
> > > Can you please test the attached patch
> > How does it implement stream padding?
> As it is impleme
21.12.2012 17:06, Abou Al Montacir wrote:
On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:
On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
Can you please test the attached patch
How does it implement stream padding?
Hi Bastian,
As it is implemented, it will iterate
On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:
> On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
> > Can you please test the attached patch
>
> How does it implement stream padding?
Hi Bastian,
As it is implemented, it will iterate until end of stream, but I did not
te
On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:
> Can you please test the attached patch
How does it implement stream padding?
Bastian
--
What kind of love is that? Not to be loved; never to have shown love.
-- Commissioner Nancy Hedford, "Metamorphosis",
Hi,
Can you please test the attached patch
Cheers,
diff -Nru busybox-1.20.0/debian/changelog busybox-1.20.0/debian/changelog
--- busybox-1.20.0/debian/changelog 2012-09-20 08:32:55.0 +0200
+++ busybox-1.20.0/debian/changelog 2012-12-20 22:04:02.0 +0100
@@ -1,3 +1,9 @@
+busybox (1:
On Thu, Dec 20, 2012 at 12:22:12PM +0400, Michael Tokarev wrote:
> This is a grave bug in busybox. Grave because it causes silent
> data loss - valid (according to the format specs) input is
> decompressed only partially.
The documentation say: "SHOULD support files that have more than one
Stream
Control: forwarded -1 https://bugs.busybox.net/show_bug.cgi?id=5804
Control: reassign -1 src:busybox 1:1.17.1-8
Control: affects -1 pxz
Control: retitle -1 busybox unxz silently fails to decompress multiple
compressed streams on input
Control: severity -1 grave
This is a grave bug in busybox. Gr
Hi,
Holger Levsen wrote:
> the typo3 orig.tar.gz as it is in squeeze or sid is sufficient: gunzip it and
> compress it with pxz and "voila"...
*builds pxz, tests*
Luckily the cause seems to be simple. pxz works by concatenating
whole XZ files, but for simplicity busybox unxz ignores everythin
Hi Jonathan,
On Sonntag, 2. September 2012, Jonathan Nieder wrote:
> Thanks! Could you please attach such an example archive, or upload it
> somewhere and send a link if it is too large?
the typo3 orig.tar.gz as it is in squeeze or sid is sufficient: gunzip it and
compress it with pxz and "voil
Hi Holger,
Holger Levsen wrote:
> pxz (somtimes) produces archives broken for busybox's unxz, while they
> decompress fine with unxz from xz-utils packges. I noticed when trying
> to uncompress pxz compressed initramfs files, while this is an universal
> way to reproduce it:
Thanks! Could you
Hi Bastian,
On Sonntag, 2. September 2012, Bastian Blank wrote:
> On Sun, Sep 02, 2012 at 03:18:40PM +0200, Holger Levsen wrote:
> > ~/t$ busybox unxz typo3-src_4.5.19+dfsg1.orig.tar.xz
> > ~/t$ tar tf typo3-src_4.5.19+dfsg1.orig.tar 1>/dev/null
> > tar: Unexpected EOF in archive
> > tar: Error is
On Sun, Sep 02, 2012 at 03:18:40PM +0200, Holger Levsen wrote:
> ~/t$ busybox unxz typo3-src_4.5.19+dfsg1.orig.tar.xz
> ~/t$ tar tf typo3-src_4.5.19+dfsg1.orig.tar 1>/dev/null
> tar: Unexpected EOF in archive
> tar: Error is not recoverable: exiting now
Where does busybox choke here? I only see ta
package: pxz
version: 4.999.9~beta+git537418b-1
severity: important
affects: busybox
x-debbugs-cc:
debian-b...@lists.debian.org,xz-ut...@packages.debian.org,jn...@users.sourceforge.net
Hi,
pxz (somtimes) produces archives broken for busybox's unxz, while they
decompress fine with unxz from xz-u
29 matches
Mail list logo
