Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-05-14 Thread Jonathan Nieder
Michael Tokarev wrote: > If I were upstream I'd reject this approach. Oh, sorry for the lack of clarity. I'm personally fine with leaving these warnings unaddressed. (Debian doesn't use busybox's selinux support as far as I can tell.) My only goal was to convey that there are at least three op

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-05-14 Thread Michael Tokarev
On 14.05.2012 23:13, Jonathan Nieder wrote: > Michael Tokarev wrote: > >> That's the constructs like this: >> >> bb_error_msg_and_die(bb_msg_memory_exhausted); >> >> where bb_msg_memory_exhausted is declared as extern char *. >> This is a poor-man implementation of internal constant >> string fo

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-05-14 Thread Jonathan Nieder
Michael Tokarev wrote: > That's the constructs like this: > > bb_error_msg_and_die(bb_msg_memory_exhausted); > > where bb_msg_memory_exhausted is declared as extern char *. > This is a poor-man implementation of internal constant > string folding done by gcc for years. How about this patch? It

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-05-02 Thread Michael Tokarev
02.05.2012 16:39, Bastian Blank пишет: > On Mon, Apr 30, 2012 at 11:00:38PM -0700, Steve Langasek wrote: >> On Tue, May 01, 2012 at 09:53:14AM +0400, Michael Tokarev wrote: >>> Why do you filter this -W option? >> Well, it causes a build failure if you don't. ;) I inherited this from the >> previo

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-05-02 Thread Bastian Blank
On Mon, Apr 30, 2012 at 11:00:38PM -0700, Steve Langasek wrote: > On Tue, May 01, 2012 at 09:53:14AM +0400, Michael Tokarev wrote: > > Why do you filter this -W option? > Well, it causes a build failure if you don't. ;) I inherited this from the > previous Ubuntu changes, so I haven't fully review

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-04-30 Thread Steve Langasek
On Tue, May 01, 2012 at 09:53:14AM +0400, Michael Tokarev wrote: > On 01.05.2012 08:23, Steve Langasek wrote: > > +CFLAGS := $(filter-out -Werror=format-security,$(CFLAGS)) > Why do you filter this -W option? Well, it causes a build failure if you don't. ;) I inherited this from the previous Ubu

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-04-30 Thread Michael Tokarev
On 01.05.2012 08:23, Steve Langasek wrote: > +CFLAGS := $(filter-out -Werror=format-security,$(CFLAGS)) Why do you filter this -W option? Also, I'd rather use EXTRA_CFLAGS not CFLAGS alone, or the other way around (allowing EXTRA_CFLAGS), but I'll have to check. Thanks! /mjt -- To UNSUBSCRI

Bug#670993: busybox: Please use dpkg-buildflags for hardening support

2012-04-30 Thread Steve Langasek
Package: busybox Version: 1:1.19.3-7 Severity: important Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu quantal ubuntu-patch Hi guys, In merging the latest version of the busybox package into Ubuntu for the newly-opened quantal, I noticed that the package was not applying