Bug#634799: grub2 claims grub.cfg is out of partition

2012-04-22 Thread Samuel Thibault
Hello, Vladimir 'φ-coder/phcoder' Serbinenko, le Thu 21 Jul 2011 00:33:27 +0200, a écrit : > On 21.07.2011 00:28, Samuel Thibault wrote: > > The attached patch fixes it. Shall I commit it to upstream grub2? > > > Go ahead The patch has been commited upstream, as attached, months ago, could it be

Bug#634799: grub2 claims grub.cfg is out of partition

2011-07-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 21.07.2011 00:54, Samuel Thibault wrote: > Vladimir 'φ-coder/phcoder' Serbinenko, le Thu 21 Jul 2011 00:31:51 +0200, a > écrit : >> On 21.07.2011 00:28, Samuel Thibault wrote: >>> tags 634799 + upstream patch >>> thanks >>> >>> Hello, >>> >> I've looked into it and arrived to the similar conclu

Bug#634799: grub2 claims grub.cfg is out of partition

2011-07-20 Thread Samuel Thibault
Vladimir 'φ-coder/phcoder' Serbinenko, le Thu 21 Jul 2011 00:31:51 +0200, a écrit : > On 21.07.2011 00:28, Samuel Thibault wrote: > > tags 634799 + upstream patch > > thanks > > > > Hello, > > > I've looked into it and arrived to the similar conclusion that the > grub.cfg.new with inode = 0 is the

Bug#634799: grub2 claims grub.cfg is out of partition

2011-07-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 21.07.2011 00:28, Samuel Thibault wrote: > The attached patch fixes it. Shall I commit it to upstream grub2? > Go ahead > Samuel > patch > > > === modified file 'grub-core/fs/ext2.c' > --- grub-core/fs/ext2.c 2011-04-11 21:01:51 + > +++ grub-core/fs/ext2.c 2011-07-20 22:20:43 +00

Bug#634799: grub2 claims grub.cfg is out of partition

2011-07-20 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 21.07.2011 00:28, Samuel Thibault wrote: > tags 634799 + upstream patch > thanks > > Hello, > I've looked into it and arrived to the similar conclusion that the grub.cfg.new with inode = 0 is the problem. However I think no such entries should be there in the first place. In any case GRUB must b

Bug#634799: grub2 claims grub.cfg is out of partition

2011-07-20 Thread Samuel Thibault
tags 634799 + upstream patch thanks Hello, Digging a bit with the issue, it seems grub2 does not ignore entries with inode == 0 while it should. See linux' ext2_readdir() in fs/ext2/dir.c doing it: for ( ;(char*)de <= limit; de = ext2_next_entry(de)) { if