Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-31 Thread Keith Packard
On Thu, 31 Dec 2009 18:44:18 +0100, Cyril Brulebois wrote: > In the meanwhile, defoma was uploaded with the debhelper-like syntax > (as quoted above). In my previous mail[1], you can scratch “until new > defoma is installed on all architectures” since it's arch: all. ;) Ok, I've adopted the same

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-31 Thread Cyril Brulebois
Keith Packard (31/12/2009): > Check out the 'bash' manual -- set -e explicitly excludes precisely > this case from causing early termination of the script: > […] Alrighty. I must confess I'm not really keen on checking what happens in the various shells, but that seems to be true under dash as we

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-31 Thread Keith Packard
On Thu, 31 Dec 2009 09:03:59 +0100, Cyril Brulebois wrote: > Keith Packard (30/12/2009): > > > I'm about to QA-upload defoma with this change in the various > > > debhelper-files/* files, but I wanted to open this bugreport for > > > reference. > > Fortunately, I didn't do so, that wouldn't have

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-31 Thread Cyril Brulebois
Cyril Brulebois (31/12/2009): > Current/common practice within debhelper seems to be: > | if [ -x "`which foo 2>/dev/null`" ]; then… > > I think I'm going to upload with such a change once I'm up (for > real, not vaguely opening eyes). Hi again, I've just checked that fontconfig 2.8.0-1 built a

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-31 Thread Cyril Brulebois
Keith Packard (30/12/2009): > > I'm about to QA-upload defoma with this change in the various > > debhelper-files/* files, but I wanted to open this bugreport for > > reference. Fortunately, I didn't do so, that wouldn't have helped (yay for sleeping before uploading :)). > Here's a patch which

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-30 Thread Keith Packard
On Thu, 31 Dec 2009 01:06:48 +0100, Cyril Brulebois wrote: > Package: defoma > Version: 0.11.10-3 > Severity: grave > Justification: Fucks up fontconfig (at least), then buildds. > > Hi, > > dh_installdefoma leads to this kind of code in maintainer scripts: > test -x `which foo` && foo bar baz

Bug#563121: dh_installdefoma leads to buggy maintainer scripts

2009-12-30 Thread Cyril Brulebois
Package: defoma Version: 0.11.10-3 Severity: grave Justification: Fucks up fontconfig (at least), then buildds. Hi, dh_installdefoma leads to this kind of code in maintainer scripts: test -x `which foo` && foo bar baz The trick being that if foo isn't found by which, “foo bar baz” gets execute