Bug#512911: playback-seek-relative seeks bad at the song start/end

2009-03-23 Thread John Lindgren
On Mon, 2009-03-23 at 11:58 +0100, Sandro Tosi wrote: > ... Where is the > problem in fixing the audtool code? > > If there's a bug, I tend to fix it, not to remove completely the > functionality where the bug is. Yes, you're right. It should be fixed. But I think that's going to require more tha

Bug#512911: playback-seek-relative seeks bad at the song start/end

2009-03-23 Thread Sandro Tosi
Hi John, thanks for the analysis. On Mon, Mar 16, 2009 at 02:51, John Lindgren wrote: > Basically, a relative seek function would have to be implemented within > the main Audacious process to work correctly, probably right in the > decoder loop of each input plugin. This would be possible to do,

Bug#512911: playback-seek-relative seeks bad at the song start/end

2009-03-15 Thread John Lindgren
The code that currently implements playback-seek-relative is this, from audtool_handlers_playback.c, lines 138-142: oldtime = audacious_remote_get_output_time(dbus_proxy); diff = atoi(argv[1]) * 1000; newtime = oldtime + diff; audacious_remote_jump_to_time(dbus_pro