Bug#352626: my opinion on this

2006-02-22 Thread Julian Gilbey
On Wed, Feb 22, 2006 at 01:22:47PM -0500, Joey Hess wrote: > It's true that DH_ALWAYS_EXCLUDE can affect builds in ways that are > unreproducible on other machines, but only in two cases: > > 1. If the upstream tarball contains something that is excluded by > DH_ALWAYS_EXCLUDE. For example,

Bug#352626: my opinion on this

2006-02-22 Thread Joey Hess
Julian Gilbey wrote: > That makes some sense. But having DH_ALWAYS_EXCLUDE set in the > environment is surely even worse than having it in the rules file, > because it can affect builds in ways which are unreproducible on other > machines. See bug#352273 for an example of this. Um, I don't reall

Bug#352626: my opinion on this

2006-02-22 Thread Julian Gilbey
On Tue, Feb 21, 2006 at 07:54:13PM -0500, Joey Hess wrote: > The tarball issue is solved by passing -i -I.svn to dpkg-buildpackage. > There is never any reason to set DH_ALWAYS_EXCLUDE in the rules file and > it would not be good to do so. That makes some sense. But having DH_ALWAYS_EXCLUDE set i

Bug#352626: my opinion on this

2006-02-21 Thread Joey Hess
The tarball issue is solved by passing -i -I.svn to dpkg-buildpackage. There is never any reason to set DH_ALWAYS_EXCLUDE in the rules file and it would not be good to do so. I'v built every package I've released for years out of svn like this with no problems (including devscripts, although I don