Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Santiago Vila
close 1077054 3.0-15 thanks Thank you both for the double check. Thanks.

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Paul Marquess
> Ah, no, that's OK then -- apologies for the noise. No worries Adam. Just double checking that there isn't a hidden gotcha with mbstowcs that I'm not aware of >

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Adam Sampson
On Sat, Apr 26, 2025 at 06:40:11PM +0200, Santiago Vila wrote: >> Looking at the source I see that the code does an initial dummy >> conversion to get wsize [...] >> Is there a path through that that means mbstowcs will not create a >> wsize output buffer? Ah, no, that's OK then -- apologies for t

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Santiago Vila
Ok, let's see if we can be all in the loop at the same time :-) Everybody please always include Paul (author), Adam (bug submitter), the bug address (for archival purposes) and myself (who prefer to receive duplicates than risking not to receive a copy at all) in the To or Cc fields. This is the

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Paul Marquess
th through that that means mbstowcs will not create a wsize output buffer? Paul -Original Message- From: Santiago Vila Sent: 26 April 2025 15:53 To: Paul Marquess Subject: Fwd: Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE Hi. I was afraid that the a

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Santiago Vila
reopen 1077054 thanks Thanks for your reply. I'll ask the authors.

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-26 Thread Adam Sampson
Hi Santiago, On Fri, Apr 25, 2025 at 08:25:38PM +0200, Santiago Vila wrote: > In theory, this was already fixed by Fedora here: > > @@ -3502,7 +3502,7 @@ >if ((wc_string = (wchar_t *)malloc((wsize + 1) * sizeof(wchar_t))) == > NULL) { > ZIPERR(ZE_MEM, "local_to_wide_string"); >} > -

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2025-04-25 Thread Santiago Vila
El 25/7/24 a las 17:12, Adam Sampson escribió: If zip 3.0-14 is built with _FORTIFY_SOURCE=3 (GCC 14.1, glibc 2.40), this can happen when compressing a file with non-ASCII characters in its UTF-8 name: $ echo -n "There’s a Baby in the House.flac" | od -c 000 T h e r e 342 200 231

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2024-07-25 Thread Santiago Vila
Hi. Thanks a lot for the report. El 25/7/24 a las 17:12, Adam Sampson escribió: If zip 3.0-14 is built with _FORTIFY_SOURCE=3 (GCC 14.1, glibc 2.40), Ok, to be sure: Would using "experimental" (for glibc) and modifying CPPFLAGS in debian/rules be enough to reproduce this? (gcc-14 is already t

Bug#1077054: Charset conversion fails when zip is built with _FORTIFY_SOURCE

2024-07-25 Thread Adam Sampson
Package: zip Version: 3.0-14 Severity: minor Tags: patch If zip 3.0-14 is built with _FORTIFY_SOURCE=3 (GCC 14.1, glibc 2.40), this can happen when compressing a file with non-ASCII characters in its UTF-8 name: $ echo -n "There’s a Baby in the House.flac" | od -c 000 T h e r e 342