Re: [RFC] Alternative solution (was: r50470 - trunk/packages/kbd-chooser/debian)

2007-12-18 Thread Frans Pop
On Tuesday 18 December 2007, Joey Hess wrote: > Frans Pop wrote: > > On Monday 17 December 2007, Joey Hess wrote: > > > Frans Pop wrote: > > > > Because a dpkg-reconfigure needs to ask the question even if a > > > > keymap is installed. > > > > > > if [ ! -e /etc/whatever_file ] || [ "$1" = reconfi

Re: [RFC] Alternative solution (was: r50470 - trunk/packages/kbd-chooser/debian)

2007-12-18 Thread Joey Hess
Frans Pop wrote: > As I was extremely tired last night I decided to quit the discussion until > after some sleep. > > On Monday 17 December 2007, Joey Hess wrote: > > Frans Pop wrote: > > > Because a dpkg-reconfigure needs to ask the question even if a keymap > > > is installed. > > > > if [ ! -e

[RFC] Alternative solution (was: r50470 - trunk/packages/kbd-chooser/debian)

2007-12-18 Thread Frans Pop
As I was extremely tired last night I decided to quit the discussion until after some sleep. On Monday 17 December 2007, Joey Hess wrote: > Frans Pop wrote: > > Because a dpkg-reconfigure needs to ask the question even if a keymap > > is installed. > > if [ ! -e /etc/whatever_file ] || [ "$1" = r

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread peter green
But it would affect an 'aptitude reinstall' of the package. As the user did not _himself_ ask for a seen flag to be set here (as in the case of preseeding [2]), I did not consider this a very nice solution. The user has effectively seen the question, they were just asked it by d-i instead o

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Otavio Salvador
Joey Hess <[EMAIL PROTECTED]> writes: > Frans Pop wrote: >> We are talking about a debconf setting in the _installed_ system after all, >> and one that should _only_ be valid while D-I is running. > > preseeding console-data/keymap/policy seen should work ok. If > console-common is later dpkg-rec

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Joey Hess
Frans Pop wrote: > Because a dpkg-reconfigure needs to ask the question even if a keymap is > installed. if [ ! -e /etc/whatever_file ] || [ "$1" = reconfigure ]; then # ask question fi > I decided on /tmp as the file really _is_ a temporary file: exists only for > the duration of the i

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Frans Pop
On Monday 17 December 2007, Joey Hess wrote: > If the keymap has already been installed earlier in the installation, > why can't console-* notice that there is a keymap installed, and skip > asking about it? Why do we need a separate way to communicate this to > console-* at all? Because a dpkg-re

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Joey Hess
Frans Pop wrote: > We are talking about a debconf setting in the _installed_ system after all, > and one that should _only_ be valid while D-I is running. preseeding console-data/keymap/policy seen should work ok. If console-common is later dpkg-reconfigured, the seen flag will be ignored. > Ple

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Joey Hess
Frans Pop wrote: > See #456029 and especially #452331. Both BRs were discussed on the list and > I did ask for alternative suggestions. > I had hoped for a reaction from either you or Colin to my proposal. However, > Christian did not leave very much time before applying my patch which > probabl

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Frans Pop
On Monday 17 December 2007, Otavio Salvador wrote: > A debconf setting would be more interesting from my POV. I did consider that but came to the conclusion that it would be debconf abuse and also that it would not work. We are talking about a debconf setting in the _installed_ system after all,

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Christian Perrier
Quoting Joey Hess ([EMAIL PROTECTED]): > How was this value chosen? I don't feel that relying on files in /tmp is Proposed by Frans and, as noone popped up to propose something else better, implemented by me by using Frans' proposed patch. I'm well opened to improve this in console-data, of cou

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Christian Perrier
Quoting Frans Pop ([EMAIL PROTECTED]): > I had hoped for a reaction from either you or Colin to my proposal. However, > Christian did not leave very much time before applying my patch which > probably meant that he did not see alternatives either. Frankly, no..:-) It just happened that I had

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Otavio Salvador
Joey Hess <[EMAIL PROTECTED]> writes: > Frans Pop wrote: >> Log: >> After recent changes in apt-install, we need to tell console-data not to >> display its keymap/policy question when it is being installed during a D-I >> installation. console-data (>= 2:1.04-2) will check for the existence of >>

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Frans Pop
On Monday 17 December 2007, Joey Hess wrote: > Frans Pop wrote: > > Log: > > After recent changes in apt-install, we need to tell console-data not > > to display its keymap/policy question when it is being installed during > > a D-I installation. console-data (>= 2:1.04-2) will check for the > > ex

Re: r50470 - trunk/packages/kbd-chooser/debian

2007-12-17 Thread Joey Hess
Frans Pop wrote: > Log: > After recent changes in apt-install, we need to tell console-data not to > display its keymap/policy question when it is being installed during a D-I > installation. console-data (>= 2:1.04-2) will check for the existence of > the file /tmp/debian-installer/keymap-policy-d