Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-30 Thread Joey Hess
David Härdeman wrote: > On Fri, Sep 29, 2006 at 11:39:41AM -0400, Joey Hess wrote: > >anna-install returns: > > > >0 if a package was installed successfully > >0 if anna is not yet configured with a udeb source and the package > > installation was queued for later > >0 if no package was installed (

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-30 Thread David Härdeman
On Fri, Sep 29, 2006 at 11:39:41AM -0400, Joey Hess wrote: anna-install returns: 0 if a package was installed successfully 0 if anna is not yet configured with a udeb source and the package installation was queued for later 0 if no package was installed (ie, package already installed) 1 if anna

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-29 Thread Joey Hess
David Härdeman wrote: > On a related note, Max indicated that it seems that anna-install *does* > return an error if it fails to install dependencies, so it seems that most > of the fixes that I committed to partman-crypto (except calling depmod) > are redundant anyway? anna-install returns: 0 if

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-28 Thread Frans Pop
On Thursday 28 September 2006 17:48, David Härdeman wrote: > So, instead of checking all the libs for the programs (cryptsetup, > dmsetup) that were downloadedhow about something like this: > > cryptsetup > /dev/null 2>&1 > if [ $? -gt 1 ]; then > # error > fi > > Is this a daft idea? :)

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-28 Thread David Härdeman
On Thu, Sep 28, 2006 at 12:05:59PM +0200, Frans Pop wrote: Please try to avoid hardcoded paths in scripts. In recent commits I noticed quite a few of them. For example, to check for the availability of an executable, the following construct is preferred: if type >/dev/null 2>&1; then For

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-28 Thread Frans Pop
On Thursday 28 September 2006 12:22, David Härdeman wrote: > On a related note, Max indicated that it seems that anna-install *does* > return an error if it fails to install dependencies, so it seems that > most of the fixes that I committed to partman-crypto (except calling > depmod) are redundant

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-28 Thread David Härdeman
On Thu, September 28, 2006 12:05, Frans Pop said: > Please try to avoid hardcoded paths in scripts. In recent commits I > noticed quite a few of them. Will fix. On a related note, Max indicated that it seems that anna-install *does* return an error if it fails to install dependencies, so it seems

Re: r41007 - in trunk/packages/partman/partman-crypto: . debian

2006-09-28 Thread Frans Pop
On Tuesday 26 September 2006 18:37, David Härdeman wrote: > Author: alphix-guest > Date: Tue Sep 26 16:37:44 2006 > New Revision: 41007 > > Modified: >trunk/packages/partman/partman-crypto/crypto_tools.sh Please try to avoid hardcoded paths in scripts. In recent commits I noticed quite a few