Re: debootstrap 1.0.93+nmu5

2018-04-05 Thread Hideki Yamane
On Thu, 05 Apr 2018 12:58:09 +0200 Ben Hutchings wrote: > The portable way to look for a command, without running it or > hardcoding the directory, is 'command -v'. Thanks, it looks better. -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Re: debootstrap 1.0.93+nmu5

2018-04-05 Thread Ben Hutchings
On Tue, 2018-04-03 at 18:48 +0900, Hideki Yamane wrote: > On Tue, 3 Apr 2018 11:20:43 +0200 > Raphael Hertzog wrote: > > In most postinst snippets, it is used like this: > > > > if which apt-config >/dev/null 2>&1; then > > > > I don't see the need for a sub-shell. > > I've tried which com

Re: debootstrap 1.0.93+nmu5

2018-04-03 Thread Hideki Yamane
On Tue, 3 Apr 2018 11:53:45 +0200 Raphael Hertzog wrote: > > +if [ -e /usr/bin/apt-config ]; then > > In case like this, you usually use "-x" to ensure it's also executable. Thanks :) -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Re: debootstrap 1.0.93+nmu5

2018-04-03 Thread Raphael Hertzog
On Tue, 03 Apr 2018, Hideki Yamane wrote: > +if [ -e /usr/bin/apt-config ]; then In case like this, you usually use "-x" to ensure it's also executable. > +eval $(apt-config shell AUTOPROXY Acquire::http::ProxyAutoDetect) > +if [ -z "$http_proxy" ] && [ -x "$AUTOPROXY" ]; then > +

Re: debootstrap 1.0.93+nmu5

2018-04-03 Thread Hideki Yamane
On Tue, 3 Apr 2018 11:20:43 +0200 Raphael Hertzog wrote: > In most postinst snippets, it is used like this: > > if which apt-config >/dev/null 2>&1; then > > I don't see the need for a sub-shell. I've tried which command on NetBSD, it failed. So just check "test -e" for /usr/bin/apt-con

Re: debootstrap 1.0.93+nmu5

2018-04-03 Thread Raphael Hertzog
On Fri, 30 Mar 2018, Hideki Yamane wrote: > On Fri, 30 Mar 2018 14:24:27 +0200 > Raphael Hertzog wrote: > > debootstrap can be run on a non-Debian system and should not assume that > > apt-config is available. I would suggest to protect this code with > > a check of the existence of apt-config. >

Re: debootstrap 1.0.93+nmu5

2018-03-30 Thread Hideki Yamane
On Fri, 30 Mar 2018 15:19:52 +0200 Cyril Brulebois wrote: > Great, thanks. Please push the tags for the previous uploads too? Now pushed :) -- Regards, Hideki Yamane henrich @ debian.org/iijmio-mail.jp

Re: debootstrap 1.0.93+nmu5

2018-03-30 Thread Hideki Yamane
On Fri, 30 Mar 2018 14:24:27 +0200 Raphael Hertzog wrote: > debootstrap can be run on a non-Debian system and should not assume that > apt-config is available. I would suggest to protect this code with > a check of the existence of apt-config. You're right. Then, how about this? if (which apt-c

Re: debootstrap 1.0.93+nmu5

2018-03-30 Thread Cyril Brulebois
Hi, Hideki Yamane (2018-03-30): > On Wed, 28 Mar 2018 18:07:28 +0200 > Cyril Brulebois wrote: > > I don't really get why you serial-NMU debootstrap instead of just pushing to > > the repository and adding yourself as an uploader? > > I was not aware that I can push it to repo. > Now I've adde

Re: debootstrap 1.0.93+nmu5

2018-03-30 Thread Hideki Yamane
On Wed, 28 Mar 2018 18:07:28 +0200 Cyril Brulebois wrote: > I don't really get why you serial-NMU debootstrap instead of just pushing to > the repository and adding yourself as an uploader? I was not aware that I can push it to repo. Now I've added myself to uploaders and pushed it, thanks. -

Re: debootstrap 1.0.93+nmu5

2018-03-30 Thread Raphael Hertzog
Hi, On Wed, 28 Mar 2018, Hideki Yamane wrote: > From: Michael Vogt > Date: Thu, 19 Dec 2013 15:36:58 +0100 > Subject: [PATCH 09/13] try to auto-detect proxy if available > > --- a/debootstrap > +++ b/debootstrap > @@ -49,6 +49,17 @@ PRIVATEKEY="" > DEF_MIRROR="http://deb.debian.org/debian"; >

Re: debootstrap 1.0.93+nmu5

2018-03-28 Thread Cyril Brulebois
Hi, Hideki Yamane (2018-03-28): > I've almost prepared another NMU, please check it. I don't really get why you serial-NMU debootstrap instead of just pushing to the repository and adding yourself as an uploader? Cheers, -- Cyril Brulebois (k...@debian.org)

debootstrap 1.0.93+nmu5

2018-03-28 Thread Hideki Yamane
Hi list, I've almost prepared another NMU, please check it. debootstrap (1.0.93+nmu5) UNRELEASED; urgency=medium * Non-maintainer upload. [ Hideki Yamane ] * Avoid unnecessary keyring warning with --second-stage option (Closes: #734324) * Output warning if falling back to