Re: Multiple disks support for partman-auto-lvm

2008-01-26 Thread Frans Pop
On Saturday 26 January 2008, Stephen Gran wrote: > This one time, at band camp, Frans Pop said: > > Also: > > + if [ "X$pvdev_found" = 'Xyes' ]; then > > The X is not needed. The shell handles empty variables correctly if > > they have double quotes around them. Also, the quotes a

Re: Multiple disks support for partman-auto-lvm

2008-01-26 Thread Stephen Gran
This one time, at band camp, Frans Pop said: > Also: > + if [ "X$pvdev_found" = 'Xyes' ]; then > The X is not needed. The shell handles empty variables correctly if they > have double quotes around them. Also, the quotes around "yes" are not > needed (as it is a single word an

Re: Multiple disks support for partman-auto-lvm

2008-01-26 Thread Frans Pop
On Saturday 26 January 2008, Colin Watson wrote: > On Wed, Jan 23, 2008 at 05:07:53PM +0100, Frans Pop wrote: > > Also: > > + if [ "X$pvdev_found" = 'Xyes' ]; then > > The X is not needed. The shell handles empty variables correctly if > > they have double quotes around them. Also

Re: Multiple disks support for partman-auto-lvm

2008-01-26 Thread Colin Watson
On Wed, Jan 23, 2008 at 05:07:53PM +0100, Frans Pop wrote: > Also: > + if [ "X$pvdev_found" = 'Xyes' ]; then > The X is not needed. The shell handles empty variables correctly if they > have double quotes around them. Also, the quotes around "yes" are not > needed (as it is a

Re: Multiple disks support for partman-auto-lvm

2008-01-23 Thread Grégory Oestreicher
Le mercredi 23 janvier 2008 17:07, Frans Pop a écrit : > > This patch is based on the current (as of 2008/01/20) SVN version of > > partman-auto and partman-auto-lvm (the former needing only a minor > > modification). > > This is a very much better proposal than your last one :-) Thanks. There's a

Re: Multiple disks support for partman-auto-lvm

2008-01-23 Thread Frans Pop
On Sunday 20 January 2008, Grégory Oestreicher wrote: > I finally managed to write a more general patch[1] to have multiple disks > support in partman-auto-lvm. It has been successfully tested on x86 with > the three base recipes of the installer (atomic, home and multi) to > prevent regressions, a

Re: Multiple disks support for partman-auto-lvm

2008-01-20 Thread Christian Perrier
Quoting Grégory Oestreicher ([EMAIL PROTECTED]): > Hi all, > > I finally managed to write a more general patch[1] to have multiple disks > support in partman-auto-lvm. It has been successfully tested on x86 with the The debconf templates need some careful review and correction. I suggest we *