Re: [patch] netcfg wireless

2009-07-03 Thread Luca Favatella
On 01/07/2009, Otavio Salvador wrote: [...] > It looks fine from my POV. Wait a cuple of days to see if noone > complains about something and then commit it. Committed. Thanks, Luca Favatella -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Tro

Re: [patch] netcfg wireless

2009-07-01 Thread Luca Favatella
On 01/07/2009, Otavio Salvador wrote: [...] > It looks fine from my POV. Wait a cuple of days to see if noone > complains about something and then commit it. Ok, thanks. -- To UNSUBSCRIBE, email to debian-boot-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas..

Re: [patch] netcfg wireless

2009-07-01 Thread Otavio Salvador
Hello Luca, On Wed, Jul 1, 2009 at 6:29 AM, Luca Favatella wrote: > On 01/07/2009, Otavio Salvador wrote: > [...] >> The patch itself looks good. I'd just inverse the logic. >> >> You've used NO_WIRELESS and I'd use WIRELESS and set it to 0 to >> disable or or similar. > > Consider that NO_WIRELE

Re: [patch] netcfg wireless

2009-07-01 Thread Luca Favatella
On 01/07/2009, Otavio Salvador wrote: [...] > The patch itself looks good. I'd just inverse the logic. > > You've used NO_WIRELESS and I'd use WIRELESS and set it to 0 to > disable or or similar. Consider that NO_WIRELESS was already there. However I modified it as you suggested in the attached v

Re: [patch] netcfg wireless

2009-06-30 Thread Otavio Salvador
Hello Luca, On Tue, Jun 30, 2009 at 4:36 PM, Luca Favatella wrote: > This patch makes netcfg building and linking more fine-grained. > It also disables wireless by default on non-linux archs. The patch itself looks good. I'd just inverse the logic. You've used NO_WIRELESS and I'd use WIRELESS an