Re: Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-22 Thread Jeremie Koenig
On Mon, Aug 23, 2010 at 12:18:43AM +0200, Samuel Thibault wrote: > Hello, > > Jeremie Koenig, le Thu 12 Aug 2010 11:49:22 +0200, a écrit : > > An alternative would be to check for, say, /sys/devices in the installer > > itself. Does this sound reasonable? > > So? > > Aurelien, could you confirm

Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-22 Thread Jeremie Koenig
On Thu, Aug 12, 2010 at 11:49:22AM +0200, Jeremie Koenig wrote: > On Thu, Aug 12, 2010 at 09:43:06AM +0200, Petter Reinholdtsen wrote: > > [Jeremie Koenig] > > > - if [ ! -d /target/sys ]; then > > > + if [ ! -d /target/sys ] && [ "$(udpkg --print-os)" != hurd ]; then > > > > Would it be better to

Re: Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-22 Thread Samuel Thibault
Hello, Jeremie Koenig, le Thu 12 Aug 2010 11:49:22 +0200, a écrit : > On Thu, Aug 12, 2010 at 09:43:06AM +0200, Petter Reinholdtsen wrote: > > [Jeremie Koenig] > > > - if [ ! -d /target/sys ]; then > > > + if [ ! -d /target/sys ] && [ "$(udpkg --print-os)" != hurd ]; then > > > > Would it be bett

Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-12 Thread Jeremie Koenig
On Thu, Aug 12, 2010 at 09:43:06AM +0200, Petter Reinholdtsen wrote: > [Jeremie Koenig] > > - if [ ! -d /target/sys ]; then > > + if [ ! -d /target/sys ] && [ "$(udpkg --print-os)" != hurd ]; then > > Would it be better to look for 'sysfs' in /proc/filesystems to avoid > hardcoding OS names th

Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-12 Thread Petter Reinholdtsen
[Jeremie Koenig] > - if [ ! -d /target/sys ]; then > + if [ ! -d /target/sys ] && [ "$(udpkg --print-os)" != hurd ]; then Would it be better to look for 'sysfs' in /proc/filesystems to avoid hardcoding OS names there? Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to

Bug#592684: debian-installer-utils: please don't check for /sys on Hurd

2010-08-11 Thread Jeremie Koenig
Package: debian-installer-utils Version: 1.77 Tags: patch Usertags: gsoc2010 Hi, The chroot_setup shell function provided by chroot-setup.sh aborts with an error when /target/sys does not exist. However, on Hurd there is no such thing as /sys. The attached patch disables the test in question on