Guido Günther <[EMAIL PROTECTED]> writes:
> On Thu, Feb 28, 2008 at 08:47:56PM -0300, Otavio Salvador wrote:
>> But why you've change to grep instead checking the $?
> This way we fail when either: multipath -l returns an error or when the
> output doesn't contain any valid multipaths.
Ah ok, so
On Fri, Feb 29, 2008 at 01:50:34AM +0100, Frans Pop wrote:
> P.S. I'm going to assume you're subscribed to the list from now on. No need
> to CC me on replies either.
Sure. But please do cc: me since I'm not reading debian-boot that
frequently.
Cheers,
-- Guido
--
To UNSUBSCRIBE, email to [EM
On Thu, Feb 28, 2008 at 08:47:56PM -0300, Otavio Salvador wrote:
> But why you've change to grep instead checking the $?
This way we fail when either: multipath -l returns an error or when the
output doesn't contain any valid multipaths.
-- Guido
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
On Friday 29 February 2008, Otavio Salvador wrote:
> But why you've change to grep instead checking the $?
IMO the new way is a lot more readable. Feel free to commit.
Cheers,
FJP
P.S. I'm going to assume you're subscribed to the list from now on. No need
to CC me on replies either.
--
To U
Guido Günther <[EMAIL PROTECTED]> writes:
> On Tue, Feb 26, 2008 at 05:03:04PM +0100, Frans Pop wrote:
>> This line is way to cryptic to my taste:
>> [ -n "$(/sbin/multipath -l)" && $? ] && return 0 || return 1
>>
>> Could you rewrite that to something that is a bit more intuitive?
>
> Th
On Tue, Feb 26, 2008 at 05:03:04PM +0100, Frans Pop wrote:
> This line is way to cryptic to my taste:
> [ -n "$(/sbin/multipath -l)" && $? ] && return 0 || return 1
>
> Could you rewrite that to something that is a bit more intuitive?
This one is simpler and much more robust against weird
On Tuesday 26 February 2008, Guido Günther wrote:
> attached is an updated patch for multipath detection in hw-detect. The
> patch hasn't changed it's just rediffed against current SVN.
This line is way to cryptic to my taste:
[ -n "$(/sbin/multipath -l)" && $? ] && return 0 || return 1
C
Hi,
attached is an updated patch for multipath detection in hw-detect. The
patch hasn't changed it's just rediffed against current SVN.
Cheers,
-- Guido
>From 96b6e14bf63d4df4ec62d8838ecbdbf2c30a17ba Mon Sep 17 00:00:00 2001
From: Guido Guenther <[EMAIL PROTECTED]>
Date: Tue, 26 Feb 2008 13:23:38
8 matches
Mail list logo
