Re: [RFC] Remove massbuild bashisms

2007-08-28 Thread Otavio Salvador
Jérémy Bobbio <[EMAIL PROTECTED]> writes: > I don't have a huge personal preference, although I like the idea of > having POSIX compliant shell scripts. If there's no opposition, I'll > commit it in a few days. Using the Branden suggestion I think it's OK for commiting. -- O T A V I O

Re: [RFC] Remove massbuild bashisms

2007-08-28 Thread Branden Robinson
On Tue, Aug 28, 2007 at 05:24:48PM +0200, Jérémy Bobbio wrote: > + BDEP_SOURCE_PREFIX=$(echo "$BDEP_SOURCE" | head -c 1) My recommendation was wrong -- I left out a step. Try this: _TMP=${BDEP_SOURCE#?} # everything but the first character BDEP_SOURCE_PREFIX=${BDEP_SOURCE%$_TMP} The first e

Re: [RFC] Remove massbuild bashisms

2007-08-28 Thread Jérémy Bobbio
On Tue, Aug 28, 2007 at 12:30:35PM -0400, Branden Robinson wrote: > On Tue, Aug 28, 2007 at 05:24:48PM +0200, Jérémy Bobbio wrote: > > Hi! > > > > Attached is a patch that will remove bashisms in the massbuild script. > [...] > > I don't have a huge personal preference, although I like the idea of

Re: [RFC] Remove massbuild bashisms

2007-08-28 Thread Branden Robinson
On Tue, Aug 28, 2007 at 05:24:48PM +0200, Jérémy Bobbio wrote: > Hi! > > Attached is a patch that will remove bashisms in the massbuild script. [...] > I don't have a huge personal preference, although I like the idea of > having POSIX compliant shell scripts. If there's no opposition, I'll > com

[RFC] Remove massbuild bashisms

2007-08-28 Thread Jérémy Bobbio
Hi! Attached is a patch that will remove bashisms in the massbuild script. This script is used to automatically create the udebs from kernel packages. With the attached set of changes, the enter key is required on top of pressing "y" to confirm the build. On the other hand, the script could als