Re: [RFC] Erase LVM/crypto issues and proposed partman reorg

2007-12-04 Thread Max Vozeler
Hi Frans, On Tue, Dec 04, 2007 at 04:39:38PM +0100, Frans Pop wrote: > > > 1) Rename current "wipe" functions > > > > > > For partman-crypto I have a patch that renames the existing functions > > > to include the crypto namespace: > > > - wipe -> crypto_do_wipe > > > - dev_wipe -> crypto_wipe_devi

Re: [RFC] Erase LVM/crypto issues and proposed partman reorg

2007-12-04 Thread Frans Pop
On Tuesday 04 December 2007, Max Vozeler wrote: > David's changes include good code that can be reintroduced > later on to a large extent [...] Yes, absolutely. Same goes for the changes suggested by Jérémy. I have committed the revert. > > 1) Rename current "wipe" functions > > > > For partman-

Re: [RFC] Erase LVM/crypto issues and proposed partman reorg

2007-12-03 Thread Max Vozeler
On Mon, Dec 03, 2007 at 11:26:22AM +0100, Frans Pop wrote: > I therefore suggest reverting David's changes (which luckily is quite > straightforward) and then first do some refactoring of existing code as > preparation for a reimplementation of support for erasing encrypted > volumes. I tend to

Re: [RFC] Erase LVM/crypto issues and proposed partman reorg

2007-12-03 Thread David Härdeman
On Mon, Dec 03, 2007 at 11:26:22AM +0100, Frans Pop wrote: I've spent about 6 hours yesterday looking at #396023 and #425829, the issues introduced after implementation of support for erasing encrypted volumes. I've looked at both the original patch and the changes proposed by Jérémy. Your su

[RFC] Erase LVM/crypto issues and proposed partman reorg

2007-12-03 Thread Frans Pop
I've spent about 6 hours yesterday looking at #396023 and #425829, the issues introduced after implementation of support for erasing encrypted volumes. I've looked at both the original patch and the changes proposed by Jérémy. The main issues are that the original patch: - relies on dmsetup to