Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Samuel Thibault, le Wed 13 Aug 2008 00:54:15 +0100, a écrit : > Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit : > > On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > > > On Tuesday 12 August 2008, Samuel Thibault wrote: > > >> Here is an corrected patch > > > > >

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit : > On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > > On Tuesday 12 August 2008, Samuel Thibault wrote: > >> Here is an corrected patch > > > > Looks fine to me. > > Shouldn't there be a left bracket after the &&? >

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Frans Pop
On Wednesday 13 August 2008, Per Andersson wrote: > On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > > On Tuesday 12 August 2008, Samuel Thibault wrote: > >> Here is an corrected patch > > > > Looks fine to me. > > Shouldn't there be a left bracket after the &&? > (It's miss

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Per Andersson
On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote: > On Tuesday 12 August 2008, Samuel Thibault wrote: >> Here is an corrected patch > > Looks fine to me. Shouldn't there be a left bracket after the &&? (It's missing in several places.) if [ $$outfile == menu.cfg ] && $$MENU_B

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Frans Pop, le Wed 13 Aug 2008 00:51:29 +0200, a écrit : > On Tuesday 12 August 2008, Samuel Thibault wrote: > > Here is an corrected patch > > Looks fine to me. > > Only wonder if it would not make more sense to rename the variable to > BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easi

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Frans Pop
On Tuesday 12 August 2008, Samuel Thibault wrote: > Here is an corrected patch Looks fine to me. Only wonder if it would not make more sense to rename the variable to BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be confused with the D-I main menu. signature.asc Description: T

[PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Hello, Here is an corrected patch Samuel Index: build/config/x86.cfg === --- build/config/x86.cfg(révision 54981) +++ build/config/x86.cfg(copie de travail) @@ -60,6 +60,11 @@ outfile=