Re: [PATCH] grub-installer: Handle disks with multi-letter names

2011-05-04 Thread Christian PERRIER
Quoting Roland Dreier (rol...@digitalvampire.org): (snip previous discussion) > so at least conceivably, one could have /dev/vdabc. The code for sd is > similar though more confusingly written, and I don't think > 26*26 SCSI > disks is actually that far-fetched for big systems. > > Again though

Re: [PATCH] grub-installer: Handle disks with multi-letter names

2011-05-04 Thread Roland Dreier
> > Why are you changing [a-z0-9} to [a-z]? I looked at drivers/ide/ide-probe.c in the Linux kernel and it has sprintf(disk->disk_name, "hd%c", 'a' + hwif->index * MAX_DRIVES + unit); so under Linux there is no way to get anything other than hda...hdz. > I think, from distant memory,

Re: [PATCH] grub-installer: Handle disks with multi-letter names

2011-05-04 Thread Colin Watson
On Wed, May 04, 2011 at 08:19:25PM +0200, Christian PERRIER wrote: > Quoting Roland Dreier (rol...@digitalvampire.org): > > diff --git a/grub-installer b/grub-installer > > index 95b6532..c8c1e74 100755 > > --- a/grub-installer > > +++ b/grub-installer > > @@ -231,7 +231,7 @@ case $prefix in > >

Re: [PATCH] grub-installer: Handle disks with multi-letter names

2011-05-04 Thread Christian PERRIER
Quoting Roland Dreier (rol...@digitalvampire.org): > diff --git a/grub-installer b/grub-installer > index 95b6532..c8c1e74 100755 > --- a/grub-installer > +++ b/grub-installer > @@ -231,7 +231,7 @@ case $prefix in > /dev/mapper) > disc_offered_devfs="$bootfs" > ;; > - > /dev/[

[PATCH] grub-installer: Handle disks with multi-letter names

2011-05-03 Thread Roland Dreier
On a system with more than 26 disks, after /dev/sda through /dev/sdz are used, disks start to get names like /dev/sdaa, /dev/sdab, etc. Unfortunately grub-installer doesn't cope with these names; the pattern used to figure out how to compute disc_offered_devfs doesn't match properly and so trying t