Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit :
> Better to just use 0/1 as values and only test for '= 1' (or test for
> set/unset, not sure what is more common).
At least DEBUG uses y/n, so I have done the same in the attached fixed
patch.
Samuel
Index: build/config/x86.cfg
===
Samuel Thibault, le Wed 13 Aug 2008 00:54:15 +0100, a écrit :
> Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit :
> > On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> > > On Tuesday 12 August 2008, Samuel Thibault wrote:
> > >> Here is an corrected patch
> > >
> >
On Wednesday 13 August 2008, Per Andersson wrote:
> On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> >> Here is an corrected patch
> >
> > Looks fine to me.
>
> Shouldn't there be a left bracket after the &&?
> (It's miss
Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit :
> On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> >> Here is an corrected patch
> >
> > Looks fine to me.
>
> Shouldn't there be a left bracket after the &&?
>
On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop <[EMAIL PROTECTED]> wrote:
> On Tuesday 12 August 2008, Samuel Thibault wrote:
>> Here is an corrected patch
>
> Looks fine to me.
Shouldn't there be a left bracket after the &&?
(It's missing in several places.)
if [ $$outfile == menu.cfg ] && $$MENU_B
Frans Pop, le Wed 13 Aug 2008 00:51:29 +0200, a écrit :
> On Tuesday 12 August 2008, Samuel Thibault wrote:
> > Here is an corrected patch
>
> Looks fine to me.
>
> Only wonder if it would not make more sense to rename the variable to
> BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easi
On Tuesday 12 August 2008, Samuel Thibault wrote:
> Here is an corrected patch
Looks fine to me.
Only wonder if it would not make more sense to rename the variable to
BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be confused
with the D-I main menu.
signature.asc
Description: T
Hello,
Here is an corrected patch
Samuel
Index: build/config/x86.cfg
===
--- build/config/x86.cfg(révision 54981)
+++ build/config/x86.cfg(copie de travail)
@@ -60,6 +60,11 @@
outfile=
On Tuesday 12 August 2008, Samuel Thibault wrote:
> Frans Pop, le Tue 12 Aug 2008 10:29:23 +0200, a écrit :
> > On Tuesday 12 August 2008, Samuel Thibault wrote:
> > > Here is a patch. I didn't know how I should detect the kind of
> > > build, I just made it look at the udebs source.
> >
> > I don
Otavio Salvador <[EMAIL PROTECTED]> writes:
> From my POV it looks good. Let's wait few days to see if someone nack
> it or something, otherwise I'll commit it in the end of week.
Samuel,
Please address both points spoted by Frans and resubmit it.
Thanks a lot.
--
O T A V I OS A L
On Tue, Aug 12, Samuel Thibault wrote:
Snip.
> > Also, please use '[ ] && [ ]' instead of '[ -a
> > ]'.
>
> I'm curious: why?
To bash specific. Have a look at the dash man page.
--Frank
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL
Samuel Thibault <[EMAIL PROTECTED]> writes:
>> Also, please use '[ ] && [ ]' instead of '[ -a
>> ]'.
>
> I'm curious: why?
Coding Style.
--
O T A V I OS A L V A D O R
-
E-mail: [EMAIL PROTECTED] UIN: 5906116
GNU/Linux User: 2390
Samuel Thibault <[EMAIL PROTECTED]> writes:
> Otavio Salvador, le Mon 11 Aug 2008 22:06:50 -0300, a écrit :
>> Samuel Thibault <[EMAIL PROTECTED]> writes:
>>
>> > Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit :
>> >> Still no feedback on this?
>> >
>> > (I mean feedback from debian-
Frans Pop, le Tue 12 Aug 2008 10:29:23 +0200, a écrit :
> On Tuesday 12 August 2008, Samuel Thibault wrote:
> > Here is a patch. I didn't know how I should detect the kind of build,
> > I just made it look at the udebs source.
>
> I don't think it's smart to use USE_UDEBS_FROM here. Better use a
On Tuesday 12 August 2008, Samuel Thibault wrote:
> Here is a patch. I didn't know how I should detect the kind of build,
> I just made it look at the udebs source.
I don't think it's smart to use USE_UDEBS_FROM here. Better use a
dedicated variable. Also, please use '[ ] && [ ]' instead
of '
15 matches
Mail list logo
