Re: [parted-devel] Atari label false positives

2018-05-14 Thread Phillip Susi
On 5/12/2018 4:41 AM, Michael Schmitz wrote: > I had that the wrong way - link order is not what matters here, the > checks order has msdos before atari in fact. Ok, I was going to say the dos table requires the 55AA signature that is not expected to be found in an atari table. One other thing I

Re: [parted-devel] Atari label false positives

2018-05-12 Thread Michael Schmitz
Hi Adrian, Am 12.05.2018 um 23:24 schrieb John Paul Adrian Glaubitz: > On 05/12/2018 10:41 AM, Michael Schmitz wrote: Do you have a dump of the root sector (plus additional eventual extended partition root sector) from these bugs? >>> >>> This is a very good point. We should have a

Re: [parted-devel] Atari label false positives

2018-05-12 Thread John Paul Adrian Glaubitz
On 05/12/2018 10:41 AM, Michael Schmitz wrote: Do you have a dump of the root sector (plus additional eventual extended partition root sector) from these bugs? This is a very good point. We should have a look at the probing code in the kernel because apparently the problem doesn't exist there.

Re: [parted-devel] Atari label false positives

2018-05-12 Thread Michael Schmitz
Hi Adrian, Am 12.05.2018 um 19:59 schrieb John Paul Adrian Glaubitz: > On 05/12/2018 01:17 AM, Michael Schmitz wrote: >> The link order in the kernel (atari before msdos) has not been chosen at >> random. The msdos partition format probe will always succeed on any >> valid Atari partition table, w

Re: [parted-devel] Atari label false positives

2018-05-12 Thread John Paul Adrian Glaubitz
On 05/12/2018 01:17 AM, Michael Schmitz wrote: > The link order in the kernel (atari before msdos) has not been chosen at > random. The msdos partition format probe will always succeed on any > valid Atari partition table, while Atari format probe should not succeed > on plain MSDOS partitions. >

Re: [parted-devel] Atari label false positives

2018-05-11 Thread Michael Schmitz
Hi Phillip, Am 12.05.2018 um 03:56 schrieb Phillip Susi: > On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote: >> Thanks for digging this up. I wasn't aware of this particular issue before >> and I agree, this needs to be addressed. I hope that I didn't cause too >> many DOS partitions to be m

Re: [parted-devel] Atari label false positives

2018-05-11 Thread Richard Z
On Fri, May 11, 2018 at 06:10:37PM +0200, John Paul Adrian Glaubitz wrote: > According to the documentation, p.43 [1], I think offset $01 should always > contain either "GEM", "BGM" or "XGM". They don't seem to be optional. The Atari partitioning tables are also used on the Q40/Q60 which breaks m

Re: [parted-devel] Atari label false positives

2018-05-11 Thread Phillip Susi
On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote: > Thanks for digging this up. I wasn't aware of this particular issue before > and I agree, this needs to be addressed. I hope that I didn't cause too > many DOS partitions to be misdetected. Sorry for the inconvenience if I > did. The Atari p

Re: [parted-devel] Atari label false positives

2018-05-11 Thread John Paul Adrian Glaubitz
On 05/11/2018 05:56 PM, Phillip Susi wrote: On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote: Thanks for digging this up. I wasn't aware of this particular issue before and I agree, this needs to be addressed. I hope that I didn't cause too many DOS partitions to be misdetected. Sorry for