Re: [parted-devel] [PATCH] Fix atari label false positives

2018-06-06 Thread Phillip Susi
On 6/5/2018 4:08 PM, Håkon Løvdal wrote: > While the commit message contains the relevant information, this really > ought to be present as a comment directly in the code as well. And > the un-obviousness of the code vs check order deserves a mention as > well, so please add a commen like > > +

Re: [parted-devel] [PATCH] Fix atari label false positives

2018-06-05 Thread Håkon Løvdal
While the commit message contains the relevant information, this really ought to be present as a comment directly in the code as well. And the un-obviousness of the code vs check order deserves a mention as well, so please add a commen like + ped_disk_atari_init (); // NB! Must be first so t