Re: [parted-devel] [PATCH] Fix atari label false positives

2018-06-06 Thread Phillip Susi
On 6/5/2018 4:08 PM, Håkon Løvdal wrote: > While the commit message contains the relevant information, this really > ought to be present as a comment directly in the code as well. And > the un-obviousness of the code vs check order deserves a mention as > well, so please add a commen like > > +

[PATCH] Fix atari label false positives

2018-06-05 Thread Phillip Susi
The atari label gets false positives easily, so probe it after all other labels have said no. --- NEWS | 2 ++ libparted/libparted.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2c903ca5..a5ec44ee 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6

Re: [PATCH] Fix atari label false positives

2018-06-05 Thread Phillip Susi
On 6/5/2018 10:35 AM, John Paul Adrian Glaubitz wrote: > Is that the reversed patch? I thought you wanted to move the atari > probing to the bottom? No; the order they are probed in is the reverse of the order they are initialized in because the fs registration puts the new one on the head and sli

Re: [parted-devel] Atari label false positives

2018-05-14 Thread Phillip Susi
On 5/12/2018 4:41 AM, Michael Schmitz wrote: > I had that the wrong way - link order is not what matters here, the > checks order has msdos before atari in fact. Ok, I was going to say the dos table requires the 55AA signature that is not expected to be found in an atari table. One other thing I

Re: [parted-devel] Atari label false positives

2018-05-11 Thread Phillip Susi
On 5/11/2018 11:29 AM, John Paul Adrian Glaubitz wrote: > Thanks for digging this up. I wasn't aware of this particular issue before > and I agree, this needs to be addressed. I hope that I didn't cause too > many DOS partitions to be misdetected. Sorry for the inconvenience if I > did. The Atari p

Re: Bug#239816: bug#16134: libparted Atari partition table support

2013-12-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/2013 2:17 PM, Thorsten Glaser wrote: > I thought so too, but it turns out that the Atari IDE interface is > literally wired “the wrong way”, so you do need to bswap the entire > disc – not just partition table or filesystem metadata – but also

Re: Bug#239816: bug#16134: libparted Atari partition table support

2013-12-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/16/2013 04:19 PM, Thorsten Glaser wrote: > John Paul Adrian Glaubitz dixit: > >> But, of course, you could apply the patch to gparted, rebuild >> it, then create a partition table on a hard disk and hook it up >> to your ATARI and see if it's

Re: Bug#239816: bug#16134: libparted Atari partition table support

2013-12-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/16/2013 2:45 PM, John Paul Adrian Glaubitz wrote: > I'm pretty sure that Philipp was talking about tests which are run > during build time to check the code, hence the name "make check". Yes. You should start with the current git head preferab

Re: bug#16134: libparted Atari partition table support

2013-12-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/13/2013 6:32 PM, Michael Schmitz wrote: > John, > > as long as libparted (or some other PC side kernel magic > automagically invoked by libparted - dm??) does take care of > byte-swapping IDE data on the fly, go for it. I had a quick glance > at

Re: bug#16134: libparted Atari partition table support

2013-12-16 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Would you be able to write a test case so make check verifies it is working? On 12/13/2013 5:54 PM, John Paul Adrian Glaubitz wrote: > Hi! > > While chatting with someone who was trying to install Linux onto > his ATARI Falcon 060, we stumbled into t

Re: Bug#239816: libparted Atari partition table support

2013-12-14 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/14/2013 02:26 AM, Thorsten Glaser wrote: > The ST, maybe (except for the only-in-museums part), but the TT > and Falcon run Debian GNU/Linux just finely. > > Linux ara5.mirbsd.org 3.11-2-m68k #1 Debian 3.11.7-1 (2013-11-09) > m68k GNU/Linux >

Re: Bug#239816: libparted Atari partition table support

2013-12-13 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 12/13/2013 05:54 PM, John Paul Adrian Glaubitz wrote: > Hi! > > While chatting with someone who was trying to install Linux onto > his ATARI Falcon 060, we stumbled into the task getting the hard > disk partitioned for the ATARI Falcon to be used