Re: signal delivery, was Re: reliable reproducer

2023-04-26 Thread Brad Boyer
On Wed, Apr 26, 2023 at 09:10:50PM +1200, Michael Schmitz wrote: > Am 26.04.2023 um 16:42 schrieb Finn Thain: > >If the long format frame was corrupted while on the user stack, the > >partially completed MOVEM won't be resumed correctly. That's why I was > >concerned about a bug in sys_sigreturn. >

Re: signal delivery, was Re: reliable reproducer

2023-04-26 Thread Michael Schmitz
Hi Finn, On 25/04/23 14:32, Michael Schmitz wrote: Hi Finn, Am 25.04.2023 um 13:55 schrieb Finn Thain: On Tue, 25 Apr 2023, Finn Thain wrote: On Tue, 25 Apr 2023, Michael Schmitz wrote: As to a cause for the corruption: all the calculations in setup_frame and sys_sigreturn use fsize, but g

Re: signal delivery, was Re: reliable reproducer

2023-04-26 Thread Michael Schmitz
Hi Finn, Am 26.04.2023 um 16:42 schrieb Finn Thain: If the long format frame was corrupted while on the user stack, the partially completed MOVEM won't be resumed correctly. That's why I was concerned about a bug in sys_sigreturn. Yes, it turns out I hadn't read mangle_kernel_stack() carefully

Re: signal delivery, was Re: reliable reproducer

2023-04-26 Thread Andreas Schwab
On Apr 26 2023, Michael Schmitz wrote: > The exception frame is copied to the signal frame for informational > purposes only This is not for informational purpose. It is the interrupted context that is restored by the kernel in the sigreturn syscall. -- Andreas Schwab, sch...@linux-m68k.org GP