Re: [parted-devel] [PATCH] Fix atari label false positives

2018-06-05 Thread Håkon Løvdal
While the commit message contains the relevant information, this really ought to be present as a comment directly in the code as well. And the un-obviousness of the code vs check order deserves a mention as well, so please add a commen like + ped_disk_atari_init (); // NB! Must be first so t

[PATCH] Fix atari label false positives

2018-06-05 Thread Phillip Susi
The atari label gets false positives easily, so probe it after all other labels have said no. --- NEWS | 2 ++ libparted/libparted.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2c903ca5..a5ec44ee 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6

Re: [PATCH] Fix atari label false positives

2018-06-05 Thread John Paul Adrian Glaubitz
On 06/05/2018 04:40 PM, Phillip Susi wrote: > On 6/5/2018 10:35 AM, John Paul Adrian Glaubitz wrote: >> Is that the reversed patch? I thought you wanted to move the atari >> probing to the bottom? > > No; the order they are probed in is the reverse of the order they are > initialized in because th

Re: [PATCH] Fix atari label false positives

2018-06-05 Thread Phillip Susi
On 6/5/2018 10:35 AM, John Paul Adrian Glaubitz wrote: > Is that the reversed patch? I thought you wanted to move the atari > probing to the bottom? No; the order they are probed in is the reverse of the order they are initialized in because the fs registration puts the new one on the head and sli

Re: [PATCH] Fix atari label false positives

2018-06-05 Thread John Paul Adrian Glaubitz
On 06/05/2018 04:30 PM, Phillip Susi wrote: > diff --git a/libparted/libparted.c b/libparted/libparted.c > index d855d0e6..e864d1b3 100644 > --- a/libparted/libparted.c > +++ b/libparted/libparted.c > @@ -85,7 +85,7 @@ init_disk_types () > #if defined __s390__ || defined __s390x__ > ped_d