it is only my
personal opinion), but I have to understand what the TODOs mean before
Thank you for your help
rawfiner
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Oh ok sorry for that...
rawfiner
Le vendredi 26 janvier 2018, Terry Duell a écrit :
> On Sat, 27 Jan 2018 05:34:24 +1100, rawfiner wrote:
>
> Thank you for your answer I perfectly agree with the fact that the GUI
>> should not become
>> overcomplicated.
>>
>
about 10.26x slowdown
If you want to make your mind on it, I have pushed a branch here that
integrates the K parameter in the GUI:
https://github.com/rawfiner/darktable.git
The branch is denoise-profile-GUI-K
I think that it may be worth to see if an automated approach for the choice
of K may work
Hi !
I am currently trying various things to improve noise reduction in
darktable.
It seems that NLM on RAW is a very good idea !
On my early tests it works really well.
I have made a (ugly and slow) prototype (without sensor profiling),
available here:
https://github.com/rawfiner/darktable
>iscale is constantly equal to 1, no matter the zoom level, and the
same holds for piece->buf_in.scale)
Thank you !
Regards,
rawfiner
___
darktable developer mailing list
to unsubscribe send a mail to darkta
is far from easy. I think (hope?) that,
maybe, the denoising step *may* reduce the artifacts that result of the
downscaling. Anyway, I will have to test this to figure out if it is an
acceptable solution or not!
>
> let me know how you go with this, sounds very interesting!
> cheers,
> jo
Thank you for your answer.
2018-05-09 13:22 GMT+02:00 johannes hanika :
> heya,
>
> On Wed, May 9, 2018 at 12:27 PM, rawfiner wrote:
> > 2018-05-08 17:16 GMT+02:00 johannes hanika :
> >> i'm guessing you want to detect whether you are running a
> >> DT_DE
easier to have a "uniform" output (i.e. an
output where noise has been reduced quite uniformly)
I have not tested this idea yet.
Cheers,
rawfiner
Le lundi 11 juin 2018, johannes hanika a écrit :
> hi,
>
> i was playing with noise reduction presets again and tried the large
>
ariation computation, I don't know it), as it could reduce the
number of pixels to process.
I guess the user could use something like that also the other way?: to
protect high detailed zones and apply the denoising on quite smoothed zones
only, in order to be able to use stronger denoi
the code, only u is relevant for us
> here).
>
> Great, thanks for the explanations.
Looking at the code of the 8 neighbouring pixels, I wonder if we would make
sense to compute something like that on raw data considering only
neighbouring pixels of the same color?
Also, when talkin
tle "noisy database" are from my own cameras Lumix FZ1000 and Fuji
XT20 and I'd like to have more photos from other cameras)
Thanks!
rawfiner
2018-06-13 23:31 GMT+02:00 rawfiner :
>
>
> Le mercredi 13 juin 2018, Aurélien Pierre a
> écrit :
>
>>
>>
&
Le dimanche 17 juin 2018, Aurélien Pierre a
écrit :
>
>
> Le 13/06/2018 à 17:31, rawfiner a écrit :
>
>
>
> Le mercredi 13 juin 2018, Aurélien Pierre a
> écrit :
>
>>
>>
>>> On Thu, Jun 14, 2018 at 12:23 AM, Aurélien Pierre
>>> wrote:
instead?
Thanks again
Cheers,
rawfiner
2018-07-01 3:45 GMT+02:00 Aurélien Pierre :
> Hi,
>
> I have done experiments on that matter and took the opportunity to
> correct/test further my code.
>
> So here are my attempts to code a noise mask and a sharpness mask with
> total va
Thank you for all these explanations!
Seems promising to me.
Cheers,
rawfiner
2018-07-01 21:26 GMT+02:00 Aurélien Pierre :
> You're welcome ;-)
>
> That's true : the multiplication is equivalent to an "AND" operation, the
> resulting mask has non-zero values w
these passes.
Thanks for any help!
Cheers,
rawfiner
2018-05-10 23:13 GMT+02:00 rawfiner :
> Thank you for your answer.
>
> 2018-05-09 13:22 GMT+02:00 johannes hanika :
>
>> heya,
>>
>> On Wed, May 9, 2018 at 12:27 PM, rawfiner wrote:
>> > 2018-05-08 17:16 GMT+02:0
.
Basically, the user should see no difference whether the downscaling is
activated or not
Thank you for any help
rawfiner
2018-07-06 0:06 GMT+02:00 rawfiner :
> Hi,
>
> I am still trying to resize raw before demosaicing to speed up raw
> denoising.
>
> I now get the zoom level
.
For now, I have an experimental downscaling algorithm on raw data, but
didn't manage to transmit the information that the image is already
downscaled to the demoisaic module, so the image was downscaled twice.
I guess that I will be able to fix this thanks to your information.
rawfiner
2018-07-
Again, thank you for all this information!
This does clear up a lot of things :-)
rawfiner
2018-07-11 10:18 GMT+02:00 johannes hanika :
> heya,
>
> On Fri, Jul 6, 2018 at 12:06 AM, rawfiner wrote:
> > Hi,
> >
> > I am still trying to resize raw before demosaicing to
orm and L1 norm
respectively?
Or is it just a division by the number of directions? (if so, why are the
diagonals difference divided by sqrt(2)?)
Thanks!
rawfiner
2018-07-02 21:34 GMT+02:00 rawfiner :
> Thank you for all these explanations!
> Seems promising to me.
>
> Cheers,
>
> raw
Thank you Aurélien, that is a great answer.
I think I will try to incorporate this in the weight computation of non
local means to use only "non noisy" pixels in the computations of the
weights, in addition to trying to use this as a (parametric?) mask.
rawfiner
Le samedi 21 ju
/rawfiner/darktable/tree/rawfiner-fix-downscale-algo
(commit 9992cf66fc8510f637e5e5f8ae26c49c2cba2eaa)
The graphic interface in raw denoise module is just here to be able to see
the effect of the algorithm in "fit to screen" zoom mode, and to activate
or desactivate the algorithm. It allows
developed code is of high quality (for instance, funded developers
may be paid after the code review, to ensure some quality of code)
rawfiner
Le samedi 8 septembre 2018, Andreas Schneider a écrit :
> On Saturday, 8 September 2018 07:24:51 CEST Aurélien Pierre wrote:
> > Hi everyon
ese patches (
https://ieeexplore.ieee.org/abstract/document/6307863/). This should
completely solve the "rare patch" issue that we encounter with nlm.
- and of course, make this run as fast as possible for preview!
So basically, a lot of work remaining, but very exciting work ;-)
cheers,
ou want the for loop to be:
for(unsigned k = 0; k < ch * roi_out->width * roi_out->height; k++)
I know that C is hard to learn, so congratulations Aurélien! :-)
rawfiner
Le mer. 12 sept. 2018 à 14:46, Aurélien Pierre
a écrit :
> Hi everyone,
>
> when working with color
Sorry for the spelling mistake, didn't mean "Fist" but "First"
My apologies
cheers,
rawfiner
Le mer. 12 sept. 2018 à 18:59, rawfiner a écrit :
> Hi Aurélien
>
> Fist, thank you for showing me this interesting video.
> I just compiled your branch.
>
> M
Hi
I asked similar questions some time ago, please find bellow the answers
that Johannes gave me.
Regards,
rawfiner
About scales:
> What is the difference between:
> -roi_out->scale
that is the current output region of interest scale, relating what
would happen when you had processed
,
rawfiner
Le jeudi 11 octobre 2018, Jason Polak a écrit :
> I have given a lot of thought about your idea, which is obviously very
> well thought out. Thanks for having this discussion; at the very least,
> it is making me examine editing carefully. Of course I am not a dev so I
> do
of hidden power (especially in case of high ISO images where the
coarse grain noise is more important)!
I hope you will enjoy this as much as I do.
rawfiner
Le dim. 22 juil. 2018 à 20:50, rawfiner a écrit :
> Thank you Aurélien, that is a great answer.
> I think I will try to incorpora
Hello
I see it is code from one of my pull request, though it compiled well on my
computer.
I learned afterwards that we should use gboolean instead of bool.
I will correct this.
Sorry for the mistake
rawfiner
Le 28 oct. 2018 1:45 PM, "André Felipe Carvalho"
a écrit :
Hello,
This
Le 28 oct. 2018 1:58 PM, "Andreas Schneider" a écrit :
On Sunday, 28 October 2018 13:54:01 CET rawfiner wrote:
> Hello
>
> I see it is code from one of my pull request, though it compiled well on
my
> computer.
> I learned afterwards that we should use gboolean instead
rawfiner
Le dimanche 28 octobre 2018, Timur Irikovich Davletshin <
timur.davlets...@gmail.com> a écrit :
> Hello!
>
> I don't know is it just me or dt's fault but when I click online help
> icon and then click something in dt (e.g. import tab) I get crash.
>
The backtrace has very little information unfortunately.
Did you build the code in "release" mode?
If so, could you please build the code in "debug" mode instead, and give
the backtrace obtained in this mode?
Thanks
rawfiner
Le 28 oct. 2018 9:29 PM, "Timur Irikovich Da
Ok. Thank you for the updated backtrace, this one has information I can
use. I will see if I manage to find the source of the bug with this.
rawfiner
Le 29 oct. 2018 10:04 AM, "Timur Irikovich Davletshin" <
timur.davlets...@gmail.com> a écrit :
Actually I'm not building it m
Could you also tell me the language you use inside darktable please?
Is the language of your system supported by darktable?
Thanks
rawfiner
Le lundi 29 octobre 2018, rawfiner a écrit :
> Ok. Thank you for the updated backtrace, this one has information I can
> use. I will see if I man
I mean, is it in english, or another language? (And same question
concerning your operating system)
rawfiner
Le 29 oct. 2018 10:29 AM, "Timur Irikovich Davletshin" <
timur.davlets...@gmail.com> a écrit :
> LANG=C.UTF-8
>
> On Mon, 2018-10-29 at 10:19 +0100, rawfiner
Thank you.
I think I have all I need to fix this.
Have a good day
rawfiner
Le lundi 29 octobre 2018, Timur Irikovich Davletshin <
timur.davlets...@gmail.com> a écrit :
> English both in OS and dt.
>
> On Mon, 2018-10-29 at 10:34 +0100, rawfiner wrote:
> > I mean, is it i
Hi Heiko
I do not have a very detailed feedback to give for now, as I only played
with it a little (maybe latter) ;-)
Still, I wanted to say that I am very impressed, as I obtained great
results very easily.
This is awesome!
Thanks a lot!
rawfiner
Le sam. 10 nov. 2018 à 20:07, Heiko Bauke a
Hi
It seems that Aurélien reported this issue:
https://redmine.darktable.org/issues/12349
rawfiner
Le vendredi 16 novembre 2018, Pascal Obry a écrit :
> Hu Andreas,
>
> > the local contrast laplacian filter doesn't work anymore, it produces
> halos
> > and strange a
images that have very different
white balance.
Otherwise, a setting which works well on a picture with a white balance of
(1,1,1) for instance may not work well on a picture with a white balance of
(1, 1, 2) for instance.
Though, correcting this will break
;
>
It is possible that it is related to this issue indeed, thanks for spoting
that!
rawfiner
> best,
> Bjoern
>
> Am Do., 6. Dez. 2018 um 16:05 Uhr schrieb rawfiner :
>
>> Hi,
>>
>> Looking at the code of denoise profile, I noticed a few things that seems
s clearly not an urgent matter ;-)
> On Fri, Dec 7, 2018 at 4:04 AM rawfiner wrote:
> > For wavelet codes, there is a 2x multiplier on B and R channels, while
> it is not the case for the anscombe transform of non local means:
> > const float wb[3] = {
Hello
This is explained here:
https://www.darktable.org/2013/11/determining-focus-in-lighttable/
cheers,
rawfiner
Le sam. 15 déc. 2018 à 14:48, FF a écrit :
> Hello,
>
> Could someone explain what criteria define the area of sharp focus?
>
> T
Hi,
Is there any plan to update the usermanual to 2.6 soon on darktable.org?
(both the online version and pdfs)
It would be nice to have new modules and other change documentation
available :-)
Cheers,
rawfiner
___
darktable
.
For instance, you may have noticed the coarse grain slider for non local
means in master.
I have some other changes ongoing, you can test some of them on
branch rawfiner-denoise-profile-updates on my git
https://github.com/rawfiner/darktable/tree/rawfiner-denoise-profile-updates
Basically I use it like
urpose of having this).
It seems that the position of the x0 we should take depend on the "a"
parameter of the generalized anscombe transform.
And... I don't know yet how, this is the current state I have ;-)
Cheers,
rawfiner
Le mer. 27 févr. 2019 à 09:57, johannes hanika a écri
against this
solution.
I hope we will find a solution so that amazing changes to this amazing
software can be peacefully discussed in the future.
Cheers,
rawfiner
___
darktable developer mailing list
to unsu
Hi,
Please write a bug report on github to discuss the issue. You can attach
the files there, or put them on a drive if necessary.
Thanks
rawfiner
Le mar. 30 avr. 2019 à 10:28, Florian Hühn a
écrit :
> Hi,
>
> I am currently facing an issue where the red channel of imported
that).
So this has nothing to do with approaches of digital development.
The only question is, with only color accurate modules, are the colors ok
with standard color matrix, or is the colorin module broken
Cheers,
rawfiner
Le mar. 28 mai 2019 à 10:05, François Tissandier <
francois.tissand...
If it is only zooming, I guess this may be relared to the problem that
computations are triggered twice when zooming with the mouse wheel, which
doubles the processing time. If you zoom with the button on the up-left
part of the darkroom, do you experience the same issues?
rawfiner
Le ven. 27
l! -52, devid 0
> 369,710270 [opencl_pixelpipe] could not run module 'denoiseprofile' on
> gpu. falling back to cpu path
>
I unfortunately can't reproduce this issue on my side...
Could you tell me if it is with wavelets mode or non local means mode or
both?
rawfiner
> (onc
Le sam. 28 sept. 2019 à 09:00, Terry Duell a écrit :
> More grist for the mill...
>
> On Sat, 28 Sep 2019 08:58:33 +1000, Terry Duell
> wrote:
>
> > Hello All,
> >
> > On Fri, 27 Sep 2019 09:42:54 +1000, Terry Duell
> > wrote:
>
> > Some more info that may help with this issue.
> > I just downg
ed
out, at 100% it should not make any difference. Anyway, I can try to make
it a bit faster again we zoomed out while trying not to lower preview
accuracy.
Cheers,
rawfiner
>
> Cheers,
> --
> Regards,
> Terry Duell
> _
Please, could you test branch rawfiner-faster-nlmeans-preview of my git
repository https://github.com/rawfiner/darktable
I tried to make preview of non local means faster while keeping the preview
accuracy.
Cheers,
rawfiner
Le sam. 28 sept. 2019 à 09:26, rawfiner a écrit :
>
>
> L
@Terry, you can try with current master (that now includes the patch to
make non local means preview faster)
Cheers,
rawfiner
Le dim. 29 sept. 2019 à 06:45, Terry Duell a écrit :
> On Sun, 29 Sep 2019 09:59:43 +1000, jys
> wrote:
>
> >
> >
> > On Sat, Sep 28, 2019,
Do you have a DR setting enabled on the camera? (Like DR200 or DR400 or DR
auto)
This setting results in underexposed raw images.
You can try adding 1EV or 2EV in the exposure module to compensate for that.
rawfiner
Le sam. 7 déc. 2019 à 08:12, Axel Gerber a écrit :
> Is it possible, not
explain some of the changes.
Also, I will make a video about noise reduction (as usual) hopefully late
december or early january to explain the changes and how to reduce noise
with darktable 3.0.
Cheers,
rawfiner
Le ven. 13 déc. 2019 à 20:56, Bruce Williams a écrit :
> Thanks for the links, guys, m
Hi
Only a guess, but maybe it is used when we display some channels of the
parametric masks, or when we display the masks?
rawfiner
Le sam. 1 févr. 2020 à 13:28, Heiko Bauke a écrit :
> Hi,
>
> all blend modes that operate in Lab space have some special treatment
> for the case t
57 matches
Mail list logo
