Re: [darktable-dev] sharpen module

2019-04-18 Thread jys
On Thu, Apr 18, 2019, at 14:16, Heiko Bauke wrote: > I think, however, deconvolution might also be used as a---let's > say---artistic tool to counteract all the interpolation and averaging > effects that happen along the pixel pipe (demosaic, lens correction, etc.). In that case, maybe immed

Re: [darktable-dev] sharpen module

2019-04-18 Thread jys
On Thu, Apr 18, 2019, at 13:00, Aurélien Pierre wrote: > The sharpening module happens too late in the pipe (after tone curves) > and works in Lab, which is nonsensical (Lab == perceptual model built > upon human vision : that means nothing in optics). I would squeeze it > right after the denoi

Re: [darktable-dev] sharpen module

2019-04-18 Thread Heiko Bauke
Dear Aurélien Am 18.04.19 um 21:59 schrieb Aurélien Pierre: please don't do a deconvolution in the Lab color model. Natural blur is a phenomenon happening to photons and described by a convolution product. If you want to revert it, you need to use a physically meaningful color space, e.g. a li

Re: [darktable-dev] sharpen module

2019-04-18 Thread Heiko Bauke
Dear Pascal, Am 17.04.19 um 23:46 schrieb Pascal Obry: Let's go with that if we are sure the algo are equivalent. Code duplication is not good in the long run. the two implementations of the Gaussian filter work rather differently. Both are certainly not equivalent to each other in a mathemat

Re: [darktable-dev] sharpen module

2019-04-18 Thread Aurélien Pierre
Hi, please don't do a deconvolution in the Lab color model. Natural blur is a phenomenon happening to photons and described by a convolution product. If you want to revert it, you need to use a physically meaningful color space, e.g. a linear one as close as possible to the spectral space. That w

Re: [darktable-dev] sharpen module

2019-04-18 Thread Christian
Hi, suggestion: add more options for the blur. In the following video "Matter machen/surface blur" is used for "perfect sharpening". https://www.youtube.com/watch?v=70eCvD4_aaE Chris Am 17.04.2019 um 20:16 schrieb Heiko Bauke: I just started to implement a simple (non-blind) deconvolution fi

Re: [darktable-dev] sharpen module

2019-04-17 Thread Pascal Obry
Hello Heiko, > Looking at the code of the current unsharp mask method I realized that > the module uses its own implementation of a gaussian blur filter. Is > there any reason not to employ the one in src/common/gaussian.[ch]? Are > there any concerns against simplifying the sharpening modu