Re: [darktable-dev] hotpixel seems to have a problem with an image

2016-07-25 Thread Dan Torop
Hi Marc, That is great! Tobias merged the fix into master branch as of yesterday. Thank you for pointing out the problem... Dan On Sat, Jul 23, 2016, at 11:23 AM, Marc Cousin wrote: > I just applied your patch. It works perfectly now… I don't see a point > in trying to prevent it on already pro

Re: [darktable-dev] hotpixel seems to have a problem with an image

2016-07-23 Thread Marc Cousin
I just applied your patch. It works perfectly now… I don't see a point in trying to prevent it on already processed images, as it works so much better now. Thanks ! On 23/07/2016 02:20, Dan Torop wrote: > There should be a fix for this as PR 1225 > (https://github.com/darktable-org/darktable/pull

Re: [darktable-dev] hotpixel seems to have a problem with an image

2016-07-22 Thread Dan Torop
There should be a fix for this as PR 1225 (https://github.com/darktable-org/darktable/pull/1225). The column # was off by one from the column of the pixel being examined, hence the code was reading the wrong color values from the X-Trans sensor pattern. As hotpixels works by comparing a given pixel

Re: [darktable-dev] hotpixel seems to have a problem with an image

2016-07-21 Thread Marc Cousin
I hope this one works. http://www.filedropper.com/xe021880 Putting the ML back in CC in case someone else is interested :) On 21/07/2016 16:51, Dan Torop wrote: > Hi Marc, > > I just tried to download the example RAF you posted, but it seems to be > expired already? If you're able to send me

[darktable-dev] hotpixel seems to have a problem with an image

2016-07-19 Thread Marc Cousin
Hi, I have a picture (Fuji XE2, XTrans, sorry :) ) with two hot (white) pixels. One of them is perfectly corrected by the hotpixels module, the other not. If I try to raise the strength, several other pixels (which are correct) are corrected that shouldn't (in the red blurry flower). Both pixe