Re: [darktable-dev] Unit Tests

2020-01-20 Thread Martin Burri
Hi Andreas, Thank you very much for your feedback and the offer to review my code. I am willing to support you also on cmocka - should something pop into my eyes. To me, it makes sense to integrate also a code coverage analyzer. I don't have experience there but I will definitely look into t

Re: [darktable-dev] Unit Tests

2020-01-20 Thread Andreas Schneider
On Sunday, 19 January 2020 19:59:30 CET i...@burrima.ch wrote: > Hi David, Hi Martin, > Thank you for your reply. What a co-incidence, I was not aware of that. > That's good news! > > I came to cmocka while analyzing different frameworks and I thought this > might be the most suitable one. I'm

Re: [darktable-dev] Unit Tests

2020-01-19 Thread Greg Hughes
The usual suspect GCC toolchain coverage tool is gcov https://en.wikipedia.org/wiki/Gcov I don't have any experience with it. My Company uses Bullseye, however it is not free or open source. There are code coverage tools around, though I don't know any of them. As a first start I thought

Re: [darktable-dev] Unit Tests

2020-01-19 Thread info
Hi David, Thank you for your reply. What a co-incidence, I was not aware of that. That's good news! I came to cmocka while analyzing different frameworks and I thought this might be the most suitable one. Only had a quick look at your integration, looks similar to mine. There are code cove

Re: [darktable-dev] Unit Tests

2020-01-19 Thread Coding Dave
Hi Martin, Great timing. We have just discussed about unit tests 6 days ago and decided for cmocka as well. There is a test integration here: https://github.com/cryptomilk/darktable/tree/master-cmocka?files=1 We came to cmocka because I realized that I might break a lot of things when I try to f

[darktable-dev] Unit Tests

2020-01-19 Thread info
Dear developers, First of all: thank you so much for your valuable work that you invest into darktable! I really enjoy using this software. I personally think that you could need some help and thus this mail. I am intending to add some unit tests in order to verify the code on a low level. I