Re: [darktable-dev] How to get image preview zoom factor information

2018-07-11 Thread rawfiner
Again, thank you for all this information! This does clear up a lot of things :-) rawfiner 2018-07-11 10:18 GMT+02:00 johannes hanika : > heya, > > On Fri, Jul 6, 2018 at 12:06 AM, rawfiner wrote: > > Hi, > > > > I am still trying to resize raw before demosaicing to speed up raw > > denoising.

Re: [darktable-dev] How to get image preview zoom factor information

2018-07-11 Thread rawfiner
Hi, Thank you for this detailed answer. It helps a lot. Indeed, my module comes before demosaic. I do not want to downscale more than the pipeline usually does, but I would like to perform the downscaling earlier, directly on raw data, as I try to add non-local means in the raw denoise module. For

Re: [darktable-dev] How to get image preview zoom factor information

2018-07-11 Thread johannes hanika
heya, On Fri, Jul 6, 2018 at 12:06 AM, rawfiner wrote: > Hi, > > I am still trying to resize raw before demosaicing to speed up raw > denoising. > > I now get the zoom level using the following code: > float scale = 1.0; > int closeup = dt_control_get_dev_closeup(); > if (piece->pipe->type

Re: [darktable-dev] How to get image preview zoom factor information

2018-07-11 Thread johannes hanika
hi, let me try to fill in some gaps: On Tue, Jul 10, 2018 at 8:32 AM, rawfiner wrote: > Dear all, > > I think that I do not manage to differenciate correctly the role of some > variables. > What is the difference between: > -roi_out->scale that is the current output region of interest scale, re

Re: [darktable-dev] How to get image preview zoom factor information

2018-07-09 Thread rawfiner
Dear all, I think that I do not manage to differenciate correctly the role of some variables. What is the difference between: -roi_out->scale -piece->iscale -self->dev->preview_pipe->iscale And the difference between: -roi_out->width -piece->iwidth -self->dev->preview_pipe->processed_width -self-

Re: [darktable-dev] How to get image preview zoom factor information

2018-07-05 Thread rawfiner
Hi, I am still trying to resize raw before demosaicing to speed up raw denoising. I now get the zoom level using the following code: float scale = 1.0; int closeup = dt_control_get_dev_closeup(); if (piece->pipe->type == DT_DEV_PIXELPIPE_FULL) scale = dt_dev_get_zoom_scale(self->dev, zo

Re: [darktable-dev] How to get image preview zoom factor information

2018-05-10 Thread rawfiner
Thank you for your answer. 2018-05-09 13:22 GMT+02:00 johannes hanika : > heya, > > On Wed, May 9, 2018 at 12:27 PM, rawfiner wrote: > > 2018-05-08 17:16 GMT+02:00 johannes hanika : > >> i'm guessing you want to detect whether you are running a > >> DT_DEV_PIXELPIPE_FULL pipe in darkroom mode (a

Re: [darktable-dev] How to get image preview zoom factor information

2018-05-09 Thread johannes hanika
heya, On Wed, May 9, 2018 at 12:27 PM, rawfiner wrote: > 2018-05-08 17:16 GMT+02:00 johannes hanika : >> i'm guessing you want to detect whether you are running a >> DT_DEV_PIXELPIPE_FULL pipe in darkroom mode (as opposed to >> DT_DEV_PIXELPIPE_PREVIEW or _EXPORT) and then do this downscaling >>

Re: [darktable-dev] How to get image preview zoom factor information

2018-05-09 Thread rawfiner
Thank you for the detailed answer 2018-05-08 17:16 GMT+02:00 johannes hanika : > heya, > > for modules that work on raw data, the full pipeline is unscaled > (hence your constant scale factors). all we do here is provide input > cropped to the region of interest your module requested during the >

Re: [darktable-dev] How to get image preview zoom factor information

2018-05-08 Thread johannes hanika
heya, for modules that work on raw data, the full pipeline is unscaled (hence your constant scale factors). all we do here is provide input cropped to the region of interest your module requested during the modify_roi_in() pass that is run before process() is called (there is a default implementat

[darktable-dev] How to get image preview zoom factor information

2018-05-07 Thread rawfiner
Dear all, I am currently working on a module for denoising at raw level. The first results are very promising in term of denoising quality, but the speed of the module is not as fast as it should be (processing the full image takes about 20 seconds, which is decent for export but too slow for the