Re: [darktable-dev] HSL and RGB scene-referred space

2020-04-11 Thread Harold le Clément
Hello, Thanks a lot for the feedback. Agree, the problem would be only when trying to use the saturation for parametric masking (as the color picker HSL mode is only used for that). Perhaps a cylindrical HSY could be used, but it depends how the saturation is computed (most of the information I

[darktable-dev] HSL and RGB scene-referred space

2020-04-10 Thread Harold le Clément
Hello, In colorspaces.c there is the following code to convert between RGB and HSL: void rgb2hsl(const float rgb[3], float *h, float *s, float *l) { const float r = rgb[0], g = rgb[1], b = rgb[2]; float pmax = fmax(r, fmax(g, b)); float pmin = fmin(r, fmin(g, b)); float delta = (pmax - pm