Re: [darktable-dev] Dt from git cannot sent to trash

Hi, I've created a pull request for this: https://github.com/darktable-org/darktable/pull/1082 Guillaume 2015-12-16 14:13 GMT-05:00 Tobias Ellinghaus : > Am Mittwoch, 16. Dezember 2015, 09:54:12 schrieb Guillaume Benny: >> Hi, >> >> Does the dialog message say: &quo

Re: [darktable-dev] Dt from git cannot sent to trash

Hi, Does the dialog message say: "could not send some_file_name to trash: operation not supported" or something else? The part after the ":" is the part that I'm interested in... It should be something like "operation not supported". To correct this, I see a few options: 1) Add a button to the d

Re: [darktable-dev] [PATCH] Add send_to_trash config

nyone is interested in testing and/or commenting. Guillaume On Mon, Aug 24, 2015 at 8:54 PM, Guillaume Benny wrote: > > Hi, > > I've created a pull request based on the feedback: > https://github.com/darktable-org/darktab

Re: [darktable-dev] [PATCH] Add send_to_trash config

Hi, I've created a pull request based on the feedback: https://github.com/darktable-org/darktable/pull/975 Guillaume On Mon, Aug 24, 2015 at 9:58 AM, Guillaume Benny wrote: > Hi, > > I'll try to create a pull request; I've never used github, I'll try > not t

Re: [darktable-dev] Re: [PATCH] Add send_to_trash config

On Mon, Aug 24, 2015 at 11:41 AM, Guillaume Benny wrote: > On Mon, Aug 24, 2015 at 10:54 AM, David Houlder wrote: >> On 10/08/15 20:00, darktable-dev+h...@lists.darktable.org wrote: >>> >>> +{ >>> + GError *gerror = NULL; >>> + GFile *gfile = NUL

Re: [darktable-dev] Re: [PATCH] Add send_to_trash config

On Mon, Aug 24, 2015 at 10:54 AM, David Houlder wrote: > On 10/08/15 20:00, darktable-dev+h...@lists.darktable.org wrote: >> >> +{ >> + GError *gerror = NULL; >> + GFile *gfile = NULL; >> + int must_unlink = !dt_conf_get_bool("send_to_trash"); >> + >> + if (!must_unlink) >> + { >> +gfile =

Re: [darktable-dev] [PATCH] Add send_to_trash config

acticall for us to review patches as github pull-requests... > > if you're ok with using pull requests, that would be nice to submit it that > way... > > On Sun, Aug 9, 2015 at 8:11 PM, Guillaume Benny wrote: >> >> Hi, >> >> I have been using darktab

Re: [darktable-dev] [PATCH] Add send_to_trash config

exiting buttons remove and delete, > is it in the middle of them? > > Sebastian > > On 08/09/2015 08:11 PM, Guillaume Benny wrote: >> Hi, >> >> I have been using darktable for a few months now and I really like > it. I recently thought of a feature that would be

[darktable-dev] Re: [PATCH] Add send_to_trash config

Hi, I've sent this patch two weeks ago but there are no replies. Should I post this somewhere else? Or maybe it's not the right way to propose those kind of changes? Thanks, Guillaume On Sun, Aug 9, 2015 at 2:11 PM, Guillaume Benny wrote: > > Hi, > > I have been usi

[darktable-dev] [PATCH] Add send_to_trash config

v+unsubscr...@lists.darktable.orgFrom 3728987b1be1841c77b052182e22ec6576d6b007 Mon Sep 17 00:00:00 2001 From: Guillaume Benny Date: Tue, 28 Jul 2015 17:39:40 -0400 Subject: [PATCH] Add send_to_trash config This config send files to trash instead of permanently deleting files on system that supports it.