[PATCH] default to normal pthread mutexes

Yaakov Selkowitz * thread.cc (pthread_mutex::pthread_mutex): Change default type to PTHREAD_MUTEX_NORMAL. (pthread_mutexattr::pthread_mutexattr): Ditto. (pthread_mutex_unlock): Do not fail if mutex is a normal mutex initializer. * include/pthread.h

Re: docs: improve package maintainer instructions

On Sat, 2014-08-02 at 07:27 -0600, Eric Blake wrote: > I noticed that the main link on the cygwin.com left navbar > (https://cygwin.com/setup.html#submitting) has outdated instructions; > rather than duplicate things, I'd rather have a link to the more > up-to-date page > (https://sourceware.org/cy

[PATCH] build PDFs with xmlto (was: Instability with signals and threads)

On 2014-11-21 14:36, Corinna Vinschen wrote: On Nov 21 14:06, Yaakov Selkowitz wrote: On 2014-11-21 10:06, Corinna Vinschen wrote: On Nov 21 16:50, Marco Atzeri wrote: On 11/21/2014 3:43 PM, Corinna Vinschen wrote: On 32-bit. The rebuild of cygwin1.dll requires large number of packages to

[PATCH] qsort_r (pending newlib patch)

Attached. -- Yaakov 2014-12-04 Yaakov Selkowitz doc/ * new-features.xml (ov-new1.7.34): Document qsort_r and __bsd_qsort_r. * posix.xml (std-bsd): Add qsort_r. (std-gnu): Ditto. (std-notes): Add section for qsort_r. cygwin

[PATCH] Export new stdio and stdio_ext functions

These patches export the BSD, GNU, and Solaris stdio extensions (27 in total) recently added to newlib. -- Yaakov 2014-12-18 Yaakov Selkowitz * common.din (__fbufsize, __flbf, __fpending, __freadable, __freading, __fsetlocking, __fwritable, __fwriting, clearerr_unlocked, feof_unlocked

[PATCH] spelling fix for struct passwd

This field is spelled pw_passwd on Linux, and I haven't found a different spelling on other platforms (it is not mandated by POSIX). Patch attached. -- Yaakov 2014-12-18 Yaakov Selkowitz * ntsec.xml (ntsec-logonuser): Fix spelling of pw_passwd field. Index: ntse

[PATCH] cygwin: fix __x86_64__ conditional in stdint.h

Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/ChangeLog| 4 winsup/cygwin/include/stdint.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 550490a..cd2dbb9 100644 --- a/winsup/cygwin/ChangeLog +++ b

[PATCH] cygwin: add GNU basename(3)

winsup/cygwin/ * common.din (__gnu_basename): Export. * path.cc (__gnu_basename): New function. winsup/doc/ * posix.xml (std-gnu): Add basename. (std-notes): Add note about two forms of basename. --- This depends on the newlib patch currently under discussion. winsup/cygwin/common.din | 1 + wi

[PATCH] Fix more typos in ntsec.xml

Signed-off-by: Yaakov Selkowitz --- winsup/doc/ntsec.xml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winsup/doc/ntsec.xml b/winsup/doc/ntsec.xml index b731cd0..d982867 100644 --- a/winsup/doc/ntsec.xml +++ b/winsup/doc/ntsec.xml @@ -863,7 +863,7 @@ the old

Re: [PATCH] Hide sethostname() in unistd.h

On Wed, 2015-06-17 at 22:25 +0200, Christian Franke wrote: > Busybox does not use autoconf or similar. It requires manual platform > specific configuration which does not yet support a missing > sethostname(). After adding HAVE_SETHOSTNAME manually and some other > minor additions, busybox (whic

[PATCH] winsup/cygwin: fix compile of path.cc after basename changes

--- winsup/cygwin/path.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc index 446d746..5eb076f 100644 --- a/winsup/cygwin/path.cc +++ b/winsup/cygwin/path.cc @@ -48,7 +48,7 @@ c: means c:\. */ -#define _BASENAME_DE

[PATCH] winsup/utils: add CPU cache variables to getconf(1)

+++ b/winsup/utils/ChangeLog @@ -1,3 +1,7 @@ +2015-10-22 Yaakov Selkowitz + + * getconf.c (conf_table): Add LEVEL*_CACHE_* variables. + 2015-08-30 Corinna Vinschen * cygcheck.cc (dump_sysinfo): Fix missing commas in products array. diff --git a/winsup/utils/getconf.c b/winsup

Re: [PATCH] winsup/utils: add CPU cache variables to getconf(1)

On Thu, 2015-10-22 at 12:35 -0500, Yaakov Selkowitz wrote: > * getconf.c (conf_table): Add LEVEL*_CACHE_* variables. > --- > winsup/utils/ChangeLog | 4 > winsup/utils/getconf.c | 15 +++ > 2 files changed, 19 insertions(+) Approved off-list, committed as 505812d. -- Yaakov

[PATCH] cygwin: export rpmatch(3)

winsup/cygwin/ * common.din (rpmatch): Export. * include/cygwin/version.h (CYGWIN_VERSION_API_MINOR): Bump. winsup/doc/ * new-features.xml (ov-new2.4): New section. Document rpmatch. * posix.xml (std-bsd): Add rpmatch. Signed-off-by: Yaakov Selkowitz --- This depends on the newlib patch sent to

[PATCH] cygwin: fix errors with GCC 5

(ilockcmpexch, ilockcmpexch64): Ditto. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/exceptions.cc | 2 +- winsup/cygwin/include/cygwin/config.h | 1 + winsup/cygwin/winbase.h | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin

[PATCH] cygwin: update child info magic

winsup/cygwin/ * child_info.h (CURR_CHILD_INFO_MAGIC): Update. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/child_info.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/child_info.h b/winsup/cygwin/child_info.h index ddd5b8b..c11040c 100644

Re: [PATCH] cygwin: update child info magic

On 2016-02-12 03:33, Corinna Vinschen wrote: On Feb 11 20:38, Yaakov Selkowitz wrote: winsup/cygwin/ * child_info.h (CURR_CHILD_INFO_MAGIC): Update. This needs an explanation. CHILD_INFO_MAGIC is still 0x30ea98f6U for me. Hmmm, in that case it's either one of the patc

[PATCH v2] cygwin: fix errors with GCC 5

/cygwin/ * exceptions.cc (exception::handle): Change debugging to int to fix an always-true boolean comparison warning. * include/cygwin/config.h (__getreent): Mark gnu_inline. * winbase.h (ilockcmpexch, ilockcmpexch64): Ditto. Signed-off-by: Yaakov Selkowitz

Re: [PATCH] cygwin: update child info magic

On 2016-02-12 11:18, Corinna Vinschen wrote: On Feb 12 10:53, Yaakov Selkowitz wrote: On 2016-02-12 03:33, Corinna Vinschen wrote: On Feb 11 20:38, Yaakov Selkowitz wrote: winsup/cygwin/ * child_info.h (CURR_CHILD_INFO_MAGIC): Update. This needs an explanation

[PATCH v2] cygwin: work around GCC 5 preprocessor changes

GCC 5 adds #line directives (and hence extra newlines) for macros expansions, which confuses cygmagic. Using the -P flag avoids them entirely. https://cygwin.com/ml/cygwin-patches/2016-q1/msg00016.html Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/cygmagic | 2 +- 1 file changed, 1

[PATCH] cygwin: accept SIGIOT as alias of SIGABRT

winsup/cygwin/ * include/cygwin/signal.h (SIGIOT): Define SIGIOT in terms of SIGABRT. * strsig.cc (struct sigdesc): Ditto. winsup/doc/ * utils.xml (kill): Document SIGIOT. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/cygwin/signal.h | 1

[PATCH] cygwin: Export clog10, clog10f

winsup/cygwin/ * common.din: Add clog10, clog10f. * include/cygwin/version.h (CYGWIN_VERSION_API_MINOR): Bump. winsup/doc/ * posix.xml (std-gnu): Add clog10, clog10f. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/common.din | 2

[PATCH] Cygwin: define byteswap.h inlines as macros

The bswap_* "functions" are macros in glibc, so they may be tested for by the preprocessor (e.g. #ifdef bswap_16). Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/byteswap.h | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/winsup/cygw

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

On 2016-03-15 04:03, Corinna Vinschen wrote: On Mar 14 22:13, Yaakov Selkowitz wrote: The bswap_* "functions" are macros in glibc, so they may be tested for by the preprocessor (e.g. #ifdef bswap_16). ACK. While we're at it, what about converting the types to implicit ty

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

On 2016-03-15 04:22, Corinna Vinschen wrote: On Mar 15 04:14, Yaakov Selkowitz wrote: On 2016-03-15 04:03, Corinna Vinschen wrote: On Mar 14 22:13, Yaakov Selkowitz wrote: The bswap_* "functions" are macros in glibc, so they may be tested for by the preprocessor (e.g. #ifdef bswap

Re: [PATCH] Cygwin: define byteswap.h inlines as macros

On 2016-03-15 06:46, Corinna Vinschen wrote: On Mar 15 11:55, Václav Haisman wrote: Would it not be better to leave the original functions as they were and simply use these defines? #define bswap_16 bswap_16 #define bswap_32 bswap_32 #define bswap_64 bswap_64 I believe this is valid C and C++.

Re: [PATCH 4/5] Don't build utils/lsaauth when cross compiling.

On 2016-03-21 15:00, Peter Foley wrote: On Mon, Mar 21, 2016 at 3:58 PM, Corinna Vinschen wrote: Again, I'm cross compiling all the time since I build Cygwin on Linux for development and package building, and I'm certianly not the only person doing that. This is the default case. Not building

Re: [PATCH v2 1/5] Add nonnull annotation to posix_memalign.

On 2016-03-21 12:15, Peter Foley wrote: GCC 6.0+ asserts that the memptr argument to the builtin function posix_memalign is nonnull. Add the necessary annotation to the prototype and remove the now unnecessary check to fix a warning. newlib/Changelog newlib/libc/include/stdlib.h: Annotate arg to

[PATCH] cygwin: export __getpagesize

---getpagesize.html Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/common.din | 1 + winsup/cygwin/include/cygwin/shm.h | 5 +++-- winsup/cygwin/include/cygwin/version.h | 3 ++- winsup/cygwin/shm.cc | 4 4 files changed, 10 insertions(+), 3 deletions

Re: [PATCH 4/6] forkables: Protect fork against dll-, exe-updates.

On 2016-03-30 13:53, Michael Haubenwallner wrote: To support in-cygwin package managers, the fork() implementation must not rely on .exe and .dll files to stay in their original location, as the package manager's job is to replace these files. Instead, we use the hardlinks to the original binari

Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.

On 2016-04-01 07:13, Corinna Vinschen wrote: On Mar 31 12:18, Peter Foley wrote: G++ 6.0 asserts that the "this" pointer is non-null for member functions. Refactor methods that check if this is non-null to be static where necessary, and remove the check where it is unnecessary. No, sorry, but

[PATCH 0/4] Various fixes for 2.5.0

An assortment of unrelated patches discovered in the process of rebuilding GCC with 2.5.0-0.10. Yaakov Selkowitz (4): Feature test macros overhaul: Cygwin pthread.h cygwin/math: make isinf functions signed cygwin: update sysconf for new features winsup/utils: port getconf to 64-bit

[PATCH 1/4] Feature test macros overhaul: Cygwin pthread.h

As a Cygwin-specific header, there is no need to guard functions based on capability macros. Instead, guard several blocks based on additions or removals in later versions of POSIX.1, along with a few which are only XSI or GNU extensions. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin

[PATCH 2/4] cygwin/math: make isinf functions signed

glibc returns -1 for negative infinity: http://man7.org/linux/man-pages/man3/isinfl.3.html https://sourceware.org/bugzilla/show_bug.cgi?id=15367 Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/math/isinf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/winsup

[PATCH 4/4] winsup/utils: port getconf to 64-bit

The available specifications obviously differ on 32-bit and 64-bit, as already handled in . Signed-off-by: Yaakov Selkowitz --- winsup/utils/getconf.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/winsup/utils/getconf.c b/winsup/utils

[PATCH 3/4] cygwin: update sysconf for new features

POSIX spawn and thread barriers have since been added. Also fix a typo in _POSIX2_C_DEV (result is the same). Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/sysconf.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/sysconf.cc b/winsup/cygwin

[PATCH] cygwin: include sys/types.h in sys/xattr.h

Using libattr's requires consumers to explicitly include first, but glibc's header in sys/ already contains the include. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/sys/xattr.h | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/cygwin/include/sys/xattr.h b/win

[PATCH] Cygwin: create separate bits/byteswap.h

Match glibc behaviour to expose the public bswap_* macros only with an explicity #include ; #include'ing should not expose them. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/bits/byteswap.h | 37 +++ winsup/cygwin/include/byteswap.h

[PATCH] Feature test macros overhaul: Cygwin signal.h

This should match newlib's . Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/cygwin/signal.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/include/cygwin/signal.h b/winsup/cygwin/include/cygwin/signal.h index f304

[PATCH] Export XSI sigpause

the given value. Signed-off-by: Yaakov Selkowitz --- newlib/libc/include/sys/signal.h | 14 +- winsup/cygwin/common.din | 1 + winsup/cygwin/include/cygwin/version.h | 3 ++- winsup/cygwin/signal.cc| 12 winsup/doc

[PATCH] cygwin: export strverscmp, add versionsort

Signed-off-by: Yaakov Selkowitz --- This depends on the newlib strverscmp patch. winsup/cygwin/common.din | 2 ++ winsup/cygwin/include/cygwin/version.h | 3 ++- winsup/cygwin/include/sys/dirent.h | 1 + winsup/cygwin/release/2.8.1| 2 ++ winsup/cygwin/scandir.cc

[PATCH] Cygwin: fix signal.h with _POSIX_C_SOURCE=1

struct sigaction is POSIX.1-1990 but siginfo_t, which is used by its sa_sigaction member, is POSIX.1b-1993. Therefore it needs to be guarded as well, and as part of a union, the struct size is protected. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/cygwin/signal.h | 2 ++ 1 file

[PATCH] Cygwin: fix guard on struct siginfo_t

Add line breaks to make it clearer that the struct packing applies to more than one struct. Signed-off-by: Yaakov Selkowitz --- We probably should consider a 2.8.2 sooner rather than later. winsup/cygwin/include/cygwin/signal.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH] cygwin: Export explicit_bzero

This was added to newlib together with timingsafe_*cmp but never exported. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/common.din | 1 + winsup/cygwin/include/cygwin/version.h | 3 ++- winsup/doc/posix.xml | 1 + 3 files changed, 4 insertions(+), 1 deletion

[PATCH] cygwin: Document crypt_r

Signed-off-by: Yaakov Selkowitz --- winsup/doc/posix.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/doc/posix.xml b/winsup/doc/posix.xml index 6e96272b7..c99e003ba 100644 --- a/winsup/doc/posix.xml +++ b/winsup/doc/posix.xml @@ -1286,6 +1286,7 @@ also IEEE Std 1003.1-2008 (POSIX

Re: [PATCH] Fix possible segmentation fault in strnstr() on 64-bit systems

On 2017-09-13 10:44, Johannes Schindelin wrote: > As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr() > implementation was replaced by a version that segfaults (at least > sometimes) on 64-bit systems. > > The reason: the new implementation uses memmem(), and the prototype of > memmem(

[PATCH 1/2] Feature test macros overhaul: Cygwin netdb.h

herror etc. are MISC, rcmd etc. are BSD, addrinfo functions are POSIX.1-2001, except for IDN functionality which is GNU. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/netdb.h | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/winsup

[PATCH 2/2] cygwin: fix gethostbyaddr argument types

The first argument of gethostbyaddr needs to accept a generic pointer to be compatible with e.g. struct in_addr *. This caused an issue compiling krb5-1.15. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/netdb.h | 2 +- winsup/cygwin/net.cc | 4 ++-- 2 files changed, 3

[PATCH] Feature test macros overhaul: Cygwin limits.h, part 2

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html https://sourceware.org/ml/newlib/2017/msg01133.html Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/limits.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a

[PATCH] cygwin: define _POSIX_TIMEOUTS

Since commit 8128f5482f2b1889e2336488e9d45a33c9972d11, we have all the non-tracing functions listed in posixoptions(7). The tracing functions are gated by their own option, and are obsolecent anyway. Signed-off-by: Yaakov Selkowitz --- newlib/libc/include/sys/features.h | 2 +- winsup/cygwin

[PATCH 2/2] cygwin: add Object Size Checking to sys/socket.h

Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/ssp/socket.h | 20 winsup/cygwin/include/sys/socket.h | 4 2 files changed, 24 insertions(+) create mode 100644 winsup/cygwin/include/ssp/socket.h diff --git a/winsup/cygwin/include/ssp/socket.h b/winsup

[PATCH 1/2] cygwin: add Object Size Checking to sys/poll.h

Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/ssp/poll.h | 26 ++ winsup/cygwin/include/sys/poll.h | 4 2 files changed, 30 insertions(+) create mode 100644 winsup/cygwin/include/ssp/poll.h diff --git a/winsup/cygwin/include/ssp/poll.h b/winsup/cygwin

[PATCH] cygwin: export wmempcpy

Signed-off-by: Yaakov Selkowitz --- Obviously this depends on the newlib implementation patch. winsup/cygwin/common.din | 1 + winsup/cygwin/include/cygwin/version.h | 3 ++- winsup/doc/posix.xml | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] Implement sigtimedwait (revised)

On 2017-12-18 04:48, Corinna Vinschen wrote: > On Dec 18 01:34, Mark Geisert wrote: >> On Mon, 18 Dec 2017, Corinna Vinschen wrote: >>> Hi Mark, >> [...] >>> as I wrote on Friday, the patch looks good to me. I just need a >>> contributors license agreement from you per the "Before you get started"

[PATCH] cygwin: add LFS_CFLAGS etc. to confstr/getconf

These are used, for instance, when cross-compiling the Linux kernel. Signed-off-by: Yaakov Selkowitz --- newlib/libc/include/sys/unistd.h | 4 winsup/cygwin/sysconf.cc | 6 +- winsup/utils/getconf.c | 4 3 files changed, 13 insertions(+), 1 deletion(-) diff

[PATCH] cygwin: make sys/socket.h completely visible from netinet/in.h

While POSIX mandates that certain socket types shall be defined by the inclusing of , it also says that this header may also make visible all symbols. Glibc does this, and without out it, some packages end up requiring an additional #include . Signed-off-by: Yaakov Selkowitz --- winsup/cygwin

Re: [PATCH] cygwin: add LFS_CFLAGS etc. to confstr/getconf

On 2018-01-16 03:27, Corinna Vinschen wrote: > On Jan 15 21:19, Yaakov Selkowitz wrote: >> These are used, for instance, when cross-compiling the Linux kernel. >> >> Signed-off-by: Yaakov Selkowitz >> --- >> newlib/libc/include/sys/unistd.h | 4 >>

[PATCH] cygwin: add asm/bitsperlong.h, dummy asm/posix_types.h headers

These changes are necessary for cross-compiling the Linux kernel. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/asm/bitsperlong.h | 18 ++ winsup/cygwin/include/asm/posix_types.h | 14 ++ winsup/cygwin/include/asm/types.h | 2 ++ 3 files changed

[PATCH 0/2] catgets APIs, gencat tool

... none required And the resulting binary should show catclose/catgets/catopen imports from cygwin1.dll, not cyggetcats1.dll. 4) Install this tcsh, then run an invalid command, e.g.: $ LANG=fr_FR tcsh -c '()' Commande nulle incorrecte. Yaakov Selkowitz (2): cygwin: add catopen, catgets

[PATCH 1/2] cygwin: add catopen, catgets, catclose

The implementation is taken from FreeBSD with #ifdef __CYGWIN__ modifications. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/Makefile.in | 1 + winsup/cygwin/common.din | 3 + winsup/cygwin/include/cygwin/version.h | 3 +- winsup/cygwin/include/nl_types.h

[PATCH 2/2] cygwin: add gencat tool

This is needed for compiling catalog files used in catgets(3) calls. Signed-off-by: Yaakov Selkowitz --- winsup/utils/Makefile.in | 2 +- winsup/utils/gencat.c| 696 +++ 2 files changed, 697 insertions(+), 1 deletion(-) create mode 100644

[PATCH v2 0/3] catgets APIs, gencat tool

... none required And the resulting binary should show catclose/catgets/catopen imports from cygwin1.dll, not cyggetcats1.dll. 4) Install this tcsh, then run an invalid command, e.g.: $ LANG=fr_FR tcsh -c '()' Commande nulle incorrecte. Yaakov Selkowitz (3): Guard langinfo.h nl_item fro

[PATCH v2 3/3] cygwin: add gencat tool

This is needed for compiling catalog files used in catgets(3) calls. Signed-off-by: Yaakov Selkowitz --- winsup/utils/Makefile.in | 2 +- winsup/utils/gencat.c| 696 +++ 2 files changed, 697 insertions(+), 1 deletion(-) create mode 100644

[PATCH v2 1/3] Guard langinfo.h nl_item from multiple typedefs

This is a prerequisite of adding nl_types.h support to Cygwin. Signed-off-by: Yaakov Selkowitz --- newlib/libc/include/langinfo.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/newlib/libc/include/langinfo.h b/newlib/libc/include/langinfo.h index 59381d6b6..458b92565 100644 --- a/newlib

[PATCH v2 2/3] cygwin: add catopen, catgets, catclose

The implementation is taken from FreeBSD with #ifdef __CYGWIN__ modifications. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/Makefile.in | 1 + winsup/cygwin/common.din | 3 + winsup/cygwin/include/cygwin/version.h | 3 +- winsup/cygwin/include/nl_types.h

[PATCH v2 4/4] cygwin: update docs for 2.10.0

Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/release/2.10.0 | 27 +++ winsup/doc/new-features.xml | 27 ++- winsup/doc/posix.xml | 6 +++--- 3 files changed, 56 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/release/2.10.0

Re: [PATCH] cygwin: make sys/socket.h completely visible from netinet/in.h

On 2018-01-16 03:30, Corinna Vinschen wrote: > You don't explain the incentive behind removing sys/time.h. POSIX does not mention the inclusion of in or , nor is there anything in the latter two that would require the former. I can make this clearer in the commit message. > Sure this doesn't

Re: [PATCH v2 0/3] catgets APIs, gencat tool

On 2018-01-19 04:19, Corinna Vinschen wrote: > On Jan 18 23:58, Yaakov Selkowitz wrote: >> This adds FreeBSD-derived implementations to replace the glibc-derived >> standalone implementation shipped in the catgets package. An integrated >> implementation avoids the need t

Re: [PATCH v2 0/3] catgets APIs, gencat tool

On 2018-01-19 13:04, Corinna Vinschen wrote: > Patch is fine, but I'd prefer if the whitespace problems are fixed > first, even if they are from upstream: Fixed. > Are you going to provide a catgets deprecation package? Yes. -- Yaakov signature.asc Description: OpenPGP digital signature

[PATCH] cygwin: Declare pthread_rwlock_timedrdlock, pthread_rwlock_timedwrlock

These were added in commit 8128f5482f2b1889e2336488e9d45a33c9972d11 but without their public declarations. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/include/pthread.h | 4 1 file changed, 4 insertions(+) diff --git a/winsup/cygwin/include/pthread.h b/winsup/cygwin/include

Re: [PATCH v2 0/3] catgets APIs, gencat tool

On 2018-01-19 13:26, Yaakov Selkowitz wrote: > On 2018-01-19 13:04, Corinna Vinschen wrote: >> Are you going to provide a catgets deprecation package? > > Yes. Done. -- Yaakov signature.asc Description: OpenPGP digital signature

[PATCH] Cygwin: fix build with GCC 7

GCC 7 is able to see straight through this trick, so use a more formal method to avoid the warning. Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/random.cc | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/winsup/cygwin/random.cc b/winsup/cygwin/random.cc

Re: Fix declaration of pthread_rwlock_* functions

On 2018-05-31 03:06, Corinna Vinschen wrote: From 4940baac08cd9339d771d9db90a880c61610ae4c Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Wed, 30 May 2018 16:19:01 -0400 Subject: [PATCH] Declare the pthread_rwlock_* functions if __cplusplus >= 201402L Some of these functions are used in the

Re: [PATCH 0/5] Implement clearenv

On 2018-06-04 14:36, Ken Brown wrote: 2. I guarded the declaration of clearenv() with __GNU_VISIBLE, but again I'm not sure about this. On the one hand, clearenv() is a GNU extension, so __GNU_VISIBLE would seem to be the right guard. On the other hand, glibc declares clearenv() if _

Re: [PATCH 3/5] Cygwin: Implement the GNU extension clearenv

On 2018-06-04 14:36, Ken Brown wrote: --- a/winsup/cygwin/include/cygwin/stdlib.h +++ b/winsup/cygwin/include/cygwin/stdlib.h @@ -22,6 +22,7 @@ void setprogname (const char *); #if __GNU_VISIBLE char *canonicalize_file_name (const char *); +int clearenv (); #endif This should be in a

[PATCH 0/1] Update _PC_ASYNC_IO return value

wing patch so this doesn't get lost. Yaakov Selkowitz (1): Cygwin: fpathconf: update _PC_ASYNC_IO return value winsup/cygwin/fhandler.cc | 1 + 1 file changed, 1 insertion(+) -- 2.17.1

[PATCH 1/1] Cygwin: fpathconf: update _PC_ASYNC_IO return value

Signed-off-by: Yaakov Selkowitz --- winsup/cygwin/fhandler.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/cygwin/fhandler.cc b/winsup/cygwin/fhandler.cc index ded12cc44..22dbdb05d 100644 --- a/winsup/cygwin/fhandler.cc +++ b/winsup/cygwin/fhandler.cc @@ -1875,6 +1875,7

[PATCH] Cygwin: add secure_getenv

Signed-off-by: Yaakov Selkowitz --- This is being used more frequently. Since we don't have Linux capabilities, setuid/setgid is the only condition we have to check. newlib/libc/include/stdlib.h | 3 +++ winsup/cygwin/common.din | 1 + winsup/cygwin/envir

Re: [PATCH] Cygwin: add secure_getenv

On Tue, 2019-02-19 at 12:59 +0100, Corinna Vinschen wrote: > On Feb 19 12:43, Corinna Vinschen wrote: > > On Feb 18 23:09, Yaakov Selkowitz wrote: > > > Signed-off-by: Yaakov Selkowitz > > > --- > > > This is being used more frequently. Since we don't hav

[PATCH] cygcheck: expand common_apps list

An increasing number of tools are being included in Windows which have the same names as those included in Cygwin packages. Indicating which one is first in PATH can be helpful in diagnosing behavioural discrepencies between them. Also, fix the alphabetization of ssh. --- winsup/utils/cygcheck.c

Re: [PATCH] cygcheck: expand common_apps list

On Sun, 2019-05-26 at 00:49 -0600, Brian Inglis wrote: > To a degree, depends on installed Cygwin packages and Windows features, but I > also have in both Cygwin /{,{,usr/}s}bin and /Windows/{,System32{,/OpenSSH}/: > > {"certutil", 0}, > {"comp", 0}, > {"ftp", 0}, >

[PATCH v2] cygcheck: expand common_apps list

An increasing number of tools are being included in Windows which have the same names as those included in Cygwin packages. Indicating which one is first in PATH can be helpful in diagnosing behavioural discrepencies between them. Also, fix the alphabetization of ssh. --- winsup/utils/cygcheck.c

Re: [PATCH v2 1/1] Cygwin: console: Revive Win7 compatibility.

ex ed8c98d1c..e7014422b 100644 > --- a/winsup/cygwin/select.cc > +++ b/winsup/cygwin/select.cc > @@ -1209,7 +1209,6 @@ peek_pty_slave (select_record *s, bool from_select) > { > if (ptys->is_line_input ()) > { > -#define INREC_SIZE (65536 / sizeof (INPUT_RECORD)) >

Re: [PATCH] Ensure PSAPI_VERSION is 1 when building ldd

On Wed, 2021-05-26 at 17:51 +0100, Jon Turney wrote: > On 26/05/2021 10:04, Corinna Vinschen wrote: > > On May 25 22:37, Jon Turney wrote: > > > On 22/05/2021 16:08, Jon Turney wrote: > > > > On 20/05/2021 19:05, Corinna Vinschen wrote: > > > > > Hi Jon, > > > > > > > > > > On May 20 18:46, Jon Tu

[PATCH] Cygwin: do not build MinGW testsuite/cygrun --with-cross-bootstrap

--- winsup/testsuite/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winsup/testsuite/Makefile.am b/winsup/testsuite/Makefile.am index 4b8c7dbb7..ac68934d0 100644 --- a/winsup/testsuite/Makefile.am +++ b/winsup/testsuite/Makefile.am @@ -61,4 +61,6 @@ EXTRA_DEJAGNU_SITE_CONFIG = s

Re: [PATCH 7/7] Cygwin: remove miscellaneous 32-bit code

On Thu, 2022-06-09 at 17:23 +0200, Corinna Vinschen wrote: > On May 29 17:26, Ken Brown wrote: > > On 5/29/2022 9:39 AM, Jon Turney wrote: > > > On 26/05/2022 20:17, Ken Brown wrote: > > > >   winsup/cygwin/autoload.cc    | 136 - > > > > -- > > > > > > Looks good. >

Re: [PATCH] cygwin: doc: Add keywords for ACE order issues

rder unchanged, but pressing OK will cause Windows to canonicalize the order of the ACEs, thereby invalidating POSIX compatibility. -- Yaakov Selkowitz Senior Software Engineer - Platform Enablement Red Hat, Inc.

Re: [PATCH] Use automake (v3)

On Wed, 2020-12-02 at 18:03 +, Jon Turney wrote: > On 02/12/2020 17:05, Corinna Vinschen via Cygwin-patches wrote: > > On Dec 2 15:36, Jon Turney wrote: > > > On 01/12/2020 09:18, Corinna Vinschen wrote: > > > > What bugs me is that the mingw executables are built in > > > > utils/mingw, > > >