till needs to allow users to write into the /tmp/ directory.
This is the case in the context of Git for Windows, where the
Cygwin (MSys2) root directory lives inside C:\Program Files and hence
/tmp/ would not be writable otherwise.
Signed-off-by: Johannes Schindelin
---
wins
d explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/cygheap.h | 3 ++-
winsup/cygwin/uinfo.cc | 47 +++
winsup/doc/ntsec.xml| 20
3 files changed, 69 insertions(+), 1 delet
Hi Corinna,
On Tue, 20 Oct 2015, Corinna Vinschen wrote:
> Preliminaries: we need a copyright assignment from you before being able
> to include your patches. Please see https://cygwin.com/assign.txt.
Thanks for pointing that out. It is in the works.
> On Sep 16 09:35, Johannes S
Hi Corinna,
On Wed, 21 Oct 2015, Corinna Vinschen wrote:
> On Oct 20 13:47, Johannes Schindelin wrote:
> > On Tue, 20 Oct 2015, Corinna Vinschen wrote:
> > > On Sep 16 09:35, Johannes Schindelin wrote:
> > >
> > > > By specifying
> > > >
&g
Hi Corinna,
On Wed, 21 Oct 2015, Corinna Vinschen wrote:
> On Sep 16 15:06, Johannes Schindelin wrote:
> > * uinfo.cc (cygheap_pwdgrp::get_home): Offer an option in
> > nsswitch.conf that let's the environment variable HOME (or
> > HOMEDRIVE & HOMEPA
Hi Corinna,
On Fri, 23 Oct 2015, Corinna Vinschen wrote:
> On Oct 23 11:10, Corinna Vinschen wrote:
> > On Oct 22 17:38, Johannes Schindelin wrote:
> > >
> > > On Wed, 21 Oct 2015, Corinna Vinschen wrote:
> > >
> > > > On Sep 16 15:06, Johan
till needs to allow users to write into the /tmp/ directory.
This is the case in the context of Git for Windows, where the
Cygwin (MSys2) root directory lives inside C:\Program Files and hence
/tmp/ would not be writable otherwise.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/include/sys
... and here is the interdiff vs v1 (compare also to the 'pseudo Pull
Request' at
https://github.com/dscho/msys2-runtime/compare/tempfs-cygwin-v1-rebased...tempfs-cygwin-v2):
diff --git a/winsup/cygwin/include/sys/mount.h
b/winsup/cygwin/include/sys/mount.h
index 458cf80..ec92794 100644
--- a/wins
Hi Corinna,
On Tue, 1 Dec 2015, Corinna Vinschen wrote:
> On Dec 1 15:02, Johannes Schindelin wrote:
> > * mount.cc (mount_info::from_fstab_line): support mounting the
> > current user's temp folder as /tmp/. This is particularly
> > useful a feature w
determine the home directory, and it
also allows users to override the home directory easily (e.g. in case
that their real home directory is a network share that is not all that
well handled by some commands such as cmd.exe's cd command).
Sorry for sending out v2 so late...!
Johannes Schindel
Windows user database.
Of course this scheme needs to be opt-in. For that reason, it needs
to be activated explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/cygheap.h | 3 ++-
winsup/cygwin/uinfo.cc | 49 +++
We should not blindly set the home directory of the SYSTEM account to
/home/SYSTEM, especially not when that value disagrees with what is
configured via the `db_home` line in the `/etc/nsswitch.conf` file.
This fixes https://github.com/git-for-windows/git/issues/435
Signed-off-by: Johannes
keys repeatedly.
The full Git for Windows bug report is here:
https://github.com/git-for-windows/git/issues/711
Let's just teach the get_cons_readahead_valid() method to handle a
depleted readahead buffer correctly.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/fhandler.
Hi Thomas,
On Tue, 5 Apr 2016, Thomas Wolff wrote:
> > > Betreff: Re: [PATCH] Be truthful about reporting whether readahead is
> > > available
> > >
> > > Thomas?
> > >
> > > Any input?
> > >
> Yes, let's fix the patch so. Sorry for the flaw.
No big deal, thanks for the ACK!
Ciao,
Johannes
, let's just
double the area we search for said byte for good measure.
Signed-off-by: Johannes Schindelin
---
Published-As: https://github.com/dscho/msys2-runtime/releases/tag/fast-cwd-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime fast-cwd-v1
winsup/cygwin/path.cc | 4 ++
Hi Corinna,
On Wed, 11 Jan 2017, Corinna Vinschen wrote:
> On Jan 11 14:21, Johannes Schindelin wrote:
> > A *very* recent Windows build adds more code to the preamble of
> > RtlGetCurrentDirectory_U() so that the previous heuristic failed to
> > find the call t
.
Reported as https://github.com/Alexpux/MINGW-packages/issues/2879 in
the MSYS2 project.
Cc: Sichen Zhao <1473996...@qq.com>
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-strnstr-segfault-v1
Fetch-It-Via: git fetch https://github.com
Hi Yaakov,
On Wed, 13 Sep 2017, Yaakov Selkowitz wrote:
> On 2017-09-13 10:44, Johannes Schindelin wrote:
> > As of f22054c94d (Modify strnstr.c., 2017-08-30), the strnstr()
> > implementation was replaced by a version that segfaults (at least
> > sometimes) on 64-bit
Apparently I ran afoul of some overzealous spam filter:
SMTP error from remote server for TEXT command, host: sourceware.org
(209.132.180.131) reason: 552 spam score exceeded threshold
-- Forwarded message --
Date: Thu, 18 Jul 2019 11:01:33 +0200 (CEST)
From: Johannes Schindelin
Hi,
On Fri, 28 Feb 2020, Jon Turney wrote:
> Mentioning the stack pointer in the clobber list is now a gcc warning.
>
> We never wanted gcc to try to restore %esp after this (x86-specific)
> asm, since the whole point of the inline asm here is to adjust %esp to
> satisfy alignment, so remove %esp
that more gracefully: if the process exited without
signaling, we cannot use the pseudo console. In that case, let's just
fall back to not using it.
Signed-off-by: Johannes Schindelin
---
It took me three days to bisect why my test build of the MSYS2
runtime hung Min
Hi Corinna,
On Wed, 26 Aug 2020, Corinna Vinschen wrote:
> On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote:
> > When Cygwin sets console titles on Win10 (has_con_24bit_colors &&
> > !con_is_legacy),
> > `WriteConsoleA` is used and causes an error if:
> > 1. the environment variable of `LANG` is `*
, i.e. in v3.0.x), it is clear to me that using
ASCII by default is not desirable.
So here are patches to address this. Incidentally, this addresses quite a
few tickets in the MSYS2 and Git for Windows projects.
Johannes Schindelin (3):
fhandler_pty_slave::setup_locale: fix typo
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/fhandler_tty.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 6294e2c20..b3458595a 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin
.com/msys2/MSYS2-packages/issues/2012,
https://github.com/rust-lang/cargo/issues/8369,
https://github.com/git-for-windows/git/issues/2734,
https://github.com/git-for-windows/git/issues/2793,
https://github.com/git-for-windows/git/issues/2792, and possibly quite a
few others.
Signed-off-by: Johannes
ng.sh` essentially sets `LANG=$(locale -uU)`
(where the `-U` says that `.UTF-8` should be appended). Meaning: we
_really_ want to use the UTF-8 code page.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/fhandler_tty.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/winsup/c
Hi,
On Tue, 1 Sep 2020, Johannes Schindelin wrote:
> When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is
> correct, but after that (at least if Pseudo Console support is enabled),
> we try to find the default code page for that `LCID`, which is ASCII
> (437). Subseque
Hi Takashi,
On Wed, 2 Sep 2020, Takashi Yano via Cygwin-patches wrote:
> On Wed, 2 Sep 2020 10:30:14 +0200
> Corinna Vinschen wrote:
> > On Sep 1 18:19, Johannes Schindelin wrote:
> > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is
> > > correc
Hi Takashi,
On Wed, 2 Sep 2020, Takashi Yano wrote:
> On Wed, 2 Sep 2020 08:26:04 +0200 (CEST)
> Johannes Schindelin wrote:
> > Hi Takashi,
> >
> > On Wed, 2 Sep 2020, Takashi Yano via Cygwin-patches wrote:
> >
> > > On Wed, 2 Sep 2020 10:30:14 +0200
>
Hi Takashi,
On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote:
> Hi Johannes and Corinna,
>
> On Tue, 1 Sep 2020 18:19:16 +0200 (CEST)
> Johannes Schindelin wrote:
>
> > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is
> > correct, but aft
Hi,
On Mon, 7 Sep 2020, Takashi Yano via Cygwin-patches wrote:
> On Mon, 7 Sep 2020 10:26:33 +0200
> Corinna Vinschen wrote:
> > Hi Takashi,
> > On Sep 5 17:43, Takashi Yano via Cygwin-patches wrote:
> > > On Fri, 4 Sep 2020 21:22:35 +0200
> > > Corinna Vinschen wrote:
> > >
> > > > Btw., the ma
Hi Takashi,
On Sat, 5 Sep 2020, Takashi Yano wrote:
> On Fri, 4 Sep 2020 08:23:42 +0200 (CEST)
> Johannes Schindelin wrote:
> >
> > On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote:
> >
> > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST)
> > > Joh
Hi Corinna,
On Tue, 23 Mar 2021, Corinna Vinschen wrote:
> On Mar 22 16:51, Johannes Schindelin via Cygwin-patches wrote:
> > When installing e.g. Python via the Windows Store, it is common that the
> > `python3.exe` entry in the `PATH` is not actually an executable at all,
Hi,
first of all: thank you for working on this. I have run afoul of the
(de-)quoting differences between MSVCRT and Cygwin on more than one
occasion.
Having said this, I hope to make it clear that I care about your work, and
I care about helping to make it as good as we can make it together.
It
ps://github.com/git-for-windows/git/issues/3281
Signed-off-by: Johannes Schindelin
---
This applies without merge conflict all the way back to
cygwin_2_7_0-release.
winsup/cygwin/fhandler_console.cc | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff
Hi Takashi,
sorry for responding to a patch you sent almost 10 months ago... but... I
am struggling with it.
First of all, let me describe the problem I am seeing (see also
https://github.com/git-for-windows/git/issues/3579): after upgrading the
MSYS2 runtime to v3.3.3 in Git for Windows, wheneve
Hi Takashi,
On Fri, 10 Dec 2021, Takashi Yano wrote:
> On Fri, 10 Dec 2021 00:05:27 +0100 (CET)
> Johannes Schindelin wrote:
> > sorry for responding to a patch you sent almost 10 months ago... but... I
> > am struggling with it.
> >
> > First of all, let me describ
https://github.com/msys2/msys2-runtime/issues/81
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/dont-confuse-a-xyz.lnk-directory-for-a-lnk-file-cygwin-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime
dont-confuse-a-xyz.lnk-directory-
e Cygwin runtime.
Therefore, let's just handle these symbolic links as implicit, virtual ones.
If there is appetite for it, I wonder whether we should do something similar
for `/dev/shm` and `/dev/mqueue`? Are these even still used in Cygwin?
Johannes Schindelin (2):
Implicitly support the /d
ial
devices.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/Makefile.am| 1 +
winsup/cygwin/devices.h | 3 +-
winsup/cygwin/devices.in | 4 +++
winsup/cygwin/dtable.cc | 3 ++
winsup/cygwin/fhandler.h | 28 +
winsup/cygwin/fhandler_dev
Hi Takashi,
On Sun, 20 Feb 2022, Takashi Yano wrote:
> - This patch commonize the code which processes special keys in pty
> and console to improve maintanancibility.
I very much welcome the direction. Thank you for working on this!
> As a result, some small bugs have been fixed.
Whenever I
Hi Corinna,
On Tue, 22 Feb 2022, Corinna Vinschen wrote:
> On Feb 21 14:36, Johannes Schindelin wrote:
> > These symbolic links are crucial e.g. to support process substitution
> > (Bash's
> > very nice `<(SOME-COMMAND)` feature).
> >
> > For va
mit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (3):
Allow deriving the current user's home directory via the HOME variable
Respect `db_home` setting even for SYSTEM/Microsoft accounts
Respect `db_home: env` even when no ui
tioned above: `$HOMEDRIVE$HOMEPATH` or
`$USERPROFILE`. This has the additional advantage that it is much
faster than querying the Windows user database.
Of course this scheme needs to be opt-in. For that reason, it needs
to be activated explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-of
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to /home/SYSTEM, especially not when that value
disagrees with what is configured via the `db_home` line in the
`/etc/nsswitch.conf` file.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc
a cloud scenario.
Reported by David Ebbo.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index 5e4243fa4e..b79c2b265d 100644
--- a/winsup/cygwin
Hi Corinna,
sorry for the blast from the past, but I am renewing my efforts to
upstream Git for Windows' patches that can be upstreamed.
On Thu, 17 Dec 2015, Corinna Vinschen wrote:
> On Dec 17 19:05, Johannes Schindelin wrote:
> > [...]
> > diff --git a/winsup/cygwin/uinf
Hi Corinna,
On Thu, 17 Dec 2015, Corinna Vinschen wrote:
> On Dec 17 19:05, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account to
> > /home/SYSTEM, especially not when that value disagrees with what is
> > configured via the
`Bad address` error.
Let's guard the code properly so that it does not try to look at the
file name suffix of `(WCHAR *)NULL`.
This fixes https://github.com/msys2/msys2-runtime/issues/108
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/t
On October 22, 2022 7:37:09 AM GMT+02:00, Takashi Yano
wrote:
>On Sat, 22 Oct 2022 10:54:06 +0900
>Takashi Yano wrote:
>> On Sat, 22 Oct 2022 10:36:39 +0900
>> Takashi Yano wrote:
>> > On Fri, 21 Oct 2022 23:37:35 +0200 (CEST)
>> > Johannes Schindelin wrot
On October 22, 2022 7:34:20 AM GMT+02:00, Takashi Yano
wrote:
>- If the command executed is 'cmd.exe /c [...]', runpath in spawn.cc
> will be NULL. In this case, is_console_app(runpath) check causes
> access violation. This case also the command executed is obviously
> console app., therefore,
Hi Takashi,
On Sat, 22 Oct 2022, Takashi Yano wrote:
> On Sat, 22 Oct 2022 07:58:37 +0200
> Johannes Schindelin wrote:
> > On October 22, 2022 7:34:20 AM GMT+02:00, Takashi Yano
> > wrote:
> > >- If the command executed is 'cmd.exe /c [...]', runpath in
Hi Takashi,
On Sat, 22 Oct 2022, Takashi Yano wrote:
> On Sat, 22 Oct 2022 07:55:53 +0200
> Johannes Schindelin wrote:
> > It's not very nice to simply drop my work, and then not even link to your
> > "counter".
>
> I am sorry, however, your patch can
Hi Corinna,
On Tue, 18 Oct 2022, Corinna Vinschen wrote:
> On Sep 21 13:58, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > sorry for the blast from the past, but I am renewing my efforts to
> > upstream Git for Windows' patches that can be upstreamed.
>
Hi Corinna,
On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> On Oct 23 23:04, Johannes Schindelin wrote:
> > On Tue, 18 Oct 2022, Corinna Vinschen wrote:
> > [...]
> > > That means, the results from the "env" method is equivalent to the
> > > "windo
Hi Corinna,
On Thu, 10 Nov 2022, Corinna Vinschen wrote:
> On Nov 10 16:16, Johannes Schindelin wrote:
>
> > On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> >
> > > On Oct 23 23:04, Johannes Schindelin wrote:
> > > > On Tue, 18 Oct 2022, Corinna Vinschen wr
Hi Corinna,
On Mon, 24 Oct 2022, Corinna Vinschen wrote:
> However, two points:
>
> - I'm wondering if the patch (both of yours) doesn't actually just cover
> a problem in child_info_spawn::worker(). Different runpath values,
> depending on the app path being "cmd" or "cmd.exe"? That sounds
Hi,
On Mon, 28 Nov 2022, Corinna Vinschen wrote:
> On Nov 28 13:00, Jon Turney wrote:
> > On 15/11/2022 10:46, Corinna Vinschen wrote:
> > >
> > > It would be great if we could get used to using the same syntax as the
> > > Linux kernel project to document stuff. I'm trying to follow their lead
On December 11, 2022 2:54:02 PM GMT+01:00, Jon Turney
wrote:
>On 05/12/2022 15:23, Johannes Schindelin wrote:
>> On Mon, 28 Nov 2022, Corinna Vinschen wrote:
>>> On Nov 28 13:00, Jon Turney wrote:
>>>> On 15/11/2022 10:46, Corinna Vinschen wrote:
>>>>
ected,
link to it in addition to `libbfd`.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/do-link-libsframe-if-available-v1
Fetch-It-Via: git fetch https://github.com/dscho/msys2-runtime
do-link-libsframe-if-available-v1
winsup/configu
VariableW()`/`cygwin_conv_path()` dance
- Adjusted the documentation to drive home that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts&quo
tioned above: `$HOMEDRIVE$HOMEPATH` or
`$USERPROFILE`. This has the additional advantage that it is much
faster than querying the Windows user database.
Of course this scheme needs to be opt-in. For that reason, it needs
to be activated explicitly via `db_home: env` in `/etc/nsswitch.conf`.
Signed-of
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to /home/SYSTEM, especially not when that value
disagrees with what is configured via the `db_home` line in the
`/etc/nsswitch.conf` file.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc
a cloud scenario.
Reported by David Ebbo.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index d493d29b3b..b01bcff5cb 100644
--- a/winsup/cygwin
Hi Corinna,
On Mon, 21 Nov 2022, Corinna Vinschen wrote:
> On Nov 18 09:18, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > On Thu, 10 Nov 2022, Corinna Vinschen wrote:
> > > On Nov 10 16:16, Johannes Schindelin wrote:
> > > > With this context in
Hi Jon,
On Wed, 14 Dec 2022, Jon Turney wrote:
> On 11/12/2022 14:45, Johannes Schindelin wrote:
> > On December 11, 2022 2:54:02 PM GMT+01:00, Jon Turney
> > wrote:
> > > On 05/12/2022 15:23, Johannes Schindelin wrote:
> > > > On Mon, 28 Nov 2022, Corinna Vi
Hi Corinna,
On Mon, 28 Feb 2022, Corinna Vinschen wrote:
> On Feb 28 10:24, Corinna Vinschen wrote:
> > On Feb 25 16:46, Johannes Schindelin wrote:
> > > On Tue, 22 Feb 2022, Corinna Vinschen wrote:
> > > > On Feb 21 14:36, Johannes Schindelin wrote:
> >
Hi Brian,
On Fri, 25 Feb 2022, Brian Inglis wrote:
> On 2022-02-21 06:36, Johannes Schindelin wrote:
> > These symbolic links are crucial e.g. to support process substitution
> > (Bash's
> > very nice `<(SOME-COMMAND)` feature).
> >
> > For various reaso
Hi Corinna,
On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 10:17, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account (or
> > of Microsoft accounts) to /home/SYSTEM, especially not
Hi Corinna & Jon,
On Wed, 29 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 15:31, Corinna Vinschen wrote:
> > On Mar 28 13:34, Jon Turney wrote:
> > > On 28/03/2023 11:35, Corinna Vinschen wrote:
> > > > Apart from the doc change, the patch is ok now.
> > >
> > > The preceding text says "Four sch
Hi Corinna,
On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> On Mar 28 10:17, Johannes Schindelin wrote:
> > In particular when we cannot figure out a uid for the current user, we
> > should still respect the `db_home: env` setting. Such a situation occurs
> > for example whe
Hi Corinna,
On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> On Tue, 28 Mar 2023, Corinna Vinschen wrote:
>
> > On Mar 28 10:17, Johannes Schindelin wrote:
> > > In particular when we cannot figure out a uid for the current user, we
> > > should still respect the
Hi Corinna,
On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> On Tue, 28 Mar 2023, Corinna Vinschen wrote:
>
> > On Mar 28 10:17, Johannes Schindelin wrote:
>
> > > diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
> > > index d493d29b3b..b01bcff5cb
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 08:36, Johannes Schindelin wrote:
> > Hi Corinna,
> >
> > On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> >
> > > On Mar 28 10:17, Johannes Schindelin wrote:
> > > > We should
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 15:12, Johannes Schindelin wrote:
>
> > On Mon, 3 Apr 2023, Johannes Schindelin wrote:
> >
> > > On Tue, 28 Mar 2023, Corinna Vinschen wrote:
> > >
> > > > On Mar 28 10:17, Johanne
t_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (3):
Allow deriving the current user's home directory via the HOME variable
Respect `db_home` setting even for SYSTEM/Microsoft accounts
Respect `db_home: env`
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ll receive the return
value -1, and the subsequent `getpwuid()` call (whose return value's
`pw_dir` is used as home directory) needs to be forced to respect
`db_home: env`, which this here patch does.
Reported-by: David Ebbo
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 1
he
`GetEnvironmentVariableW()`/`cygwin_conv_path()` dance
- Adjusted the documentation to drive home that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc c
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ce these IIS APPPOOL accounts are relatively similar to AzureAD
accounts in this scenario, let's imitate the latter to support also the
former.
Reported-by: David Ebbo
Helped-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 107
separator of
that `/etc/passwd`-formatted line, and instead of a Windows path, we now
have a mere drive letter.
Let's detect when the `HOME` value is still in Windows format in
`fetch_home_env ()`, and convert it in that case.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 8 ++
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 15:57, Johannes Schindelin wrote:
> > On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> > > > So here is what is going on:
> > > >
> > > > - The domain is 'IIS APPPOOL'
> &g
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 16:44, Johannes Schindelin wrote:
> > This patch hails from Git for Windows (where the Cygwin runtime is used
> > in the form of a slightly modified MSYS2 runtime), where it is a
> > well-established techni
Hi Corinna,
On Mon, 3 Apr 2023, Corinna Vinschen wrote:
> On Apr 3 16:45, Johannes Schindelin wrote:
> > We should not blindly set the home directory of the SYSTEM account (or
> > of Microsoft accounts) to `/home/`, especially
> > `/etc/nsswitch.conf` defines `db_home: e
Hi Corinna,
On Thu, 6 Apr 2023, Corinna Vinschen wrote:
> On Apr 4 17:07, Johannes Schindelin wrote:
> > In the very early code path where `dll_crt0_1 ()` calls
> > `user_shared->initialize ()`, the Cygwin runtime calls `internal_pwsid ()`
> > to initialize the user
ome that this only affects the
_current_ user's home directory
- Using the `PUSER_INFO_3` variant of `get_home()`
- Adjusted the commit messages
- Added another patch, to support "ad-hoc cloud accounts"
Johannes Schindelin (4):
Allow deriving the current user's home directory
ntation-fixes-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/local_includes/cygheap.h | 3 +-
winsup/cygwin/uinfo.cc | 51 ++
winsup/doc/ntsec.xml | 20 +-
3 files changed, 72 insertions(+), 2 deletion
We should not blindly set the home directory of the SYSTEM account (or
of Microsoft accounts) to `/home/`, especially
`/etc/nsswitch.conf` defines `db_home: env`, in which case we want to
respect the `HOME` variable.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 6 +-
1
ce these IIS APPPOOL accounts are relatively similar to AzureAD
accounts in this scenario, let's imitate the latter to support also the
former.
Reported-by: David Ebbo
Helped-by: Corinna Vinschen
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 107
y to include
absolute paths with drive prefixes, but also UNC paths.
Signed-off-by: Johannes Schindelin
---
winsup/cygwin/uinfo.cc | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
index 5e2d88bcd7..21d729d5dc 100644
--- a/
Reportedly Windows 11 build 25*** from Insider changed the current
working directory logic a bit, and Cygwin's "magic" (or:
"technologically sufficiently advanced") code needs to be adjusted
accordingly.
This fixes https://github.com/git-for-windows/git/issues/4429
like `readlinkat()`: `fchmodat()` and `fstatat()`.
Therefore, these two callers need to be changed to expect `ENOTDIR` in
case of an empty `pathname`, too.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-tar-xf-with-symlinks-cygwin-v1
Fetch-I
annot change mode to rwxr-xr-x: Not a directory
With this here fix, things start working as expected again.
Fixes: 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/msys2-runtime/releases/tag/fix-t
Hi Corinna,
On Mon, 3 Jul 2023, Corinna Vinschen wrote:
> Hi Johannes,
>
> On Jun 27 22:51, Johannes Schindelin wrote:
> > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
> > the code of `readlinkat()` was adjusted to align the `errno` with Linux'
Hi Jeremy,
On Wed, 28 Jun 2023, Jeremy Drake wrote:
> On Tue, 27 Jun 2023, Johannes Schindelin wrote:
>
> > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18)
> > the code of `readlinkat()` was adjusted to align the `errno` with Linux'
> > behavio
Hi Takashi,
On Tue, 4 Jul 2023, Takashi Yano wrote:
> On Mon, 3 Jul 2023 12:52:25 +0200
> Corinna Vinschen wrote:
> >
> > On Jun 27 22:28, Takashi Yano wrote:
> > >
> > > diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc
> > > index 18e0f3097..9427e238e 100644
> > > --- a/winsup/cygw
ly, this returns a valid path in path_ret. That
> > in turn allows to remove the additional path generation code
> > from the callers.
> >
> > Fixes: fa84aa4dd2fb ("Cygwin: fix errno values set by readlinkat")
> > Reported-by: Johannes Schindelin
>
1 - 100 of 118 matches
Mail list logo
